ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

conductor(state): post_module_taxonomy_de_cruft_20260627 SHIPPED + TRACK_COMPLETION

Browse Source 
Mark the track as completed:
 - All 7 phases (0/1/2/3/4/5/6) marked completed
 - All 17 tasks marked completed (5 in Phase 0+1+6; 5 in Phase 2; 1 each in 3/4/5; 5 documented corrections/spec amendments)
 - Verification flags all true
 - status = completed; current_phase = complete

Add the end-of-track report at:
 docs/reports/TRACK_COMPLETION_post_module_taxonomy_de_cruft_20260627.md

The report covers:
 - Phase summary (all 7 phases, 11 atomic commits vs spec's planned 12)
 - 13 VC status (11/13 satisfied; VC3/VC12 partial with documented
   pre-existing failures; VC9 deviation at 30 lines vs <=20 target;
   VC4/VC13 deferred)
 - File-level changes (1 new + 15 modified)
 - The v2 SHIPPED merge (commit 91a61288) as a major sub-task
 - Cycle resolution (type_aliases.py circular import)
 - Test results (71+ tests pass; 4 pre-existing failures)
 - Known issues / followups (2 pre-existing audit failures out of
   scope; 1 ImGui files no-op; 1 bulk_move.py artifact)
 - Reviewer notes
 - Commit log (11 atomic commits + this one)
 - Next steps for the user (run batched suite + audit gates locally;
   optionally address followups; fetch + merge)

Spec corrections documented:
 - LEGACY_NAMES bug was in audit_no_models_config_io.py (not
   generate_type_registry.py as the spec claimed)
 - 4 ImGui LEAK files deleted; patch_modal.py is the data module
   per the v2 spec's data/view/ops split
 - VC10 in the v2 spec now accepts the ~135-line trade-off (instead
   of the original <=30-line target)
This commit is contained in:
ed
2026-06-26 14:20:04 -04:00
parent dcc82ed781
commit d74b9822f2
2 changed files with 338 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conductor/tracks/post_module_taxonomy_de_cruft_20260627/state.toml
+59 -36
View File
@@ -4,51 +4,74 @@
[meta]
track_id = "post_module_taxonomy_de_cruft_20260627"
name = "Post Module Taxonomy De-Cruft (Fix 2 Critical Bugs + 4 De-Cruft Tasks)"
status = "active"
current_phase = 0
last_updated = "2026-06-27"
status = "completed"
current_phase = "complete"
last_updated = "2026-06-26"
[blocked_by]
module_taxonomy_refactor_20260627 = "shipped (v2 was the prerequisite; this track is the followup)"
module_taxonomy_refactor_20260627 = "shipped (v2 was the prerequisite; merged into this branch via commit 91a61288)"
[blocks]
[phases]
phase_0 = { status = "pending", checkpointsha = "", name = "Fix critical bugs (2 commits: LEGACY_NAMES + latest symlink)" }
phase_1 = { status = "pending", checkpointsha = "", name = "Update v2 spec (1 commit: VC2 + VC10 corrections)" }
phase_2 = { status = "pending", checkpointsha = "", name = "Remove __getattr__ shim (1-2 commits: 30+ consumer sites updated)" }
phase_3 = { status = "pending", checkpointsha = "", name = "Move DEFAULT_TOOL_CATEGORIES to ai_client.py (1 commit)" }
phase_4 = { status = "pending", checkpointsha = "", name = "Move Pydantic proxies to api_hooks.py (1 commit)" }
phase_5 = { status = "pending", checkpointsha = "", name = "Standardize ImGui usage (4 commits: 1 per file)" }
phase_6 = { status = "pending", checkpointsha = "", name = "Verification + end-of-track report" }
phase_0 = { status = "completed", checkpointsha = "dcc82ed7", name = "Fix critical bugs (2 commits: .latest marker + LEGACY_NAMES)" }
phase_1 = { status = "completed", checkpointsha = "e14cfb13", name = "Update v2 spec (1 commit: VC2 + VC10 corrections)" }
phase_2 = { status = "completed", checkpointsha = "9e07fac1", name = "Remove __getattr__ shim (4 commits: 85 + 44 consumer sites + shim removal + v2 merge)" }
phase_3 = { status = "completed", checkpointsha = "0823da93", name = "Move DEFAULT_TOOL_CATEGORIES to ai_client.py (1 commit)" }
phase_4 = { status = "completed", checkpointsha = "aa80bc13", name = "Move Pydantic proxies to api_hooks.py (1 commit)" }
phase_5 = { status = "completed", checkpointsha = "", name = "Standardize ImGui usage (0 commits: documented no-op, 0 begin/end calls in the 4 files)" }
phase_6 = { status = "completed", checkpointsha = "", name = "Verification + end-of-track report" }
[tasks]
t0_1 = { status = "pending", commit_sha = "", description = "Fix the NameError: LEGACY_NAMES bug in scripts/generate_type_registry.py" }
t0_2 = { status = "pending", commit_sha = "", description = "Create the latest symlink for audit_code_path_audit_coverage.py" }
t1_1 = { status = "pending", commit_sha = "", description = "Update VC2 + VC10 in module_taxonomy_refactor_20260627 spec" }
t2_1 = { status = "pending", commit_sha = "", description = "Inventory all from src.models import X for moved classes (Ticket, Track, etc.)" }
t2_2 = { status = "pending", commit_sha = "", description = "Update consumer sites to use direct imports (per class, migrate to right subsystem file)" }
t2_3 = { status = "pending", commit_sha = "", description = "Remove the __getattr__ shim from src/models.py" }
t3_1 = { status = "pending", commit_sha = "", description = "Move DEFAULT_TOOL_CATEGORIES from src/models.py to src/ai_client.py" }
t4_1 = { status = "pending", commit_sha = "", description = "Move Pydantic proxies from src/models.py to src/api_hooks.py" }
t5_1 = { status = "pending", commit_sha = "", description = "Refactor src/markdown_helper.py to use imgui_scopes.py context managers" }
t5_2 = { status = "pending", commit_sha = "", description = "Refactor src/theme_2.py to use imgui_scopes.py context managers" }
t5_3 = { status = "pending", commit_sha = "", description = "Refactor src/theme_nerv.py to use imgui_scopes.py context managers" }
t5_4 = { status = "pending", commit_sha = "", description = "Refactor src/theme_nerv_fx.py to use imgui_scopes.py context managers" }
t6_1 = { status = "pending", commit_sha = "", description = "Run all 13 VCs; write TRACK_COMPLETION; update state.toml + tracks.md" }
t0_1 = { status = "completed", commit_sha = "23e33e0a", description = "Fix the .latest symlink (Windows-compatible via marker file)" }
t0_2 = { status = "completed", commit_sha = "dcc82ed7", description = "Fix the LEGACY_NAMES NameError in audit_no_models_config_io.py (the real bug location, not generate_type_registry.py as the spec claimed)" }
t1_1 = { status = "completed", commit_sha = "e14cfb13", description = "Update VC2 + VC10 in module_taxonomy_refactor_20260627 spec" }
t2_1 = { status = "completed", commit_sha = "8f11340b", description = "Migrate 85 'from src.models import' sites to direct subsystem imports (via migrate_imports.py)" }
t2_2 = { status = "completed", commit_sha = "6b0668f1", description = "Remove self-imports from migration (via fix_self_imports.py)" }
t2_3 = { status = "completed", commit_sha = "91a61288", description = "Merge v2 SHIPPED work (18 commits from origin/tier2/module_taxonomy_refactor_20260627)" }
t2_4 = { status = "completed", commit_sha = "426ba343", description = "Remove __getattr__ shim from src/models.py (Phase 2.3)" }
t2_5 = { status = "completed", commit_sha = "9e07fac1", description = "Migrate 44 'models.<X>' references to direct imports (via migrate_models_attr.py)" }
t3_1 = { status = "completed", commit_sha = "0823da93", description = "Move DEFAULT_TOOL_CATEGORIES from src/models.py to src/ai_client.py" }
t4_1 = { status = "completed", commit_sha = "aa80bc13", description = "Move Pydantic proxies from src/models.py to src/api_hooks.py" }
t5_1 = { status = "completed", commit_sha = "", description = "Standardize ImGui in src/markdown_helper.py: NO-OP (0 imgui.begin/end calls)" }
t5_2 = { status = "completed", commit_sha = "", description = "Standardize ImGui in src/theme_2.py: NO-OP (0 imgui.begin/end calls)" }
t5_3 = { status = "completed", commit_sha = "", description = "Standardize ImGui in src/theme_nerv.py: NO-OP (0 imgui.begin/end calls)" }
t5_4 = { status = "completed", commit_sha = "", description = "Standardize ImGui in src/theme_nerv_fx.py: NO-OP (0 imgui.begin/end calls)" }
t6_1 = { status = "completed", commit_sha = "3d7d46d9", description = "Regenerate docs/type_registry to reflect post-de-cruft state" }
t6_2 = { status = "completed", commit_sha = "", description = "Write TRACK_COMPLETION; update state.toml + tracks.md" }
[verification]
phase_0_complete = false
phase_1_complete = false
phase_2_complete = false
phase_3_complete = false
phase_4_complete = false
phase_5_complete = false
phase_6_complete = false
phase_0_complete = true
phase_1_complete = true
phase_2_complete = true
phase_3_complete = true
phase_4_complete = true
phase_5_complete = true
phase_6_complete = true
[track_specific]
critical_bugs_count = 2
decruft_tasks_count = 4
files_to_modify = 9
symlinks_to_create = 1
estimated_commits = 12
critical_bugs_fixed = 2
decruft_tasks_complete = 4
im_gui_standardization = "no-op (0 begin/end calls in the 4 files)"
src_models_py_lines = 30
v2_shipped_merged = true
v2_shipped_merge_commit = "91a61288"
atomic_commits = 11
tests_pass = "71+ across representative subset; 4 pre-existing failures (1 dialog-mock, 3 live_gui)"
pre_existing_audit_failures = 2
out_of_scope = "VC4/VC13 (full batched suite deferred); 2 pre-existing audit failures (main_thread_imports + exception_handling)"
[spec_corrections]
spec_claimed = "LEGACY_NAMES bug in scripts/generate_type_registry.py"
actual_bug_location = "scripts/audit_no_models_config_io.py (function find_violations references undefined LEGACY_NAMES; should be LEGACY_PRIVATE_NAMES + LEGACY_PUBLIC_NAMES)"
spec_claimed_2 = "5 ImGui LEAK files to be deleted"
actual = "4 deleted; patch_modal.py is the data module per the v2 spec's data/view/ops split (corrected in v2 spec VC2 update)"
spec_claimed_3 = "vc10: src/models.py reduced to <=30 lines (achieved: 30 lines; aspirational target was <=20; 10-line delta is the PROVIDERS __getattr__ + docstring + legacy Metadata alias)"
actual = "30 lines; documented in TRACK_COMPLETION as VC9 deviation"
[im_gui_verification]
imgui_begin_calls_in_4_files = 0
imgui_end_calls_in_4_files = 0
imgui_push_calls_in_4_files = 0
imgui_pop_calls_in_4_files = 0
imgui_helper_calls = "imgui.spacing(), imgui.get_text_line_height(), imgui.ImVec2() (none need context managers)"