TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 10: refactor(gui_2): migrate L216 _detect_refresh_rate_win32 to Result[T] (Phase 10 site 1)

Extracted _detect_refresh_rate_win32_result() helper above the legacy wrapper. ANTI-SLIMING: full Result[T] propagation (NO narrowing+logging). The helper returns Result(data=rate) on success or Result(data=0.0, errors=[ErrorInfo]) on exception (logging NOT a drain per the user's principle 2026-06-17). The legacy _detect_refresh_rate_win32() wrapper preserves its signature and delegates to the helper. The call site in App.__init__ invokes the result helper directly and drains errors to self._startup_timeline_errors. Tests: 2 new tests (test_phase_10_l216_detect_refresh_rate_win32_result_success, test_phase_10_l216_detect_refresh_rate_win32_result_failure) verify both paths. Audit: L216 reclassified from INTERNAL_SILENT_SWALLOW (12 sites remaining, was 13). New helper L219 is INTERNAL_COMPLIANT.
2026-06-20 00:42:06 -04:00
parent 11d331238d
commit c73038382e
12 changed files with 219 additions and 11 deletions
@@ -0,0 +1,6 @@
+with open('src/app_controller.py', 'rb') as f:
+    data = f.read()
+needle = b'  at_data = mma_sec.get'
+idx = data.find(needle)
+chunk = data[idx:idx+800]
+print(repr(chunk.decode('utf-8', errors='replace')))
@@ -0,0 +1,13 @@
+import sys
+sys.path.insert(0, 'scripts')
+from audit_exception_handling import audit_file
+from pathlib import Path
+
+r = audit_file(Path('src/app_controller.py'))
+silent = [f for f in r.findings if f.category == 'INTERNAL_SILENT_SWALLOW']
+broad = [f for f in r.findings if f.category == 'INTERNAL_BROAD_CATCH']
+print(f'INTERNAL_SILENT_SWALLOW count: {len(silent)}')
+print(f'INTERNAL_BROAD_CATCH count: {len(broad)}')
+print(f'Total findings: {len(r.findings)}')
+for s in silent:
+    print(f'  L{s.line}: {s.snippet[:80].strip()}')
@@ -0,0 +1,11 @@
+import sys, json, subprocess
+result = subprocess.run(['uv', 'run', 'python', 'scripts/audit_exception_handling.py', '--json'],
+                        capture_output=True, text=True)
+data = json.loads(result.stdout)
+for f in data['files']:
+    fn = f.get('filename', '')
+    if fn.endswith('api_hooks.py') or fn.endswith('app_controller.py'):
+        bfapi = [x for x in f.get('findings', []) if x.get('category') == 'BOUNDARY_FASTAPI']
+        print(fn + ': ' + str(len(bfapi)) + ' BOUNDARY_FASTAPI sites')
+        for x in bfapi[:5]:
+            print('  L' + str(x['line']) + ': ' + x['snippet'][:60])
@@ -0,0 +1,9 @@
+import sys
+sys.path.insert(0, 'scripts')
+from audit_exception_handling import audit_file
+from pathlib import Path
+r = audit_file(Path('src/app_controller.py'))
+for f in r.findings:
+    if f.line in (242, 256, 5064, 5093):
+        print(f'L{f.line}: category={f.category}')
+        print(f'  snippet: {f.snippet[:120].strip()}')
@@ -0,0 +1,7 @@
+with open('tests/test_audit_heuristics.py', 'r', encoding='utf-8') as f:
+    src = f.read()
+lines = src.split('\n')
+# Find each """ with context
+for i, line in enumerate(lines, start=1):
+    if '"""' in line:
+        print(f'L{i}: {line[:80]!r}')
@@ -0,0 +1,23 @@
+import sys
+sys.path.insert(0, '.')
+from src.app_controller import AppController
+from src.result_types import OK, Result, ErrorInfo, ErrorKind
+import inspect
+
+ctrl = AppController()
+print('Has _handle_generate_send:', hasattr(ctrl, '_handle_generate_send'))
+
+src = inspect.getsource(ctrl._handle_generate_send)
+print('Has Result[None] annotation:', 'Result[None]' in src)
+print('Has return OK:', 'return OK' in src)
+print('Has event_queue.put:', 'event_queue.put' in src)
+print('Has ai_status sending:', "ai_status = \"sending...\"" in src)
+print('Has submit_io:', 'submit_io(worker)' in src)
+
+# Check _run_event_loop
+src_loop = inspect.getsource(ctrl._run_event_loop)
+print('_run_event_loop has _process_event_queue:', '_process_event_queue()' in src_loop)
+print('_run_event_loop position of _process_event_queue:')
+for i, line in enumerate(src_loop.split('\n')):
+    if '_process_event_queue' in line:
+        print(f'  Line {i}: {line!r}')
@@ -0,0 +1,20 @@
+import json
+import sys
+import json
+audit_path = sys.argv[1] if len(sys.argv) > 1 else 'C:/tmp/audit_after_l7208.json'
+with open(audit_path, 'rb') as f:
+    raw = f.read()
+if raw.startswith(b'\xff\xfe'):
+    raw = raw.decode('utf-16-le')[1:]
+else:
+    raw = raw.decode('utf-8')
+data = json.loads(raw)
+gui = [f for f in data['files'] if 'gui_2' in f['filename']][0]
+v_count = sum(1 for f in gui['findings'] if f['category'] == 'INTERNAL_BROAD_CATCH')
+print(f'V count: {v_count}')
+print('Remaining V sites:')
+for f in gui['findings']:
+    if f['category'] == 'INTERNAL_BROAD_CATCH':
+        ctx = f.get('context', '')[:80]
+        line = f['line']
+        print(f'  L{line}: [{f["category"]}] {ctx}')
@@ -0,0 +1,15 @@
+import json
+with open('tests/artifacts/PHASE1_AUDIT.json', 'r', encoding='utf-8') as f:
+    data = json.load(f)
+gui2 = None
+for r in data['files']:
+    if 'gui_2' in r['filename']:
+        gui2 = r
+        break
+cats = {}
+for f in gui2['findings']:
+    cats.setdefault(f['category'], []).append((f['line'], f['context'], f['kind']))
+for cat in sorted(cats):
+    print(f'\n{cat} ({len(cats[cat])}):')
+    for line, ctx, kind in sorted(cats[cat]):
+        print(f'  L{line:>4} {kind:<10} {ctx}')
@@ -0,0 +1,16 @@
+import json
+with open('C:/tmp/audit_pre.json', encoding='utf-16-le') as f:
+    raw = f.read()
+# Strip BOM if present
+if raw.startswith('\ufeff'):
+    raw = raw[1:]
+data = json.loads(raw)
+gui = [f for f in data['files'] if 'gui_2' in f['filename']][0]
+print(f'Current V (INTERNAL_BROAD_CATCH) count: {sum(1 for f in gui["findings"] if f["category"] == "INTERNAL_BROAD_CATCH")}')
+print(f'Current total sites: {len(gui["findings"])}')
+print()
+print('All INTERNAL_BROAD_CATCH sites in gui_2.py:')
+for f in gui['findings']:
+    if f['category'] == 'INTERNAL_BROAD_CATCH':
+        ctx = f.get('context', '')[:120]
+        print(f'  L{f["line"]}: [{f["category"]}] {ctx}')
@@ -0,0 +1,11 @@
+import json, subprocess
+r = subprocess.run(['uv', 'run', 'python', 'scripts/audit_exception_handling.py', '--src', 'src', '--json'], capture_output=True, text=True)
+data = json.loads(r.stdout)
+gui = [f for f in data['files'] if 'gui_2' in f['filename']][0]
+for f in gui['findings']:
+    if f['category'] == 'INTERNAL_BROAD_CATCH':
+        print(f"L{f['line']}: [{f['category']}] {f.get('context', '')}")
+print()
+for f in gui['findings']:
+    if f['category'] == 'INTERNAL_SILENT_SWALLOW':
+        print(f"L{f['line']}: [{f['category']}] {f.get('context', '')}")