refactor(ai_client): obliterate 5 legacy model-list wrappers (Phase 4)

Phase 4 (5 of 9 cruft sites obliterated):

OBLITERATED wrappers:
1. _reread_file_items (4 callers in _send_gemini + _send_gemini_cli + 2 others)
2. _list_anthropic_models (1 caller in list_models)
3. _list_gemini_models (1 caller in list_models)
4. _extract_gemini_thoughts (1 caller in _send_gemini)
5. _list_minimax_models (2 callers in _set_minimax_provider_result + set_provider)

Migration: each caller now uses the _result sibling directly with .ok check
+ .data extraction. The Result[T] error context (structured ErrorInfo) is now
propagated instead of dropped. _send_gemini gets .data with explicit .ok check.

Updated tests to assert OBLITERATED state (5 sub-track 5 tests inverted from
'_legacy_preserved' to '_legacy_obliterated'):
- tests/test_baseline_result.py: test_phase9_redo_modules_import_cleanly
- tests/tier2/phase10_invariant_test.py: _list_gemini_models removed from list
- tests/tier2/phase10_site1_test.py: _legacy_unchanged -> _legacy_obliterated
- tests/tier2/phase11_invariant_test.py: _extract/_list_minimax moved to obliterated
- tests/tier2/phase11_sites78_test.py: _legacy_preserved -> _legacy_obliterated
- tests/tier2/phase12_invariant_test.py: _list_anthropic moved to obliterated
- tests/tier2/phase12_site4_test.py: _legacy_preserved -> _legacy_obliterated
- tests/test_gemini_thinking_format.py: helper uses _result directly
- tests/test_cruft_removal.py: 5 new obliterated-wrappers invariant tests

Test result: 122/122 pass (31 baseline + 16 heuristic + 9 cruft + 5 thinking + 61 tier2).
Audit gate: src/ai_client.py --strict exits 0 (no new violations introduced).
Wrapper count: 9 -> 3 (Phase 5-6 remaining: rag_engine 1, gui_2 2).

tests/tier2/phase12_invariant_test.py

@@ -43,14 +43,18 @@ def test_phase12_list_anthropic_models_result_exists():
 
 
 def test_phase12_legacy_functions_preserved():
-    """Legacy functions must still exist."""
+    """Legacy functions preserved EXCEPT _list_anthropic_models OBLITERATED by cruft-removal Phase 4."""
     import src.ai_client
-    for name in ("_load_credentials",
-                 "_list_anthropic_models",
-                 "_default_send",
-                 "_dashscope_call"):
-        assert hasattr(src.ai_client, name) or name == "_default_send", \
-            f"{name} legacy function missing"
-        # _default_send is nested; check via run_with_tool_loop
-    # The nested _default_send is part of run_with_tool_loop
-    assert callable(getattr(src.ai_client, "run_with_tool_loop", None))
+    # _default_send is nested inside run_with_tool_loop; check via getattr with fallback
+    preserved = ("_load_credentials", "_dashscope_call")
+    obliterated = ("_list_anthropic_models",)
+    for name in preserved:
+        assert hasattr(src.ai_client, name), f"{name} legacy function missing"
+    # The nested _default_send is part of run_with_tool_loop (not a top-level attr)
+    assert callable(getattr(src.ai_client, "run_with_tool_loop", None)), \
+        "run_with_tool_loop must exist (contains nested _default_send)"
+    for name in obliterated:
+        assert not hasattr(src.ai_client, name), (
+            f"{name} wrapper must be OBLITERATED (cruft-removal Phase 4); "
+            f"callers must use {name}_result directly"
+        )