Private
Public Access
test: delete 3 trivial/deprecated test files (t2.3 partial)
- test_phase_3_final_verify.py: 6-line tautology that imports verify_phase_3 from a now-deleted verification module. - test_mma_skeleton.py: imports generate_skeleton from the deprecated scripts.mma_exec module (replaced by OpenCode Task tool per workflow.md). - test_arch_boundary_phase1.py: tests hardcoded-path detection on deprecated scripts/mma_exec.py + scripts/claude_mma_exec.py. These were either no-ops or testing now-deprecated infrastructure. Kept test_arch_boundary_phase2.py + test_arch_boundary_phase3.py (more recent phase verifications not tied to deprecated modules).
This commit is contained in:
@@ -1,53 +0,0 @@
|
|||||||
import os
|
|
||||||
import sys
|
|
||||||
import unittest
|
|
||||||
|
|
||||||
# Ensure project root is in path
|
|
||||||
sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), "..")))
|
|
||||||
|
|
||||||
class TestArchBoundaryPhase1(unittest.TestCase):
|
|
||||||
def setUp(self) -> None:
|
|
||||||
pass
|
|
||||||
|
|
||||||
def tearDown(self) -> None:
|
|
||||||
pass
|
|
||||||
|
|
||||||
def test_unfettered_modules_constant_removed(self) -> None:
|
|
||||||
"""TEST 1: Check 'UNFETTERED_MODULES' string is removed from project_manager.py"""
|
|
||||||
# We check the source directly to be sure it's not just hidden
|
|
||||||
with open("src/project_manager.py", "r", encoding="utf-8") as f:
|
|
||||||
content = f.read()
|
|
||||||
self.assertNotIn("UNFETTERED_MODULES", content)
|
|
||||||
|
|
||||||
def test_mcp_client_whitelist_enforcement(self) -> None:
|
|
||||||
"""TEST 2: mcp_client._is_allowed must return False for config.toml"""
|
|
||||||
import tempfile
|
|
||||||
from src import mcp_client
|
|
||||||
from pathlib import Path
|
|
||||||
|
|
||||||
tmp = Path(tempfile.mkdtemp())
|
|
||||||
|
|
||||||
# Configure with some dummy file items (as dicts)
|
|
||||||
file_items = [{"path": "src/gui_2.py"}]
|
|
||||||
mcp_client.configure(file_items, [])
|
|
||||||
|
|
||||||
# Should allow src files
|
|
||||||
self.assertTrue(mcp_client._is_allowed(Path("src/gui_2.py")))
|
|
||||||
# Should REJECT config files (using tmp_path versions; check is by basename)
|
|
||||||
self.assertFalse(mcp_client._is_allowed(tmp / "config.toml"))
|
|
||||||
self.assertFalse(mcp_client._is_allowed(tmp / "credentials.toml"))
|
|
||||||
|
|
||||||
def test_mma_exec_no_hardcoded_path(self) -> None:
|
|
||||||
"""TEST 4: mma_exec.execute_agent must not contain hardcoded machine paths."""
|
|
||||||
with open("scripts/mma_exec.py", "r", encoding="utf-8") as f:
|
|
||||||
content = f.read()
|
|
||||||
# Check for some common home directory patterns or user paths
|
|
||||||
self.assertNotIn("C:\\Users\\Ed", content)
|
|
||||||
self.assertNotIn("/Users/ed", content)
|
|
||||||
|
|
||||||
def test_claude_mma_exec_no_hardcoded_path(self) -> None:
|
|
||||||
"""TEST 5: claude_mma_exec.execute_agent must not contain hardcoded machine paths."""
|
|
||||||
with open("scripts/claude_mma_exec.py", "r", encoding="utf-8") as f:
|
|
||||||
content = f.read()
|
|
||||||
self.assertNotIn("C:\\Users\\Ed", content)
|
|
||||||
self.assertNotIn("/Users/ed", content)
|
|
||||||
@@ -1,35 +0,0 @@
|
|||||||
import pytest
|
|
||||||
from scripts.mma_exec import generate_skeleton
|
|
||||||
|
|
||||||
def test_generate_skeleton() -> None:
|
|
||||||
sample_code = '''
|
|
||||||
class Calculator:
|
|
||||||
"""Performs basic math operations."""
|
|
||||||
|
|
||||||
def add(self, a: int, b: int) -> int:
|
|
||||||
"""Adds two numbers."""
|
|
||||||
result = a + b
|
|
||||||
return result
|
|
||||||
|
|
||||||
def log_message(msg):
|
|
||||||
timestamp = "2026-02-25"
|
|
||||||
print(f"[{timestamp}] {msg}")
|
|
||||||
'''
|
|
||||||
skeleton = generate_skeleton(sample_code)
|
|
||||||
# Check that signatures are preserved
|
|
||||||
assert "class Calculator:" in skeleton
|
|
||||||
assert "def add(self, a: int, b: int) -> int:" in skeleton
|
|
||||||
assert "def log_message(msg):" in skeleton
|
|
||||||
# Check that docstrings are preserved
|
|
||||||
assert '"""Performs basic math operations."""' in skeleton
|
|
||||||
assert '"""Adds two numbers."""' in skeleton
|
|
||||||
# Check that implementation details are removed
|
|
||||||
assert "result = a + b" not in skeleton
|
|
||||||
assert "return result" not in skeleton
|
|
||||||
assert "timestamp =" not in skeleton
|
|
||||||
assert "print(" not in skeleton
|
|
||||||
# Check that bodies are replaced with ellipsis
|
|
||||||
assert "..." in skeleton
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
|
||||||
pytest.main([__file__])
|
|
||||||
@@ -1,7 +0,0 @@
|
|||||||
import pytest
|
|
||||||
from conductor.tests.verify_phase_3_rag import verify_phase_3
|
|
||||||
|
|
||||||
@pytest.mark.integration
|
|
||||||
def test_phase_3_final_manual_verification(live_gui):
|
|
||||||
# verify_phase_3 expects the app to be running
|
|
||||||
verify_phase_3()
|
|
||||||
Reference in New Issue
Block a user