ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

docs: fix 3 more unverified claims (4-thread->8, 12 locks->11, _search_mcp real)

Browse Source 
Re-audit after reading the actual full file contents:

1. guide_app_controller.md (the __init__ walkthrough):
   - '4-thread ThreadPoolExecutor' -> '8-thread' per IO_POOL_MAX_WORKERS = 8
     in src/io_pool.py:20 (bumped from 4 in commit 4a338486; the io_pool.py
     module docstring is also stale and says '4 worker threads' - flagged
     for a separate fix).
   - '12 locks' -> '11 locks + 5 non-lock state fields' (re-counted the
     threading.Lock() and the _rag_sync_*/_project_switch_* fields).

2. guide_app_controller.md (the closing line):
   - '12 locks' -> removed; explained the 434-line __init__ body
     composition (locks + state fields + settable_fields + gui_task_handlers).

3. guide_rag.md (Future Work section):
   - 'The _search_mcp method is a placeholder for this' -> WRONG.
     _search_mcp (src/rag_engine.py:322) IS a real implementation that
     calls mcp_client.async_dispatch when vector_store.provider == 'mcp'.
     Rewrote the future-work item to describe the actual mechanism.

4. docs/reports/docs_sync_test_era_20260610.md (the closing report):
   - Same 4-thread->8 and 12-locks->11 corrections propagated.

The structural facts (WorkspaceProfile/RAGConfig/VectorStoreConfig field
lists, method existence, _init_actions/_load_active_project line
numbers, _LiveGuiHandle existence, etc.) were all correct. The
counting/threading-pool claims I cited from memory were the ones
that needed re-verification.
This commit is contained in:
Edward R. Gonzalez
2026-06-10 20:49:20 -04:00
parent 994ded3598
commit bb1aa3e03c
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/reports/docs_sync_test_era_20260610.md
+1 -1
View File
@@ -51,7 +51,7 @@ End-state cleanup of the 4-day test-hell saga (regression_fixes → test_infrast
| `guide_api_hooks.md` | 4 new warmup endpoints added (`/api/warmup_status`, `/api/warmup_wait`, `/api/warmup_canaries`, `/api/startup_timeline`); new §Warmup API section |
| `guide_testing.md` | **CRITICAL**: `tmp_path_factory` (banned) → `tests/artifacts/live_gui_workspace_<timestamp>` (per-run) for `live_gui_workspace` fixture; 8 new sections (Watchdog, Chroma Cache, xdist, Dependencies Gate, MMA/RAG reset_session, etc.) |
| `guide_mcp_client.md` | Tool count 45→46, Python AST 15→18; added 4 structural mutator tools (`py_remove_def`, `py_add_def`, `py_move_def`, `py_region_wrap`) |
| `guide_app_controller.md` | Fictional `AppState` dataclass + `register_hooks` method + `enable_test_hooks` param removed; real `__init__` flow documented (timeline anchors, 12 locks, GUI health state, io_pool, warmup manager) |
| `guide_app_controller.md` | Fictional `AppState` dataclass + `register_hooks` method + `enable_test_hooks` param removed; real `__init__` flow documented (timeline anchors, **11 locks + 5 non-lock state fields**, GUI health state, **8-thread** io_pool, warmup manager) |
| `Readme.md` | WorkspaceProfile description + guide_gui_2 line refs updated |
### End-state cleanup (4 tracks archived)