refactor(phase5): Comprehensive stabilisation pass. De-duplicated App/Controller state, hardened session reset, and updated integration tests with deterministic polling.

src/gui_2.py

@@ -137,19 +137,9 @@ class App:
    self.screenshots = ['test.png']
    self.save_context_preset(name)
   self.controller._predefined_callbacks['simulate_save_preset'] = simulate_save_preset
-  self.show_preset_manager_window = False
-  self.show_tool_preset_manager_window = False
-  self.show_persona_editor_window = False
-  self.show_text_viewer = False
-  self.text_viewer_title = ''
-  self.text_viewer_content = ''
-  self.text_viewer_type = 'text'
   self.text_viewer_wrap = True
   self._text_viewer_editor: Optional[ced.TextEditor] = None
-  self.ui_active_tool_preset = ""
-  self.ui_active_bias_profile = ""
   self.ui_active_context_preset = ""
-  self.ui_active_persona = ""
   self._editing_persona_name = ""
   self._editing_persona_description = ""
   self._editing_persona_provider = ""
@@ -217,16 +207,6 @@ class App:
   self.ui_new_ticket_priority: str = 'medium'
   self._autofocus_response_tab = False
   gui_cfg = self.config.get("gui", {})
-  self.ui_separate_message_panel = gui_cfg.get("separate_message_panel", False)
-  self.ui_separate_response_panel = gui_cfg.get("separate_response_panel", False)
-  self.ui_separate_tool_calls_panel = gui_cfg.get("separate_tool_calls_panel", False)
-  self.ui_separate_task_dag = gui_cfg.get("separate_task_dag", False)
-  self.ui_separate_usage_analytics = gui_cfg.get("separate_usage_analytics", False)
-  self.ui_separate_tier1 = gui_cfg.get("separate_tier1", False)
-  self.ui_separate_tier2 = gui_cfg.get("separate_tier2", False)
-  self.ui_separate_tier3 = gui_cfg.get("separate_tier3", False)
-  self.ui_separate_tier4 = gui_cfg.get("separate_tier4", False)
-  self.ui_separate_external_tools = gui_cfg.get('separate_external_tools', False)
   self.show_windows.setdefault("Usage Analytics", False)
   self.show_windows.setdefault("Tier 1: Strategy", False)
   self.show_windows.setdefault("Tier 2: Tech Lead", False)
@@ -246,10 +226,7 @@ class App:
   self._tool_log_cache: list[dict[str, Any]] = []
   self._last_ui_focus_agent: Optional[str] = None
   self._log_registry: Optional[log_registry.LogRegistry] = None
-  self.perf_profiling_enabled = False
   self.perf_show_graphs: dict[str, bool] = {}
-  self._token_stats: dict[str, Any] = {}
-  self.perf_history: dict[str, list] = {"frame_time": [0.0] * 100, "fps": [0.0] * 100}
   self._nerv_crt = theme_fx.CRTFilter()
   self.ui_crt_filter = True
   self._nerv_alert = theme_fx.AlertPulsing()
@@ -512,8 +489,8 @@ class App:
    # ---------------------------------------------------------------- helpers
 
  def _render_text_viewer(self, label: str, content: str, text_type: str = 'text', force_open: bool = False) -> None:
-  self.text_viewer_type = text_type
   if imgui.button("[+]##" + str(id(content))) or force_open:
+   self.text_viewer_type = text_type
    self.show_text_viewer = True
    self.text_viewer_title = label
    self.text_viewer_content = content