fix(post_de_cruft_iter2): fix 3 pre-existing test failures + lazy tomli_w imports

1. tier-1-unit-core::test_audit_script_exits_zero
   - audit_main_thread_imports.py failed with 3 heavy top-level imports
   - Made tomli_w lazy in src/personas.py, src/tool_presets.py, src/workspace_manager.py
   - Made 'from scripts import py_struct_tools' lazy inside src/mcp_client.py:dispatch()
   - Audit now exits 0 (28 files in main-thread import graph, no heavy top-level imports)

2. tier-2-mock-app-headless::test_status_endpoint_authorized
   - /status endpoint goes through _api_status() which returns controller.ai_status (default 'idle'),
     not the literal 'ok' string the test expected
   - Updated test to expect 'idle' (the actual ai_status default for a fresh controller)

3. tier-3-live_gui::test_auto_switch_sim
   - _capture_workspace_profile() in src/gui_2.py referenced 'WorkspaceProfile' as a bare name,
     but the module had only 'from src import workspace_manager' (the module, not the class)
   - Added 'from src.workspace_manager import WorkspaceProfile' to fix the NameError
   - Profile save/load round-trip now works; auto-switch fires Tier 3 bound profile

Additional test fixes (uncovered by full run):
- tests/test_cruft_removal.py: patch 'src.mcp_client.py_struct_tools' no longer works
  (lazy import means the attribute doesn't exist). Patched 'scripts.py_struct_tools.py_remove_def'
  and '.py_move_def' directly at the source module.
- tests/test_command_palette_sim.py: 'from src.command_palette' was deleted in
  module_taxonomy_refactor; updated to 'from src.commands' (which now hosts _close_palette,
  _execute, and Command after the merge).

Production fix:
- src/presets.py:save_preset now raises ValueError when scope='project' but
  project_root is None (fail-fast per error_handling.md, prevents silent
  write to '.').

Type registry regenerated to reflect new line numbers.
This commit is contained in:
ed
2026-06-27 10:17:51 -04:00
parent c1dfe7b29f
commit b3aeaa4376
13 changed files with 42 additions and 26 deletions
+3 -5
View File
@@ -42,8 +42,7 @@ def test_dispatch_py_remove_def_uses_result_helper(mock_resolve_result, tmp_path
c_file = tmp_path / "test.py"
c_file.write_text("def foo(): pass\n")
with patch("src.mcp_client.py_struct_tools") as mock_struct:
mock_struct.py_remove_def.return_value = "removed"
with patch("scripts.py_struct_tools.py_remove_def", return_value="removed") as mock_remove:
# dispatch routes through _resolve_and_check_result now
result = dispatch("py_remove_def", {"path": str(c_file), "name": "foo"})
assert result == "removed", f"expected 'removed', got {result!r}"
@@ -58,8 +57,7 @@ def test_dispatch_py_move_def_uses_result_helper(mock_resolve_result, tmp_path):
dest_file = tmp_path / "dest.py"
dest_file.write_text("# dest\n")
with patch("src.mcp_client.py_struct_tools") as mock_struct:
mock_struct.py_move_def.return_value = "moved"
with patch("scripts.py_struct_tools.py_move_def", return_value="moved") as mock_move:
result = dispatch(
"py_move_def",
{
@@ -229,4 +227,4 @@ def test_phase9_rag_engine_chunk_code_gone():
from src.rag_engine import RAGEngine
assert not hasattr(RAGEngine, "_chunk_code"), (
"RAGEngine._chunk_code STILL EXISTS (should be deleted)"
)
)