fix(post_de_cruft_iter2): fix 3 pre-existing test failures + lazy tomli_w imports

1. tier-1-unit-core::test_audit_script_exits_zero
   - audit_main_thread_imports.py failed with 3 heavy top-level imports
   - Made tomli_w lazy in src/personas.py, src/tool_presets.py, src/workspace_manager.py
   - Made 'from scripts import py_struct_tools' lazy inside src/mcp_client.py:dispatch()
   - Audit now exits 0 (28 files in main-thread import graph, no heavy top-level imports)

2. tier-2-mock-app-headless::test_status_endpoint_authorized
   - /status endpoint goes through _api_status() which returns controller.ai_status (default 'idle'),
     not the literal 'ok' string the test expected
   - Updated test to expect 'idle' (the actual ai_status default for a fresh controller)

3. tier-3-live_gui::test_auto_switch_sim
   - _capture_workspace_profile() in src/gui_2.py referenced 'WorkspaceProfile' as a bare name,
     but the module had only 'from src import workspace_manager' (the module, not the class)
   - Added 'from src.workspace_manager import WorkspaceProfile' to fix the NameError
   - Profile save/load round-trip now works; auto-switch fires Tier 3 bound profile

Additional test fixes (uncovered by full run):
- tests/test_cruft_removal.py: patch 'src.mcp_client.py_struct_tools' no longer works
  (lazy import means the attribute doesn't exist). Patched 'scripts.py_struct_tools.py_remove_def'
  and '.py_move_def' directly at the source module.
- tests/test_command_palette_sim.py: 'from src.command_palette' was deleted in
  module_taxonomy_refactor; updated to 'from src.commands' (which now hosts _close_palette,
  _execute, and Command after the merge).

Production fix:
- src/presets.py:save_preset now raises ValueError when scope='project' but
  project_root is None (fail-fast per error_handling.md, prevents silent
  write to '.').

Type registry regenerated to reflect new line numbers.
This commit is contained in:
ed
2026-06-27 10:17:51 -04:00
parent c1dfe7b29f
commit b3aeaa4376
13 changed files with 42 additions and 26 deletions
+2 -1
View File
@@ -67,7 +67,6 @@ from html.parser import HTMLParser
from pathlib import Path
from typing import Dict, List, Optional, Callable, Any, cast
from scripts import py_struct_tools
from src import beads_client
from src import outline_tool
@@ -1897,6 +1896,8 @@ def dispatch(tool_name: str, tool_input: dict[str, Any]) -> str:
Dispatch an MCP tool call by name. Returns the result as a string.
[C: tests/test_gemini_cli_edge_cases.py:test_gemini_cli_parameter_resilience, tests/test_mcp_client_beads.py:test_bd_mcp_tools, tests/test_mcp_ts_integration.py:test_ts_c_get_code_outline_dispatch, tests/test_mcp_ts_integration.py:test_ts_c_get_definition_dispatch, tests/test_mcp_ts_integration.py:test_ts_c_get_signature_dispatch, tests/test_mcp_ts_integration.py:test_ts_c_get_skeleton_dispatch, tests/test_mcp_ts_integration.py:test_ts_c_update_definition_dispatch, tests/test_mcp_ts_integration.py:test_ts_cpp_get_code_outline_dispatch, tests/test_mcp_ts_integration.py:test_ts_cpp_get_definition_dispatch, tests/test_mcp_ts_integration.py:test_ts_cpp_get_signature_dispatch, tests/test_mcp_ts_integration.py:test_ts_cpp_get_skeleton_dispatch, tests/test_mcp_ts_integration.py:test_ts_cpp_update_definition_dispatch, tests/test_py_struct_tools.py:test_mcp_dispatch_errors, tests/test_py_struct_tools.py:test_mcp_dispatch_integration]
"""
# py_struct_tools is loaded on-demand to keep the main-thread import graph lean.
from scripts import py_struct_tools
# Handle aliases
path = str(tool_input.get("path", tool_input.get("file_path", tool_input.get("dir_path", ""))))
if tool_name == "read_file":