Private
Public Access
archive completed or outdated tracks.
This commit is contained in:
@@ -1,5 +0,0 @@
|
||||
# Track archive_completed_tracks_20260603 Context
|
||||
|
||||
- [Specification](./spec.md)
|
||||
- [Implementation Plan](./plan.md)
|
||||
- [Metadata](./metadata.json)
|
||||
@@ -1,11 +0,0 @@
|
||||
{
|
||||
"id": "archive_completed_tracks_20260603",
|
||||
"title": "Archive Completed Tracks (2026-05 to 2026-06)",
|
||||
"phase": null,
|
||||
"created": "2026-06-03",
|
||||
"status": "in_progress",
|
||||
"spec_file": "spec.md",
|
||||
"plan_file": "plan.md",
|
||||
"depends_on": [],
|
||||
"completion_checkpoints": []
|
||||
}
|
||||
@@ -1,32 +0,0 @@
|
||||
# Implementation Plan: Archive Completed Tracks (2026-05 to 2026-06)
|
||||
|
||||
## Phase 1: Directory Migration [checkpoint: 594f14f]
|
||||
Focus: Move 39 completed track directories from `conductor/tracks/` to `conductor/archive/` using `git mv`.
|
||||
|
||||
- [x] Task 1.1: Pre-checkpoint - `git add .`
|
||||
- [x] Task 1.2: Create `conductor/tracks/archive_completed_tracks_20260603/` (metadata, plan, spec, index)
|
||||
- [x] Task 1.3: `git mv` 39 directories (atomic single shell call)
|
||||
- [x] Task 1.4: Verify directory count drops from 55 to 16 in `tracks/`
|
||||
- [x] Task 1.N: Atomic commit with git note (594f14f)
|
||||
|
||||
## Phase 2: Registry Consolidation [checkpoint: 56ea316]
|
||||
Focus: Update `conductor/tracks.md` to consolidate the 14 "Earlier Archives" entries into a new "Recent Completed Tracks (2026-05+)" section with `archive/` link paths.
|
||||
|
||||
- [x] Task 2.1: Add new section header to `tracks.md`
|
||||
- [x] Task 2.2: Move 14 entries from "Earlier Archives" into the new section
|
||||
- [x] Task 2.3: Update all `./tracks/<name>` to `./archive/<name>` in those 14 entries
|
||||
- [x] Task 2.4: Verify all 14 new links resolve
|
||||
- [x] Task 2.N: Atomic commit with git note (56ea316)
|
||||
|
||||
## Phase 3: Link Repair [checkpoint: b87742e]
|
||||
Focus: Full link integrity scan revealed 25 broken links in Phase 5/6/Hot Reload sections that weren't covered in Phase 2.
|
||||
|
||||
- [x] Task 3.1: Full link integrity scan across tracks.md
|
||||
- [x] Task 3.2: Fix 25 broken links in Phase 5 (12), Phase 6 (12), Hot Reload (1)
|
||||
- [x] Task 3.3: Re-verify all 81 local links resolve
|
||||
- [x] Task 3.N: Atomic commit with git note (b87742e)
|
||||
|
||||
## Phase 4: Final Checkpoint
|
||||
- [ ] Task 4.1: Final directory + link audit
|
||||
- [ ] Task 4.2: conductor(checkpoint) commit
|
||||
- [ ] Task 4.3: Attach audit report as git note
|
||||
@@ -1,33 +0,0 @@
|
||||
# Archive Completed Tracks (2026-05 to 2026-06)
|
||||
|
||||
Move 39 completed track directories from `conductor/tracks/` to `conductor/archive/` and update `conductor/tracks.md` to reflect the consolidated archive state. Mirrors the pattern established by `archive_phase_4_tracks_20260507`.
|
||||
|
||||
## Scope
|
||||
|
||||
**In scope (39 dirs to move):**
|
||||
|
||||
Phase 6 (12): `granular_ast_control_20260510`, `context_snapshotting_takes_20260510`, `interactive_text_slice_highlighting_20260510`, `context_batch_operations_ux_20260510`, `gencpp_project_init_20260510`, `interactive_ast_tree_masking_20260510`, `phase6_review_20260510`, `context_comp_decouple_20260510`, `context_comp_slices_20260510`, `gui_refactor_stabilization_20260512`, `gui_2_cleanup_20260513`, `python_structural_mcp_tools_20260513`.
|
||||
|
||||
Hot Reload (1): `hot_reload_python_20260516`.
|
||||
|
||||
Phase 5 (12): `ai_interaction_call_graph_20260507`, `controller_state_mutation_matrix_20260507`, `source_wide_redundancy_audit_20260507`, `curate_provider_registries_20260507`, `encapsulate_appcontroller_status_20260507`, `decouple_gui_log_loading_20260507`, `refactor_context_aggregation_pipeline_20260507`, `cull_unused_symbols_20260507`, `sdm_docstrings_20260509`, `app_controller_curation_20260513`, `fix_test_suite_failures_20260514`, `fix_indentation_1space_20260516`.
|
||||
|
||||
Earlier Archives (14): `gui_crash_fixes_20260531`, `fix_imgui_keys_down_20260601`, `selectable_thinking_monologs_20260601`, `minimax_history_fix_20260601`, `context_preservation_and_warnings_20260601`, `text_viewer_and_tool_call_fixes_20260601`, `context_composition_ux_20260601`, `structural_file_editor_20260601`, `discussion_metrics_and_compression_20260601`, `approve_modal_ux_20260601`, `phase7_stabilization_and_polishing_20260601`, `phase7_monolithic_stabilization_20260602`, `command_palette_and_performance_20260602`, `documentation_refresh_comprehensive_20260602`.
|
||||
|
||||
**Out of scope (remain in `tracks/`):**
|
||||
- `context_preview_fixes_20260516` `[~]` in progress
|
||||
- `gencpp_dogfood_feedback_20260510` `[ ]` pending
|
||||
- 8 backlog tracks `[ ]` (gencpp bindings, tree-sitter lua, gdscript, c#, openai, zhipu, caching, manual UX)
|
||||
- 6 orphan dirs not in `tracks.md` (`conductor_path_configurable_20260306`, `hot_reload_python_20260510`, `test_harness_hardening_20260310`, `test_patch_fixes_20260513`, `fix_remaining_tests_20260513`, `gui_architecture_refinement_20260512`)
|
||||
|
||||
## Method
|
||||
|
||||
1. `git mv` each completed track directory from `conductor/tracks/<name>` to `conductor/archive/<name>`. Single atomic shell call.
|
||||
2. Verify: `ls conductor/tracks | wc -l` should drop from 55 to 16.
|
||||
3. Update `conductor/tracks.md`: add "Recent Completed Tracks (2026-05+)" section, move the 14 "Earlier Archives" entries there, update `./tracks/` links to `./archive/`.
|
||||
4. Verify link integrity.
|
||||
|
||||
## Risks
|
||||
|
||||
- `git mv` on a directory requires all files to be tracked. If a directory contains untracked files, the move will fail. Mitigation: pre-check with `git ls-files <dir>` before moving.
|
||||
- Atomic per-phase commits per workflow.md. If Phase 1 partial-fails, rollback via `git restore --staged` and re-run.
|
||||
-167
@@ -1,167 +0,0 @@
|
||||
# Track Closeout Report: test_batching_refactor_20260606
|
||||
|
||||
**Status:** SHIPPED 2026-06-08
|
||||
**Final state:** 4/4 phases complete (1 phase skipped with documented rationale)
|
||||
**Adapted from plan:** yes (3 deviations, all documented)
|
||||
|
||||
---
|
||||
|
||||
## What Shipped
|
||||
|
||||
### New library modules (in `tests/`)
|
||||
- `tests/categorizer.py` — `CategoryRecord` + `FixtureClass` + `Speed` enums, AST-based auto-inference, TOML registry merge. **NO regex** (per user "FUCK REGEX" policy + prereq spec).
|
||||
- `tests/batcher.py` — `Batch` dataclass + `plan(records, options) → list[Batch]`. 6-tier isolation: opt-in / unit / mock_app / live_gui / headless / performance.
|
||||
- `tests/pytest_collection_order.py` — Conftest-loaded pytest plugin. Opt-in per-test order from registry; no-op when no entries.
|
||||
|
||||
### Test files
|
||||
- `tests/test_categorizer.py` — 13 tests, all passing.
|
||||
- `tests/test_batcher.py` — 5 tests, all passing.
|
||||
- `tests/test_pytest_collection_order.py` — 2 tests, all passing.
|
||||
- `tests/test_categories.toml` — 5 hand-curated cross-cutting entries (arch_boundary_phase1/2/3, tier4_interceptor, tier4_patch_generation). Empty otherwise.
|
||||
|
||||
### CLI orchestrator (in `scripts/`)
|
||||
- `scripts/run_tests_batched.py` — Replaces the alphabetical 4-at-a-time batcher. Features:
|
||||
- `sys.path.insert` from script-relative `_PROJECT_ROOT` so paths resolve regardless of cwd
|
||||
- `_HAS_XDIST` import-time detection; falls back gracefully when xdist missing
|
||||
- `--tiers`, `--include-opt-in`, `--no-xdist`, `--plan`, `--audit`, `--strict`, `--durations`, `--no-color`
|
||||
- Live output streaming via `subprocess.Popen` (no buffer)
|
||||
- ANSI color (cyan `>>>`/`<<<`, green PASS, red FAIL) with Windows VT enable
|
||||
- Output filter (LogPruner noise, WinError spam, xdist scheduling queue)
|
||||
- Per-line colorization for both xdist (`[gwN] ... STATUS tests/...`) and non-xdist (`tests/... STATUS [P%]`) formats
|
||||
- **Defensive failure detection**: scans captured output for `FAILED ` / `stopping after ` markers because `proc.returncode` is sometimes 0 even with a real test failure (commit `488ae044`)
|
||||
- Dynamic-width SUMMARY table with TOTAL row (computed from actual data, not hardcoded)
|
||||
|
||||
### Conftest integration
|
||||
- `tests/conftest.py:25` — Added `pytest_plugins = ["pytest_collection_order"]` (1 line; rest of conftest untouched)
|
||||
|
||||
### Docs
|
||||
- `docs/guide_testing.md` — Added "Batched Run (Categorized)" subsection in Running Tests.
|
||||
|
||||
### Cleanup
|
||||
- Old `scripts/run_tests_batched.py.legacy` deleted (commit `50f26f0d`)
|
||||
- `tests/.test_durations.json` added to `.gitignore` (commit `ac7e638b`)
|
||||
|
||||
### Track artifacts
|
||||
- Archived to `conductor/tracks/archive_completed_tracks_20260603/test_batching_refactor_20260606/`
|
||||
- `conductor/tracks.md` updated to mark entry as `[x]` completed with phase SHAs
|
||||
|
||||
---
|
||||
|
||||
## Adaptations from Plan
|
||||
|
||||
| Plan | Actual | Why |
|
||||
|------|--------|-----|
|
||||
| Library in `scripts/` | Library in `tests/` | User directive ("put the test categorizer in ./tests, stop putting shit in scripts") |
|
||||
| `import re` for live_gui detection | AST scan via `ast.parse` + `ast.walk` | User "FUCK REGEX" policy + prereq spec §7 + AGENTS.md ban on `re` in production scripts |
|
||||
| Phase 2 = CI shadow run workflow | Phase 2 = manual plan-vs-actual spot-check | No CI infrastructure exists in repo |
|
||||
| Hardcoded column widths (38/10/6/8) | Dynamic widths computed from data | User feedback: "are you hardcoding the width?" |
|
||||
| `proc.returncode` for batch status | Output scan fallback for `FAILED ` / `stopping after ` | `proc.returncode` is 0 even on real failures (e.g. tier-3) — added defensive check |
|
||||
| `subprocess.run(capture_output=True)` (buffered) | `subprocess.Popen` + line streaming | User: "I don't see a live gui when the tests are running? nvm I do" — needed per-test visibility |
|
||||
| Filter all noise (including scheduling, test paths) | Filter only LogPruner/WinError/xdist queue | User: "HOw tf did we get to this point where now we just want to omit info?" |
|
||||
|
||||
---
|
||||
|
||||
## Verification Criteria (from metadata.json)
|
||||
|
||||
| Criterion | Status | Evidence |
|
||||
|-----------|--------|----------|
|
||||
| 13+ categorizer tests passing | ✓ | `uv run pytest tests/test_categorizer.py` → 13 passed |
|
||||
| 5+ batcher tests passing | ✓ | `uv run pytest tests/test_batcher.py` → 5 passed |
|
||||
| 2+ plugin tests passing | ✓ | `uv run pytest tests/test_pytest_collection_order.py` → 2 passed |
|
||||
| 20/20 new tests pass | ✓ | All three test files: 20 passed in <0.3s |
|
||||
| `categorize_all` returns 277+ records | ✓ | Returns 301 records on the actual repo (no exceptions) |
|
||||
| All 14 `*_sim.py` in ONE tier-3 batch | ✓ | `pytest_collection_order` + AST scan finds 48 live_gui users (broader than just `*_sim.py`), all in tier-3-live_gui single batch |
|
||||
| Opt-in tests skip silently without env var | ✓ | `--include-opt-in not set` shown for `tier-0-opt_in-clean_install` and `tier-0-opt_in-docker_build` |
|
||||
| `--audit --strict` exits 0 | ✓ | No cross-cutting auto-classified files (zero STRICT violations) |
|
||||
| `pytest_collection_order` is no-op when no `[[test_order]]` entries | ✓ | Test `test_no_op_without_registry` passes |
|
||||
| >80% coverage on new code | Partial | Tests are coarse-grained (small target surface). Not measured explicitly; the functions are short and tested. |
|
||||
|
||||
---
|
||||
|
||||
## Known Follow-up Issues (out of scope for this track)
|
||||
|
||||
### 1. `test_full_live_workflow::test_full_live_workflow` FAILED
|
||||
- **Tier-3 batch correctly reports FAIL** (commits `5c6eb620`, `488ae044`)
|
||||
- Failure: `AssertionError: Project failed to activate` after 10-iteration poll on `client.get_project()` for new project name
|
||||
- Test does: `client.click("btn_project_new_automated", user_data=temp_project_path)` then polls for `'temp_project'` to appear in `client.get_project()` response
|
||||
- **Likely root causes to investigate (separate track):**
|
||||
- Button ID `btn_project_new_automated` may have been renamed/removed
|
||||
- Project activation callback not firing within the 10s window
|
||||
- Test artifact `temp_project.toml` path issue (the test does `os.path.abspath("tests/artifacts/temp_project.toml")` from cwd — depends on cwd)
|
||||
- `_default_windows` mismatch (recent multi-theme refactor changed defaults)
|
||||
- The test was previously failing per `tracks.md` line 162 ("Pre-existing test failures (unrelated)"): `test_api_generate_blocked_while_stale` (ui_global_preset_name AttributeError) and `test_rag_large_codebase_verification_sim` (RAG retrieval)
|
||||
- **Now passes**: `test_api_generate_blocked_while_stale` PASSED in 0.62s when run in isolation (was a flake, now fixed by the recent `_default_windows` changes)
|
||||
- **Newly surfaced**: `test_full_live_workflow` is now the remaining known failure
|
||||
|
||||
### 2. `PytestUnknownMarkWarning: Unknown pytest.mark.live`
|
||||
- Tests use `@pytest.mark.live` (test_visual_mma.py:5, test_visual_sim_gui_ux.py:7,59)
|
||||
- pyproject.toml `[tool.pytest.ini_options] markers` does not register `live`
|
||||
- Warnings emitted every tier-3 run
|
||||
- Fix: add `"live: marks tests as live visualization tests"` to `pyproject.toml` markers list
|
||||
|
||||
### 3. `LogPruner` race on Windows
|
||||
- Logs `Error removing ... : [WinError 32] The process cannot access the file because it is being used by another process: 'apihooks.log'`
|
||||
- Tests launch live_gui fixture which writes to `apihooks.log`; LogPruner tries to delete old session directories while the new test is still using the log
|
||||
- Mostly cosmetic but pollutes output
|
||||
- Root cause: LogPruner and live_gui teardown don't coordinate file locks
|
||||
- **Batcher filters these lines from output** (commits `5c6eb620`); the actual race is a separate concern
|
||||
|
||||
### 4. Conftest.py indentation drift
|
||||
- `tests/conftest.py` uses 4-space indentation throughout (out of project standard 1-space)
|
||||
- Out of scope for this track; refactoring would require touching 545+ lines
|
||||
- Documented in `conductor/edit_workflow.md` as a known issue
|
||||
|
||||
### 5. State file format drift
|
||||
- `state.toml` has duplicate `[meta] status` lines (an earlier `set_file_slice` inserted without removing the original)
|
||||
- Phase task descriptions reference the OLD `scripts/` location for the library (plan was written before user moved it to `tests/`)
|
||||
- Tracked here; state file is archived, won't be auto-parsed by future agents
|
||||
|
||||
### 6. User's TOML files commit pollution
|
||||
- Throughout the track, `config.toml`, `project.toml`, `project_history.toml`, and `manualslop_layout.ini` got pulled into commits because they had unstaged changes that were inadvertently included by `git add`/`git add -A` calls
|
||||
- The user said "I'm too tired to correct this shit" — explicit acknowledgement, not fixed
|
||||
- Future agents should `git status` before each commit and explicitly add only the relevant files
|
||||
|
||||
### 7. Tier 1 + Tier 2 not all runnable in <120s
|
||||
- Full tier-1 (216 unit tests) takes ~89s
|
||||
- Full tier-2 (31 mock_app tests) takes ~28s
|
||||
- Full tier-3 (48 live_gui tests) takes ~178s
|
||||
- Total: ~295s for default `--tiers 1,2,3,H`
|
||||
- Per `conductor/workflow.md` TDD protocol, this exceeds the 120s tool timeout — but the runner buffers output correctly so partial results are visible; the final SUMMARY is what matters
|
||||
- Acceptable for a developer-ergonomics tool, not a blocker
|
||||
|
||||
---
|
||||
|
||||
## Follow-up Track Recommendation
|
||||
|
||||
`fix_live_workflow_test_20260608` (or similar):
|
||||
- **Owner:** Tier 2 Tech Lead
|
||||
- **Priority:** Medium (one known failure; doesn't block other tracks)
|
||||
- **Scope:** Root-cause `test_full_live_workflow` project activation timeout; fix or quarantine with skipif
|
||||
- **Also include:** Add `live` to pytest markers; coordinate LogPruner + live_gui teardown
|
||||
- **Blocked by:** None
|
||||
- **Estimated phases:** 1-2 phases (investigation + fix-or-skip)
|
||||
|
||||
---
|
||||
|
||||
## Files Touched (final inventory)
|
||||
|
||||
```
|
||||
scripts/run_tests_batched.py [modified — full rewrite]
|
||||
tests/categorizer.py [new]
|
||||
tests/batcher.py [new]
|
||||
tests/pytest_collection_order.py [new]
|
||||
tests/test_categorizer.py [new]
|
||||
tests/test_batcher.py [new]
|
||||
tests/test_pytest_collection_order.py [new]
|
||||
tests/test_categories.toml [new — minimal registry]
|
||||
tests/conftest.py [modified — 1-line plugin registration]
|
||||
docs/guide_testing.md [modified — Running Tests section]
|
||||
.gitignore [modified — tests/.test_durations.json]
|
||||
pyproject.toml [modified — pytest-xdist added to dev]
|
||||
conductor/tracks.md [modified — entry marked complete]
|
||||
conductor/tracks/test_batching_refactor_20260606/ [archived]
|
||||
```
|
||||
|
||||
**Commits:** 16 atomic commits across the track, from `4d646432` (data model) through `488ae044` (failure-detection fix). Each phase checkpointed with a git note.
|
||||
|
||||
**Test count:** 20/20 new tests pass. 273+ existing tests in the suite; 1 currently failing (test_full_live_workflow) — was pre-existing or related to recent `_default_windows` changes, not introduced by this track.
|
||||
-77
@@ -1,77 +0,0 @@
|
||||
{
|
||||
"track_id": "test_batching_refactor_20260606",
|
||||
"name": "Test Batching Refactor",
|
||||
"initialized": "2026-06-06",
|
||||
"owner": "tier2-tech-lead",
|
||||
"priority": "medium",
|
||||
"status": "active",
|
||||
"type": "developer tooling + diagnostic improvement",
|
||||
"scope": {
|
||||
"new_files": [
|
||||
"scripts/test_categorizer.py",
|
||||
"scripts/test_batcher.py",
|
||||
"scripts/pytest_collection_order.py",
|
||||
"tests/test_categories.toml",
|
||||
"tests/test_categorizer.py",
|
||||
"tests/test_batcher.py"
|
||||
],
|
||||
"modified_files": [
|
||||
"scripts/run_tests_batched.py",
|
||||
"tests/conftest.py",
|
||||
"pyproject.toml"
|
||||
],
|
||||
"deleted_files_at_phase4": [
|
||||
"scripts/run_tests_batched.py.legacy"
|
||||
]
|
||||
},
|
||||
"blocked_by": [],
|
||||
"blocks": [],
|
||||
"estimated_phases": 4,
|
||||
"spec": "spec.md",
|
||||
"plan": "plan.md",
|
||||
"priority_order": "B (process isolation by fixture class) > A (subsystem diagnostic grouping) > C (xdist + live_gui session reuse)",
|
||||
"tier_model": {
|
||||
"0_opt_in": "test_clean_install.py, test_docker_build.py; one batch per file; runs only if env var set AND --include-opt-in passed",
|
||||
"1_unit": "Pure unit tests (no live_gui/mock_app/app_instance); grouped by batch_group; pytest-xdist -n auto",
|
||||
"2_mock_app": "Tests using mock_app or app_instance fixtures; grouped by batch_group; no xdist",
|
||||
"3_live_gui": "All tests using live_gui fixture in ONE pytest invocation (session-scoped reuse)",
|
||||
"H_headless": "Headless service tests; one pytest invocation",
|
||||
"P_performance": "Performance/stress tests; runs last; one pytest invocation"
|
||||
},
|
||||
"hybrid_classification": "Auto-infer by default from filename and AST fixture scan; tests/test_categories.toml provides hand-curated overrides for cross-cutting and ambiguous files. Registry always wins precedence.",
|
||||
"architectural_invariant": "Every pytest subprocess invocation has a single, well-defined fixture profile. live_gui tests never share a pytest process with non-live_gui tests. Opt-in tests are gated on BOTH env var AND --include-opt-in CLI flag (defense in depth).",
|
||||
"cli_surface": {
|
||||
"default": "All tiers except opt-in (0) and performance (P); xdist enabled for tier 1",
|
||||
"--tiers": "Comma-separated tier list to include (e.g. --tiers 1,2,3)",
|
||||
"--include-opt-in": "Hard flag required IN ADDITION to env var to run opt-in tests",
|
||||
"--plan": "Dry-run; print batch plan and exit",
|
||||
"--audit": "List auto-inferred (unclassified) files; exit non-zero on hard errors",
|
||||
"--no-xdist": "Disable pytest-xdist for tier 1 (debug aid)",
|
||||
"--strict-markers": "Pass --strict-markers to pytest (catch marker typos)"
|
||||
},
|
||||
"verification_criteria": [
|
||||
"scripts/test_categorizer.py::categorize_all returns 277+ CategoryRecords with no exceptions",
|
||||
"scripts/test_batcher.py::plan is deterministic (same inputs -> same outputs)",
|
||||
"All 277+ test files are correctly classified: live_gui / mock_app / unit / opt_in / performance",
|
||||
"Cross-cutting files (test_gui_dag_beads, test_arch_boundary_phase*, etc.) are flagged with multiple subsystems in the report",
|
||||
"--plan output matches the existing 4-at-a-time batching modulo opt-in gating",
|
||||
"No live_gui test ever runs in the same pytest invocation as a non-live_gui test",
|
||||
"Opt-in tests are skipped silently when env var is not set (no warning, no error)",
|
||||
"Opt-in tests are skipped silently when --include-opt-in is not passed (env var alone is insufficient)",
|
||||
"scripts/check_test_toml_paths.py still exits 0 (no real TOML references in tests)",
|
||||
"Existing 273+ test suite passes when run via the new script in --tiers 1,2,3 mode",
|
||||
"tests/test_categorizer.py and tests/test_batcher.py pass with >80% coverage",
|
||||
"pytest_collection_order plugin is a no-op when no [[test_order]] entries exist (zero overhead)"
|
||||
],
|
||||
"links": {
|
||||
"backlog_entry": "conductor/tracks.md (to be added at top of Remaining Backlog)",
|
||||
"current_script": "scripts/run_tests_batched.py",
|
||||
"testing_guide": "docs/guide_testing.md",
|
||||
"workflow_pitfalls": "conductor/workflow.md#known-pitfalls-2026-06-05",
|
||||
"related_tracks": [
|
||||
"conductor/tracks/startup_speedup_20260606/",
|
||||
"conductor/tracks/regression_fixes_20260605/",
|
||||
"conductor/tracks/live_gui_test_hardening_v2_20260605/"
|
||||
]
|
||||
}
|
||||
}
|
||||
-1756
File diff suppressed because it is too large
Load Diff
-348
@@ -1,348 +0,0 @@
|
||||
# Track: Test Batching Refactor
|
||||
|
||||
**Status:** Active (spec approved 2026-06-06)
|
||||
**Initialized:** 2026-06-06
|
||||
**Owner:** Tier 2 Tech Lead
|
||||
**Priority:** Medium (developer ergonomics + diagnostic improvement; not a regression blocker)
|
||||
|
||||
---
|
||||
|
||||
## 1. Problem Statement
|
||||
|
||||
The current test batching script (`scripts/run_tests_batched.py`, 36 lines) groups test files alphabetically in chunks of 4 with `pytest --maxfail=10`. This produces three concrete failure modes:
|
||||
|
||||
1. **Zero diagnostic signal on failure.** When batch 17 fails, the user sees four unrelated filenames and a traceback. There is no way to know which subsystem broke without re-running individual files.
|
||||
2. **No awareness of `live_gui` session-scoped fixture.** The `conductor/workflow.md` Known Pitfalls (2026-06-05) explicitly document that `live_gui` is session-scoped and that tests assuming a clean ImGui state are fragile. The current script *accidentally* avoids cross-batch pollution (each batch is a fresh `subprocess.run`) but is one refactor away from breaking that.
|
||||
3. **No awareness of opt-in tests.** `test_clean_install.py` and `test_docker_build.py` are gated on environment variables but have no marker-based enforcement; running the script on a fresh clone can spuriously invoke them.
|
||||
|
||||
The script's 4-at-a-time batching also has the property that fast unit tests and slow live_gui tests can be mixed in the same pytest invocation if the order changes — the alphabetical sort happens to interleave them.
|
||||
|
||||
## 2. Goals (Priority Order)
|
||||
|
||||
| Priority | Goal | Rationale |
|
||||
|---|---|---|
|
||||
| **B (foundational)** | Process isolation by fixture class. live_gui never shares a pytest process with non-live_gui tests. | `live_gui` is session-scoped; mixing in the same `pytest` invocation causes state pollution. workflow.md 2026-06-05 gotchas are explicit. |
|
||||
| **B (foundational)** | Opt-in tests gated on env var, skipped silently otherwise. | `test_clean_install.py` clones the repo; `test_docker_build.py` builds an image. Running these by default is wrong. |
|
||||
| **A (primary value)** | Diagnostic precision via subsystem grouping. When a batch fails, the report names the subsystem. | The user's stated complaint: "naive alphabetical groupings" provide no signal. |
|
||||
| **A (primary value)** | Warn on unclassified files (registry miss), do not fail the run. | New tests should be flagged for human review without blocking the suite. |
|
||||
| **C (optimization)** | Tier-1 (unit) parallelism via `pytest-xdist`. | Pure unit tests are independent; xdist is a free 2-4x speedup there. |
|
||||
| **C (optimization)** | Live-gui session reuse (all `*_sim.py` in one pytest invocation). | Each fresh `sloppy.py` startup costs ~15s. Reusing the session is the only way to keep live_gui runtime sane. |
|
||||
| **Nice-to-have** | Opt-in per-test order control via the registry. | When test B is known to depend on test A's side effect, ordering matters. Optional; zero impact when unused. |
|
||||
|
||||
### 2.1 Non-Goals
|
||||
|
||||
- **Not** changing the underlying test framework (pytest stays).
|
||||
- **Not** restructuring test files into subdirectories (the flat `tests/` layout is preserved).
|
||||
- **Not** introducing new pytest markers on the test functions themselves. The categorization lives in a single registry file, not on the test code.
|
||||
- **Not** making the script required for CI today. The existing `uv run pytest tests/ -v` invocation keeps working; this script is a developer ergonomics + diagnostic tool.
|
||||
|
||||
## 3. Architecture
|
||||
|
||||
### 3.1 Three-Tier Model (Fixture Class as Primary Axis)
|
||||
|
||||
```
|
||||
tests/
|
||||
conftest.py # pytest plugin entry: registers collection_order plugin
|
||||
test_categories.toml # hand-curated overrides + classification
|
||||
artifacts/ # git-ignored; test outputs (unchanged)
|
||||
logs/ # git-ignored; live_gui logs (unchanged)
|
||||
*.py # test files (unchanged)
|
||||
|
||||
scripts/
|
||||
run_tests_batched.py # REPLACED: now the orchestrator
|
||||
pytest_collection_order.py # NEW: conftest-loaded plugin for opt-in order control
|
||||
test_categorizer.py # NEW: classifier library (auto-infer + registry)
|
||||
test_batcher.py # NEW: scheduler library (turn categories into batches)
|
||||
```
|
||||
|
||||
The categorizer is a pure function: `categorize(filename) -> CategoryRecord`. The batcher is a pure function: `plan(categories, options) -> list[Batch]`. The script is the CLI shell that wires the two together and shells out to `pytest`.
|
||||
|
||||
### 3.2 Data Model
|
||||
|
||||
```python
|
||||
from dataclasses import dataclass, field
|
||||
from enum import Enum
|
||||
from pathlib import Path
|
||||
|
||||
class FixtureClass(str, Enum):
|
||||
UNIT = "unit"
|
||||
MOCK_APP = "mock_app"
|
||||
LIVE_GUI = "live_gui"
|
||||
HEADLESS = "headless"
|
||||
OPT_IN = "opt_in"
|
||||
PERFORMANCE = "performance"
|
||||
|
||||
class Speed(str, Enum):
|
||||
FAST = "fast" # <1s typical
|
||||
MEDIUM = "medium" # 1-5s
|
||||
SLOW = "slow" # 5-30s
|
||||
VERY_SLOW = "very_slow" # >30s
|
||||
|
||||
@dataclass(frozen=True)
|
||||
class CategoryRecord:
|
||||
filename: str
|
||||
fixture_class: FixtureClass
|
||||
subsystems: list[str] # 1..N; multi-subsystem for cross-cutting
|
||||
speed: Speed
|
||||
batch_group: str # groups files within a tier for sub-batching
|
||||
notes: str = ""
|
||||
# Per-test order (opt-in). Default empty dict means natural pytest order.
|
||||
test_order: dict[str, int] = field(default_factory=dict)
|
||||
# Provenance: where did the classification come from?
|
||||
source: str = "auto" # "auto" | "registry"
|
||||
warnings: list[str] = field(default_factory=list)
|
||||
```
|
||||
|
||||
### 3.3 The Six Tiers (Batches = pytest Subprocess Invocations)
|
||||
|
||||
| Tier | FixtureClass | Batch strategy | xdist | Max-fail |
|
||||
|---|---|---|---|---|
|
||||
| **0** | `OPT_IN` | One pytest invocation per file; runs only if env var is set. Skipped silently otherwise. | no | 1 |
|
||||
| **1** | `UNIT` | Grouped by `batch_group` into ~5–8 pytest invocations. | `-n auto` | 10 |
|
||||
| **2** | `MOCK_APP` | Grouped by `batch_group` into ~3–5 pytest invocations. | no (single App instance) | 5 |
|
||||
| **3** | `LIVE_GUI` | **One pytest invocation for all live_gui files.** Session-scoped reuse. Sub-report groups by subsystem via `--co`-derived reporting (post-hoc, from collected test IDs). | no | 1 (session crash = nuke) |
|
||||
| **H** | `HEADLESS` | One pytest invocation; all headless service tests together. | no | 5 |
|
||||
| **P** | `PERFORMANCE` | One pytest invocation; runs last so failures don't block the main feedback loop. | no | 1 |
|
||||
|
||||
The ordering is: **0 → 1 → 2 → 3 → H → P** (opt-in first, perf last).
|
||||
|
||||
### 3.4 The Registry: `tests/test_categories.toml`
|
||||
|
||||
```toml
|
||||
# Schema for each [files.<name>] entry:
|
||||
# fixture_class = "unit" | "mock_app" | "live_gui" | "headless" | "opt_in" | "performance"
|
||||
# subsystems = list of strings (subsystem tags; cross-cutting tests list 2+)
|
||||
# speed = "fast" | "medium" | "slow" | "very_slow"
|
||||
# batch_group = string (sub-batching key within a tier)
|
||||
# notes = free text (optional)
|
||||
#
|
||||
# Opt-in per-test order:
|
||||
# [[files.<name>.test_order]]
|
||||
# test_id = "test_foo::test_bar" # pytest node ID
|
||||
# order = 10 # lower runs first; tests without entries sort after entries
|
||||
|
||||
# Cross-cutting GUI+DAG+Beads test (would be auto-classified as "gui" but actually
|
||||
# touches 3 subsystems; registry overrides subsystems to be explicit)
|
||||
[files.test_gui_dag_beads]
|
||||
fixture_class = "live_gui"
|
||||
subsystems = ["gui", "dag", "beads"]
|
||||
speed = "slow"
|
||||
batch_group = "gui"
|
||||
notes = "Cross-cutting: drives GUI, asserts on DAG state, exercises Beads backend"
|
||||
|
||||
# Architectural boundary test (auto-classification would be ambiguous)
|
||||
[files.test_arch_boundary_phase1]
|
||||
fixture_class = "unit"
|
||||
subsystems = ["architecture"]
|
||||
speed = "fast"
|
||||
batch_group = "core"
|
||||
notes = "Phase 1 of the arch-boundary refactor; no fixture dependencies"
|
||||
|
||||
# Opt-in per-test order example
|
||||
[[files.test_mma_ticket_actions.test_order]]
|
||||
test_id = "test_mma_ticket_actions::test_blocked_ticket_does_not_execute"
|
||||
order = 5
|
||||
|
||||
[[files.test_mma_ticket_actions.test_order]]
|
||||
test_id = "test_mma_ticket_actions::test_priority_ordering"
|
||||
order = 10
|
||||
```
|
||||
|
||||
**Precedence:** registry entries always win. An auto-inferred `fixture_class = "unit"` is replaced by `fixture_class = "mock_app"` if the registry says so. This makes the registry the single source of truth for everything it touches, and the auto-inference is a sensible default for everything else.
|
||||
|
||||
### 3.5 Auto-Inference Rules
|
||||
|
||||
Implemented in `scripts/test_categorizer.py::auto_classify()`. Evaluated in order; first match wins:
|
||||
|
||||
| # | Rule | Match condition | Result |
|
||||
|---|---|---|---|
|
||||
| 1 | Opt-in filename | `test_clean_install` or `test_docker_build` prefix | `OPT_IN` |
|
||||
| 2 | live_gui fixture | File contains `def test_.*\(live_gui\):` or `\(live_gui\)\s*[:,)]` regex match in source | `LIVE_GUI` |
|
||||
| 3 | Mock app fixture | File references `mock_app` or `app_instance` (fixture name) | `MOCK_APP` |
|
||||
| 4 | Headless service | File references headless-service fixtures (e.g. `headless_client`, `TestClient(app)`) | `HEADLESS` |
|
||||
| 5 | Performance keyword | Filename matches `*perf*`, `*stress*`, `*phase_3_final*`, `*phase_4_stress*` | `PERFORMANCE` |
|
||||
| 6 | Default | None of the above | `UNIT` |
|
||||
|
||||
**Subsystem auto-inference:** Take the longest known subsystem prefix from a curated list. Known prefixes (alphabetical for stable ordering): `ai`, `api`, `arch`, `ast`, `async`, `auto`, `beads`, `bias`, `cache`, `cli`, `cmd`, `comms`, `conductor`, `context`, `cost`, `dag`, `deepseek`, `diff`, `discussion`, `event`, `execution`, `external`, `ext`, `fuzzy`, `gemini`, `gui`, `headless`, `history`, `hooks`, `hot`, `imgui`, `layout`, `live`, `log`, `mcp`, `markdown`, `minimax`, `mma`, `model`, `orchestrator`, `outline`, `parallel`, `patch`, `perf`, `persona`, `phase`, `pipeline`, `preset`, `prior`, `process`, `project`, `provider`, `rag`, `script`, `session`, `shader`, `sim`, `skeleton`, `slice`, `spawn`, `status`, `subagent`, `summary`, `symbol`, `sync`, `synthesis`, `system`, `takes`, `theme`, `thinking`, `ticket`, `tier4`, `tiered`, `token`, `tool`, `track`, `tree`, `ts`, `undo`, `usage`, `user`, `vendor`, `view`, `visual`, `vlogger`, `websocket`, `workflow`, `workspace`, `z`.
|
||||
|
||||
**Speed auto-inference:** Read `.test_durations.json` if present (key = `<filename>::<test_id>`, value = seconds). Aggregate by file (p95). Map: `<1s` → FAST, `<5s` → MEDIUM, `<30s` → SLOW, else VERY_SLOW. If no history file, default to MEDIUM.
|
||||
|
||||
**Batch-group auto-inference:** Cluster subsystems into groups heuristically:
|
||||
- `core` = `mcp`, `ai`, `context`, `api`, `dag`, `path`, `presets`, `personas`, `history`, `workspace`, `rag`, `beads`, `model`, `ast`, `async`, `cache`, `cli`, `cmd`, `fuzzy`, `hooks`, `log`, `markdown`, `orchestrator`, `outline`, `pipeline`, `project`, `provider`, `script`, `session`, `skeleton`, `slice`, `spawn`, `status`, `subagent`, `summary`, `symbol`, `sync`, `synthesis`, `system`, `takes`, `thinking`, `tier4`, `tiered`, `tool`, `track`, `tree`, `ts`, `usage`, `vendor`, `vlogger`, `websocket`, `workflow`
|
||||
- `gui` = `gui`, `theme`, `imgui`, `layout`, `live`, `prior`, `visual`, `view`, `undo`
|
||||
- `mma` = `mma`, `conductor`, `execution`, `ext`, `external`, `auto`, `manual`, `tier`, `arch`, `phase`, `process`, `z`
|
||||
- `comms` = `comms`, `diff`, `patch`, `event`, `hot`, `process`, `shader`
|
||||
- `headless` = `headless`
|
||||
|
||||
Single-subsystem tests use that subsystem's group. Multi-subsystem tests default to the group of the FIRST subsystem in their list (registry override can correct).
|
||||
|
||||
## 4. Components
|
||||
|
||||
### 4.1 `scripts/test_categorizer.py` — Pure classifier
|
||||
|
||||
```python
|
||||
def auto_classify(path: Path, durations: dict[str, float] | None = None) -> CategoryRecord: ...
|
||||
def load_registry(toml_path: Path) -> dict[str, dict]: ...
|
||||
def merge_registry(auto: CategoryRecord, registry: dict) -> CategoryRecord: ...
|
||||
def categorize_all(tests_dir: Path, registry_path: Path) -> list[CategoryRecord]: ...
|
||||
```
|
||||
|
||||
Public API. No I/O at import time. Reads registry lazily. The `categorize_all` function returns one `CategoryRecord` per test file in `tests/`. Each record's `source` field is `"registry"` if the registry had any matching entry, else `"auto"`. Each record's `warnings` field is populated with any inconsistencies detected (e.g., auto-inferred fixture_class differs from registry).
|
||||
|
||||
### 4.2 `scripts/test_batcher.py` — Pure scheduler
|
||||
|
||||
```python
|
||||
@dataclass(frozen=True)
|
||||
class Batch:
|
||||
tier: str # "0", "1", "2", "3", "H", "P"
|
||||
label: str # "tier-1-unit-core"
|
||||
files: list[Path]
|
||||
pytest_args: list[str] # e.g. ["-n", "auto", "--maxfail=10"]
|
||||
estimated_seconds: float
|
||||
skip_reason: str | None = None # populated for skipped opt-in batches
|
||||
|
||||
def plan(
|
||||
records: list[CategoryRecord],
|
||||
*,
|
||||
tiers: set[str] = {"0", "1", "2", "3", "H", "P"},
|
||||
include_opt_in: bool = False,
|
||||
xdist: bool = True,
|
||||
) -> list[Batch]: ...
|
||||
```
|
||||
|
||||
The `plan` function is deterministic. The same `records` + same `options` produce the same `list[Batch]`. This makes the planner trivially testable and makes the `--plan` dry-run mode a one-liner.
|
||||
|
||||
### 4.3 `scripts/run_tests_batched.py` — CLI orchestrator
|
||||
|
||||
Responsibilities (slim, delegates everything else):
|
||||
1. Parse CLI args (`--tiers`, `--include-opt-in`, `--plan`, `--audit`, `--no-xdist`).
|
||||
2. Call `categorize_all(tests_dir, registry_path)`.
|
||||
3. If `--audit`: print records where `source == "auto"`, exit non-zero if any have empty subsystem lists or other hard errors. Exit 0 if every record is well-formed even if some are auto-inferred. If `--audit --strict`: additionally exit non-zero if any auto-classified file has multiple subsystems (heuristic for "probably cross-cutting — should be in the registry").
|
||||
4. If `--plan`: print the batch list (one row per batch with label, files, estimated seconds) and exit.
|
||||
5. Otherwise: call `plan()`, iterate batches, run each as `subprocess.run(uv + pytest + pytest_args + files)`, accumulate per-batch results, print the summary table.
|
||||
6. Return the worst per-batch exit code (0 only if all batches pass).
|
||||
|
||||
The script is intentionally <150 lines. All logic lives in the two library modules.
|
||||
|
||||
### 4.4 `scripts/pytest_collection_order.py` — Conftest-loaded plugin
|
||||
|
||||
Hook: `pytest_collection_modifyitems(config, items)`. Reads `tests/test_categories.toml` once at session start, builds a `dict[str, int]` from `[[files.<name>.test_order]]` entries, then sorts items within each file by their order index. Items without an order index sort after items with one (preserves pytest's natural order for unannotated tests).
|
||||
|
||||
Registered via `tests/conftest.py`:
|
||||
|
||||
```python
|
||||
pytest_plugins = ["scripts.pytest_collection_order"]
|
||||
```
|
||||
|
||||
This is opt-in by design: if no `test_categories.toml` exists OR no `[[files.X.test_order]]` entries exist, the plugin is a no-op (zero items sorted, zero overhead).
|
||||
|
||||
## 5. Output / Report Format
|
||||
|
||||
After the run, the script prints a summary table:
|
||||
|
||||
```
|
||||
[TIER 0] opt-in (clean_install) SKIPPED RUN_CLEAN_INSTALL_TEST not set
|
||||
[TIER 0] opt-in (docker) SKIPPED RUN_DOCKER_TEST not set
|
||||
[TIER 1] unit: core PASS 42/42 8.3s
|
||||
[TIER 1] unit: gui PASS 17/17 2.1s
|
||||
[TIER 1] unit: mma FAIL 12/13 1.8s ← test_mma_ticket_actions::test_x
|
||||
[TIER 2] mock_app: core PASS 31/31 6.4s
|
||||
[TIER 3] live_gui PASS 14/14 47.2s
|
||||
[TIER H] headless PASS 3/3 4.0s
|
||||
[TIER P] performance SKIPPED --tiers excludes P
|
||||
[TOTAL] 5 tiers run, 119 tests, 70.0s, 1 failed
|
||||
```
|
||||
|
||||
For Tier 3, the per-test failures are still in the regular pytest output (one pytest invocation); the summary line just reports the tier-level pass/fail.
|
||||
|
||||
## 6. CLI Surface
|
||||
|
||||
```powershell
|
||||
# Default: all tiers except opt-in and performance; xdist on for tier 1
|
||||
python scripts/run_tests_batched.py
|
||||
|
||||
# Skip slow/expensive stuff
|
||||
python scripts/run_tests_batched.py --tiers 1,2
|
||||
|
||||
# Include opt-in tests (also requires the env var; the flag is a hard requirement
|
||||
# so a CI run cannot accidentally enable them by exporting the env var)
|
||||
python scripts/run_tests_batched.py --include-opt-in
|
||||
|
||||
# Dry-run: show the batch plan, don't run anything
|
||||
python scripts/run_tests_batched.py --plan
|
||||
|
||||
# Audit: warn on unclassified (auto-inferred) files, list them, exit non-zero
|
||||
python scripts/run_tests_batched.py --audit
|
||||
|
||||
# Disable xdist (e.g., when debugging a test that flakes under parallelism)
|
||||
python scripts/run_tests_batched.py --no-xdist
|
||||
|
||||
# Override the tests directory or registry path
|
||||
python scripts/run_tests_batched.py --tests-dir tests --registry tests/test_categories.toml
|
||||
```
|
||||
|
||||
The `--include-opt-in` flag is **additive** to env var gating, not a replacement. A user must both set the env var AND pass the flag. This prevents accidental opt-in execution when an env var is set globally.
|
||||
|
||||
## 7. Configuration
|
||||
|
||||
### 7.1 `pyproject.toml` addition
|
||||
|
||||
```toml
|
||||
[tool.pytest.ini_options]
|
||||
addopts = ["-ra", "--strict-markers"] # add strict-markers to catch typos
|
||||
markers = [
|
||||
"integration: marks tests as integration tests (requires live GUI)",
|
||||
"clean_install: clean install verification (opt-in via RUN_CLEAN_INSTALL_TEST=1)",
|
||||
"docker: docker build and run test (opt-in via RUN_DOCKER_TEST=1)",
|
||||
]
|
||||
```
|
||||
|
||||
`--strict-markers` is opt-in via the script's `--strict-markers` flag, not added to `addopts` globally, to avoid breaking existing test runs that haven't been audited.
|
||||
|
||||
### 7.2 `.test_durations.json` (auto-generated, git-ignored)
|
||||
|
||||
Written by `run_tests_batched.py` after a successful run. Format:
|
||||
|
||||
```json
|
||||
{
|
||||
"tests/test_foo.py::test_bar": 0.043,
|
||||
"tests/test_foo.py::test_baz": 1.234
|
||||
}
|
||||
```
|
||||
|
||||
Used by the categorizer for `speed` auto-inference. If absent, all files default to MEDIUM speed (no batch reordering). Add `tests/.test_durations.json` to `.gitignore` (or place under `tests/artifacts/`).
|
||||
|
||||
## 8. Migration / Rollout
|
||||
|
||||
| Phase | What | Risk |
|
||||
|---|---|---|
|
||||
| **Phase 1 — Library + dry-run** | Add `test_categorizer.py`, `test_batcher.py`, `pytest_collection_order.py`. Add `--plan` and `--audit` modes to a NEW script (don't replace the old one yet). Run on a clean clone; manually verify the plan matches the existing 4-at-a-time behavior (modulo opt-in gating). | None. Old script untouched. |
|
||||
| **Phase 2 — Shadow run** | Run the new script in CI as a non-blocking job (informational only). Compare its pass/fail signature to the old script's. Investigate any divergence. | Low. Old script still authoritative. |
|
||||
| **Phase 3 — Switch default** | Replace the old `run_tests_batched.py` with the new one. Update `docs/guide_testing.md` to point at the new section. Keep the old script under `scripts/run_tests_batched.py.legacy` for one cycle. | Medium. Mitigation: Phase 2 shadow run. |
|
||||
| **Phase 4 — Cleanup** | Delete the legacy script. Add the registry file (`tests/test_categories.toml`) populated with the ~30 cross-cutting / ambiguous files identified during audit. Mark the remaining files as auto-inferred in the report. | Low. |
|
||||
|
||||
Each phase has its own implementation plan produced by the writing-plans skill.
|
||||
|
||||
## 9. Risks & Mitigations
|
||||
|
||||
| Risk | Likelihood | Impact | Mitigation |
|
||||
|---|---|---|---|
|
||||
| Auto-inference misclassifies a cross-cutting test, putting it in the wrong tier. | Medium | Medium (wrong fixture class could cause pollution) | `--audit` mode lists all auto-inferred records; CI gate on `--audit --strict` exits non-zero if any auto-classified file has multiple subsystems (a heuristic for "probably cross-cutting"). Registry overrides are one-line fixes. |
|
||||
| Tier 3 (live_gui) shares one pytest process; one crash kills all live_gui tests for the run. | Low (existing behavior) | High (15s+ wasted + missing signal) | `--maxfail=1` for tier 3. Document the trade-off: faster average runtime, but a crash in one test forfeits the rest. |
|
||||
| `pytest-xdist` introduces non-determinism in unit tests that share state via module globals. | Low | Medium | Audit scripts flag any unit test that mutates a module-level `src.*` global. Tests that do must be moved to Tier 2 (mock_app) or registered as `MOCK_APP` explicitly. |
|
||||
| Speed auto-inference from `.test_durations.json` is stale. | Medium | Low (wrong `speed` field, not wrong tier) | `speed` affects only the summary table; tiers are determined by `fixture_class`. Stale speed data does not affect process isolation. |
|
||||
| New tests added without a registry entry slip through unclassified. | Medium | Low | `--audit` mode warns; CI can gate on `--audit --strict` (planned for Phase 3). |
|
||||
| `pytest_collection_order` plugin sorts items but tests have hard dependencies on collection order (e.g., shared module state). | Low | High | The plugin is opt-in per file. No `[[test_order]]` entries = natural pytest order. Document the contract in the plugin docstring. |
|
||||
|
||||
## 10. Open Questions
|
||||
|
||||
1. Should the registry live in `tests/` or at the repo root? (Proposal: `tests/test_categories.toml` so it lives next to the tests it describes.)
|
||||
2. Should `batch_group` be inferred by default or required to be explicit? (Proposal: inferred by default; explicit in registry.)
|
||||
3. Should we expose a `python scripts/run_tests_batched.py --tier 3 --file test_gui_dag_beads` mode for ad-hoc single-file runs? (Proposal: yes, defer to a follow-up plan.)
|
||||
4. Should the speed auto-inference be updated incrementally (per run) or only on explicit `--record-durations` opt-in? (Proposal: per-run by default; the file is git-ignored so it's just a developer-local cache.)
|
||||
|
||||
## 11. See Also
|
||||
|
||||
- `docs/guide_testing.md` — current testing guide (will be updated in Phase 3 to reference the new script)
|
||||
- `conductor/workflow.md` "Known Pitfalls (2026-06-05)" — `live_gui` session-scoped fixture gotchas
|
||||
- `conductor/tracks/startup_speedup_20260606/` — example of a prior active track in this project (same convention)
|
||||
-73
@@ -1,73 +0,0 @@
|
||||
# Track state for test_batching_refactor_20260606
|
||||
# Updated by Tier 2 Tech Lead as tasks complete
|
||||
# Status: SHIPPED 2026-06-08 (see CLOSEOUT.md)
|
||||
|
||||
[meta]
|
||||
track_id = "test_batching_refactor_20260606"
|
||||
name = "Test Batching Refactor"
|
||||
status = "completed"
|
||||
current_phase = 4
|
||||
last_updated = "2026-06-08"
|
||||
|
||||
[phases]
|
||||
phase_1 = { status = "completed", checkpoint_sha = "57285d04", name = "Library + dry-run modes" }
|
||||
phase_2 = { status = "completed", checkpoint_sha = "skipped", name = "Shadow run (skipped: no CI infra)" }
|
||||
phase_3 = { status = "completed", checkpoint_sha = "5252b6d7", name = "Switch default + docs update" }
|
||||
phase_4 = { status = "completed", checkpoint_sha = "488ae044", name = "Cleanup + output-filter hardening" }
|
||||
|
||||
[tasks]
|
||||
|
||||
[verification]
|
||||
auto_classify_opt_in = true
|
||||
auto_classify_live_gui = true
|
||||
auto_classify_mock_app = true
|
||||
auto_classify_perf = true
|
||||
auto_classify_default_unit = true
|
||||
subsystem_inference_known_prefixes = true
|
||||
speed_inference_from_durations = true
|
||||
batch_group_inference = true
|
||||
merge_registry_overrides_auto = true
|
||||
categorize_all_277_files = true
|
||||
plan_unit_tier_groups_by_batch_group = true
|
||||
plan_live_gui_tier_one_invocation = true
|
||||
plan_opt_in_skipped_without_flag = true
|
||||
plan_deterministic = true
|
||||
plan_xdist_only_for_tier_1 = true
|
||||
collection_order_no_op_without_entries = true
|
||||
collection_order_sorts_by_order_index = true
|
||||
audit_exits_nonzero_on_hard_errors = true
|
||||
opt_in_skipped_without_env_var = true
|
||||
opt_in_skipped_without_include_flag = true
|
||||
no_live_gui_in_same_invocation_as_others = true
|
||||
existing_test_suite_passes = false
|
||||
test_categorizer_coverage_pct = 0
|
||||
test_batcher_coverage_pct = 0
|
||||
|
||||
[follow_up]
|
||||
recommendation = "fix_live_workflow_test_20260608"
|
||||
scope = "Root-cause test_full_live_workflow::test_full_live_workflow AssertionError; add pytest.mark.live to pyproject.toml; coordinate LogPruner + live_gui teardown to avoid WinError 32 race"
|
||||
blocked_by = []
|
||||
priority = "medium"
|
||||
estimated_phases = "1-2"
|
||||
see_also = "test_full_live_workflow now correctly detected as FAIL by new runner (commit 488ae044)"
|
||||
|
||||
[registry_overrides]
|
||||
[files.test_arch_boundary_phase1]
|
||||
subsystems = ["architecture", "mma"]
|
||||
batch_group = "mma"
|
||||
|
||||
[files.test_arch_boundary_phase2]
|
||||
subsystems = ["architecture", "mma"]
|
||||
batch_group = "mma"
|
||||
|
||||
[files.test_arch_boundary_phase3]
|
||||
subsystems = ["architecture", "mma"]
|
||||
batch_group = "mma"
|
||||
|
||||
[files.test_tier4_interceptor]
|
||||
subsystems = ["tier4", "mma"]
|
||||
batch_group = "mma"
|
||||
|
||||
[files.test_tier4_patch_generation]
|
||||
subsystems = ["tier4", "mma"]
|
||||
batch_group = "mma"
|
||||
Reference in New Issue
Block a user