test: Fix incorrect assertions in conductor tests
This commit is contained in:
@@ -61,13 +61,13 @@ class TestTopologicalSort(unittest.TestCase):
|
|||||||
self.assertEqual(conductor_tech_lead.topological_sort([]), [])
|
self.assertEqual(conductor_tech_lead.topological_sort([]), [])
|
||||||
|
|
||||||
def test_topological_sort_missing_dependency(self) -> None:
|
def test_topological_sort_missing_dependency(self) -> None:
|
||||||
# If a ticket depends on something not in the list, we should probably handle it or let it fail.
|
# If a ticket depends on something not in the list, we should handle it or let it fail.
|
||||||
# Usually in our context, we only care about dependencies within the same track.
|
# The TrackDAG silently ignores missing dependencies, causing cycle detection to trigger.
|
||||||
tickets = [
|
tickets = [
|
||||||
{"id": "t1", "depends_on": ["missing"]},
|
{"id": "t1", "depends_on": ["missing"]},
|
||||||
]
|
]
|
||||||
# Currently this raises KeyError in the list comprehension
|
# Currently this raises ValueError due to cycle detection on incomplete sort
|
||||||
with self.assertRaises(KeyError):
|
with self.assertRaises(ValueError):
|
||||||
conductor_tech_lead.topological_sort(tickets)
|
conductor_tech_lead.topological_sort(tickets)
|
||||||
|
|
||||||
def test_topological_sort_vlog(vlogger) -> None:
|
def test_topological_sort_vlog(vlogger) -> None:
|
||||||
|
|||||||
@@ -48,9 +48,9 @@ class TestBulkOperations:
|
|||||||
|
|
||||||
with patch.object(mock_app.controller, "_push_mma_state_update") as mock_push:
|
with patch.object(mock_app.controller, "_push_mma_state_update") as mock_push:
|
||||||
mock_app.bulk_execute()
|
mock_app.bulk_execute()
|
||||||
assert mock_app.active_tickets[0]["status"] == "ready"
|
assert mock_app.active_tickets[0]["status"] == "in_progress"
|
||||||
assert mock_app.active_tickets[1]["status"] == "todo"
|
assert mock_app.active_tickets[1]["status"] == "todo"
|
||||||
assert mock_app.active_tickets[2]["status"] == "ready"
|
assert mock_app.active_tickets[2]["status"] == "in_progress"
|
||||||
mock_push.assert_called_once()
|
mock_push.assert_called_once()
|
||||||
|
|
||||||
def test_bulk_skip(self, mock_app):
|
def test_bulk_skip(self, mock_app):
|
||||||
|
|||||||
Reference in New Issue
Block a user