chore(tech-debt): Finalize gui_2.py cleanup and test suite discipline

This commit is contained in:
2026-03-02 21:43:56 -05:00
parent 8af1bcd960
commit a569f8c02f
26 changed files with 58 additions and 364 deletions

View File

@@ -31,10 +31,11 @@ async def test_confirm_spawn_pushed_to_queue() -> None:
prompt = "Original Prompt"
context_md = "Original Context"
# Start confirm_spawn in a thread since it blocks with time.sleep
loop = asyncio.get_running_loop()
def run_confirm():
return multi_agent_conductor.confirm_spawn(role, prompt, context_md, event_queue, ticket_id)
loop = asyncio.get_running_loop()
return multi_agent_conductor.confirm_spawn(role, prompt, context_md, event_queue, ticket_id, loop=loop)
with concurrent.futures.ThreadPoolExecutor() as executor:
future = loop.run_in_executor(executor, run_confirm)
# Wait for the event to appear in the queue
@@ -58,7 +59,8 @@ def test_run_worker_lifecycle_approved(mock_confirm: MagicMock, mock_ai_client:
context = WorkerContext(ticket_id="T1", model_name="model", messages=[])
event_queue = events.AsyncEventQueue()
mock_confirm.return_value = (True, "Modified Prompt", "Modified Context")
multi_agent_conductor.run_worker_lifecycle(ticket, context, event_queue=event_queue)
loop = MagicMock()
multi_agent_conductor.run_worker_lifecycle(ticket, context, event_queue=event_queue, loop=loop)
mock_confirm.assert_called_once()
# Check that ai_client.send was called with modified values
args, kwargs = mock_ai_client.call_args
@@ -72,7 +74,8 @@ def test_run_worker_lifecycle_rejected(mock_confirm: MagicMock, mock_ai_client:
context = WorkerContext(ticket_id="T1", model_name="model", messages=[])
event_queue = events.AsyncEventQueue()
mock_confirm.return_value = (False, "Original Prompt", "Original Context")
result = multi_agent_conductor.run_worker_lifecycle(ticket, context, event_queue=event_queue)
loop = MagicMock()
result = multi_agent_conductor.run_worker_lifecycle(ticket, context, event_queue=event_queue, loop=loop)
mock_confirm.assert_called_once()
mock_ai_client.assert_not_called()
assert ticket.status == "blocked"