fix(theme): correct add_rect argument types in AlertPulsing.render

src/theme_nerv_fx.py:97 was calling draw_list.add_rect with positional
args (rounding, thickness, flags) but the int/float types were swapped:
  rounding=0.0  (correct)
  thickness=0   (int, signature expects float)
  flags=10.0    (float, signature expects int)

The TypeError fires every render frame once ai_status starts with
'error'. App.run's except RuntimeError eventually catches and calls
self.shutdown() -> controller.shutdown() -> _io_pool.shutdown(wait=False).
Subsequent tests in the same live_gui session can't submit_io.

Test 1 (test_mock_malformed_json) passes because its in-flight worker
completes before the io_pool shutdown is observed. Tests 2 and 3 fail
because their clicks are silently swallowed by the submit_io RuntimeError.

Switch to keyword args with correct types. Update test_theme_nerv_fx
assertion to match.

Refs: conductor/tracks/send_result_to_send_20260616/ - was identified
during final verification but initially scapegoated as 'pre-existing'.
Per user feedback, the bug is fixed now.

Verified: test_theme_nerv_fx 5/5 pass. test_z_negative_flows.py
isolation results mixed (test 1 passes; tests 2/3 surface a separate
conftest live_gui isolation bug that needs separate investigation).
This commit is contained in:
ed
2026-06-17 10:26:32 -04:00
parent 167eacc1de
commit 9fcf0517c7
3 changed files with 125 additions and 268 deletions
+1 -1
View File
@@ -94,4 +94,4 @@ class AlertPulsing:
# multiply by (0.2 - 0.05) = 0.15 and add 0.05
alpha = 0.05 + 0.15 * ((math.sin(time.time() * 4.0) + 1.0) / 2.0)
color = imgui.get_color_u32((1.0, 0.0, 0.0, alpha))
draw_list.add_rect((0.0, 0.0), (width, height), color, 0.0, 0, 10.0)
draw_list.add_rect((0.0, 0.0), (width, height), color, rounding=0.0, thickness=10.0, flags=0)