chore(conductor): Mark track 'Curate Provider Registries' as complete. Includes critical fixes for RecursionError, NoneType Hook API responses, and plurality mismatches.

tests/test_auto_switch_sim.py

@@ -38,7 +38,7 @@ def test_auto_switch_sim(live_gui):
  trigger_tier('Tier 2 (Tech Lead)')
  time.sleep(1)
  assert client.get_value('show_windows').get('Diagnostics', False) == False
- 
+
  # Then Tier 3
  trigger_tier('Tier 3 (Worker): task-1')
  time.sleep(1)

tests/test_deepseek_infra.py

@@ -36,8 +36,8 @@ def test_gui_providers_list() -> None:
  """
     Check if 'deepseek' is in the GUI's provider list.
     """
- import gui_2
- assert "deepseek" in gui_2.PROVIDERS
+ from src.models import PROVIDERS
+ assert "deepseek" in PROVIDERS
 
 def test_deepseek_model_listing() -> None:
  """

tests/test_extended_sims.py

@@ -23,6 +23,7 @@ def test_context_sim_live(live_gui: Any) -> None:
  sim.setup("LiveContextSim")
  client.set_value('current_provider', 'gemini_cli')
  client.set_value('gcli_path', f'"{sys.executable}" "{os.path.abspath("tests/mock_gemini_cli.py")}"')
+ client.set_value('auto_add_history', True)
  sim.run() # Ensure history is updated via the async queue
  time.sleep(2)
  sim.teardown()
@@ -36,6 +37,7 @@ def test_ai_settings_sim_live(live_gui: Any) -> None:
  sim.setup("LiveAISettingsSim")
  client.set_value('current_provider', 'gemini_cli')
  client.set_value('gcli_path', f'"{sys.executable}" "{os.path.abspath("tests/mock_gemini_cli.py")}"') # Expect gemini_cli as the provider
+ client.set_value('auto_add_history', True)
  assert client.get_value('current_provider') == 'gemini_cli'
  sim.run()
  sim.teardown()
@@ -49,6 +51,7 @@ def test_tools_sim_live(live_gui: Any) -> None:
  sim.setup("LiveToolsSim")
  client.set_value('current_provider', 'gemini_cli')
  client.set_value('gcli_path', f'"{sys.executable}" "{os.path.abspath("tests/mock_gemini_cli.py")}"')
+ client.set_value('auto_add_history', True)
  sim.run() # Ensure history is updated via the async queue
  time.sleep(2)
  sim.teardown()
@@ -63,6 +66,7 @@ def test_execution_sim_live(live_gui: Any) -> None:
  client.set_value('manual_approve', True)
  client.set_value('current_provider', 'gemini_cli')
  client.set_value('gcli_path', f'"{sys.executable}" "{os.path.abspath("tests/mock_gemini_cli.py")}"')
+ client.set_value('auto_add_history', True)
  sim.run()
  time.sleep(2)
  sim.teardown()

tests/test_minimax_provider.py

@@ -26,12 +26,12 @@ def test_minimax_history_bleed_stats() -> None:
  assert stats["limit"] == 204800
 
 def test_minimax_in_providers_list() -> None:
- from src.gui_2 import PROVIDERS
+ from src.models import PROVIDERS
  assert "minimax" in PROVIDERS
 
 def test_minimax_in_app_controller_providers() -> None:
- from src.app_controller import AppController
- assert "minimax" in AppController.PROVIDERS
+ from src.models import PROVIDERS
+ assert "minimax" in PROVIDERS
 
 def test_minimax_credentials_template() -> None:
  try:

tests/test_mma_approval_indicators.py

@@ -20,8 +20,16 @@ def _make_app(**kwargs):
  app.mma_status = kwargs.get("mma_status", "idle")
  app.active_tier = kwargs.get("active_tier", None)
  app.mma_step_mode = kwargs.get("mma_step_mode", False)
- app._pending_mma_spawn = kwargs.get("_pending_mma_spawn", None)
- app._pending_mma_approval = kwargs.get("_pending_mma_approval", None)
+ app._pending_mma_spawns = []
+ app._pending_mma_approvals = []
+ spawn = kwargs.get("_pending_mma_spawn", None)
+ app._pending_mma_spawn = spawn
+ if spawn:
+  app._pending_mma_spawns.append(spawn)
+ approval = kwargs.get("_pending_mma_approval", None)
+ app._pending_mma_approval = approval
+ if approval:
+  app._pending_mma_approvals.append(approval)
  app._pending_ask_dialog = kwargs.get("_pending_ask_dialog", False)
  app.perf_profiling_enabled = False
  app.ui_new_track_name = ""

tests/test_provider_curation.py

@@ -0,0 +1,8 @@
+import src.models as models
+import src.app_controller
+
+def test_providers_moved_to_models():
+ """Verify that PROVIDERS list is in models.py and removed from AppController."""
+ expected_providers = ['gemini', 'anthropic', 'gemini_cli', 'deepseek', 'minimax']
+ assert models.PROVIDERS == expected_providers
+ assert not hasattr(src.app_controller.AppController, 'PROVIDERS')

tests/test_rag_phase4_stress.py

@@ -31,6 +31,7 @@ def test_rag_large_codebase_verification_sim(live_gui):
   client.set_value('rag_enabled', True)
   client.set_value('rag_source', 'chroma')
   client.set_value('rag_emb_provider', 'local')
+  client.set_value('auto_add_history', True)
   
   # 3. Trigger Initial Indexing
   print("[SIM] Triggering initial indexing of 50 files...")
@@ -79,7 +80,6 @@ def test_rag_large_codebase_verification_sim(live_gui):
   # 6. Verify retrieval of modified content
   client.set_value('current_provider', 'gemini_cli')
   client.set_value('gcli_path', os.path.abspath(os.path.join(os.path.dirname(__file__), "mock_gcli.bat")))
-  client.set_value('auto_add_history', True)
   client.set_value('ai_input', "What is the modified content?")
   client.click('btn_gen_send')