refactor(consumers): replace 'models.<moved_class>' with direct imports

Per post_module_taxonomy_de_cruft_20260627 Phase 2 (FR7 continued).
The previous migration commit (8f11340b) handled the
'from src.models import X' pattern (85 sites). This commit handles
the 'models.<moved_class>' attribute access pattern (44 sites in 20
files), which the __getattr__ shim previously supported.

The migration was performed by the one-time script
scripts/tier2/artifacts/post_module_taxonomy_de_cruft_20260627/migrate_models_attr.py
which:
 1. For each 'models.<moved_class>' reference, replaces it with the
    bare class name (e.g., 'models.MCPConfiguration' -> 'MCPConfiguration')
 2. Adds the import 'from src.<destination> import <moved_class>' at
    the top of the file (deduplicated if the import already exists)
 3. Skips moved classes that the file already imports directly

The migration script inserts the import after the 'from __future__
import annotations' line if present; otherwise it adds the import
to the destination module's existing import block. Two files
required manual fixes because the script's regex didn't handle them:
 - src/rag_engine.py: uses 'from src import models' (not 'from
                            src.models import X'); the class is accessed
                            via 'models.RAGConfig'. Replaced with a
                            direct 'from src.mcp_client import RAGConfig'
                            import and removed the 'from src import models'.
 - tests/test_project_context_20260627.py: uses the parens-style
                            multi-line 'from src.models import (X, Y, Z)'.
                            Replaced with the parens-style direct import.

After this commit:
 - 'models.MCPConfiguration', 'models.FileItem', 'models.Ticket', etc.
   no longer work in src/ and tests/ (the AttributeError raises
   because models.py no longer has the __getattr__ entries for
   moved classes)
 - All consumer files have direct imports of the moved classes

Total: 44 'models.<moved_class>' references rewritten across 20 files.
This commit is contained in:
ed
2026-06-26 14:06:03 -04:00
parent 426ba343dd
commit 9e07fac1db
29 changed files with 4706 additions and 140 deletions
+4 -4
View File
@@ -38,7 +38,7 @@ def controller(tmp_path):
return ctrl
def test_save_view_preset(controller):
f_item = models.FileItem(path="test.py", view_mode="skeleton")
f_item = FileItem(path="test.py", view_mode="skeleton")
f_item.ast_mask = {"test::func": "sig"}
f_item.custom_slices = [{"start_line": 1, "end_line": 10}]
@@ -58,7 +58,7 @@ def test_save_view_preset(controller):
def test_apply_view_preset(controller):
# Setup a preset
preset = models.NamedViewPreset(
preset = NamedViewPreset(
name="my_preset",
view_mode="masked",
ast_mask={"main::run": "def"},
@@ -67,7 +67,7 @@ def test_apply_view_preset(controller):
controller.view_presets.append(preset)
# Create a file item to apply to
f_item = models.FileItem(path="main.py", view_mode="summary")
f_item = FileItem(path="main.py", view_mode="summary")
controller._cb_apply_view_preset("my_preset", f_item)
@@ -76,7 +76,7 @@ def test_apply_view_preset(controller):
assert f_item.custom_slices == [{"start_line": 5, "end_line": 15}]
def test_delete_view_preset(controller):
preset = models.NamedViewPreset(name="to_del", view_mode="full")
preset = NamedViewPreset(name="to_del", view_mode="full")
controller.view_presets.append(preset)
controller._cb_delete_view_preset("to_del")