Private
Public Access
test(orchestration_logic): mock send_result not send (Phase 2.13, fixes Phase 1.1 regression)
Phase 1.1 + 1.2 migrated the production code to send_result(). The test_generate_tracks and test_generate_tickets tests mocked src.ai_client.send, causing "send was called 0 times" failures. Changes: - Replace patch(src.ai_client.send) with patch(src.ai_client.send_result) - Wrap mock return_value with Result(data=mock_response) - Add "from src.result_types import Result" import All 8 tests in tests/test_orchestration_logic.py pass (2 migrated + 6 unaffected tests).
This commit is contained in:
@@ -4,6 +4,7 @@ from src import orchestrator_pm
|
|||||||
from src import multi_agent_conductor
|
from src import multi_agent_conductor
|
||||||
from src import conductor_tech_lead
|
from src import conductor_tech_lead
|
||||||
from src.models import Ticket, Track, WorkerContext
|
from src.models import Ticket, Track, WorkerContext
|
||||||
|
from src.result_types import Result
|
||||||
|
|
||||||
def test_generate_tracks() -> None:
|
def test_generate_tracks() -> None:
|
||||||
mock_response = """
|
mock_response = """
|
||||||
@@ -12,7 +13,7 @@ def test_generate_tracks() -> None:
|
|||||||
{"id": "track_2", "title": "Refactor", "goal": "decouple modules", "type": "refactor"}
|
{"id": "track_2", "title": "Refactor", "goal": "decouple modules", "type": "refactor"}
|
||||||
]
|
]
|
||||||
"""
|
"""
|
||||||
with patch("src.ai_client.send", return_value=mock_response):
|
with patch("src.ai_client.send_result", return_value=Result(data=mock_response)):
|
||||||
tracks = orchestrator_pm.generate_tracks("Develop feature X", {}, [])
|
tracks = orchestrator_pm.generate_tracks("Develop feature X", {}, [])
|
||||||
assert len(tracks) == 2
|
assert len(tracks) == 2
|
||||||
assert tracks[0]["id"] == "track_1"
|
assert tracks[0]["id"] == "track_1"
|
||||||
@@ -25,7 +26,7 @@ def test_generate_tickets() -> None:
|
|||||||
{"id": "T2", "description": "task 2", "depends_on": ["T1"]}
|
{"id": "T2", "description": "task 2", "depends_on": ["T1"]}
|
||||||
]
|
]
|
||||||
"""
|
"""
|
||||||
with patch("src.ai_client.send", return_value=mock_response):
|
with patch("src.ai_client.send_result", return_value=Result(data=mock_response)):
|
||||||
tickets = conductor_tech_lead.generate_tickets("Track goal", "code skeletons")
|
tickets = conductor_tech_lead.generate_tickets("Track goal", "code skeletons")
|
||||||
assert len(tickets) == 2
|
assert len(tickets) == 2
|
||||||
assert tickets[0]["id"] == "T1"
|
assert tickets[0]["id"] == "T1"
|
||||||
|
|||||||
Reference in New Issue
Block a user