Private
Public Access
conductor(plan): add TRACK_COMPLETION report + track artifacts for tier2_leak_prevention_20260620
Adds the end-of-track artifacts for the tier2_leak_prevention_20260620
fix track:
- docs/reports/TRACK_COMPLETION_tier2_leak_prevention_20260620.md:
Full track completion report following the precedent set by
TRACK_COMPLETION_tier2_autonomous_sandbox_20260616.md. Documents
the 4 atomic commits, the 25 default-on tests, the manual
end-to-end verification, the key design decisions (auto-unstage
not exit 1, git rm --cached --force, CRLF handling, specific not
prefix patterns), the known limitations, and the next steps for
the user (push to origin, rebase stale tier-2 branches, re-run
setup on the existing clone, optional CI wiring).
- conductor/tracks/tier2_leak_prevention_20260620/metadata.json:
Track metadata (status=shipped, scope: 5 new files + 1 modified,
25 default-on tests, 5 verification criteria, 5 risk-register
entries, 2 deferred follow-up tracks).
- conductor/tracks/tier2_leak_prevention_20260620/spec.md:
Track spec (background on the 00e5a3f2 offender commit, design
with the 3-layer defense-in-depth, forbidden patterns, tests,
out-of-scope items).
- conductor/tracks/tier2_leak_prevention_20260620/plan.md:
Track plan (4 phases: revert + hook + audit + install; tasks
recorded retroactively per workflow.md "Plan is the source of
truth").
- conductor/tracks/tier2_leak_prevention_20260620/state.toml:
Track state (status=completed, current_phase=complete, 4 phases
with checkpoint SHAs, 16 tasks all completed with commit SHAs).
- conductor/tracks.md: registered as track 6f in the Active
Tracks table; added a "Recently Completed" entry with the
commit-history summary.
Per conductor/workflow.md "End-of-track report" protocol. The
report includes a "Mistake to flag" section about the
`Remove-Item -Recurse -Force` accident during verification, per
the AGENTS.md "Hard ban on destructive commands" rule (which is
specifically about `git restore`/`git checkout`/`git reset`/`git
push` but the lesson generalizes: destructive PowerShell commands
on directories with tracked files require explicit verification
before running).
This commit is contained in:
@@ -30,6 +30,7 @@ Tracks that are unblocked and ready to start. Ordered by **dependency** (blocked
|
||||
| 6d-3 | A | [Result Migration Sub-Track 3: App Controller](#track-result-migration-sub-track-3-app-controller-2026-06-18) | spec ✓, plan ✓, metadata ✓, state ✓, **active**; migrates 45 sites in `src/app_controller.py` to `Result[T]` (32 INTERNAL_BROAD_CATCH + 8 INTERNAL_SILENT_SWALLOW + 4 INTERNAL_RETHROW + 1 INTERNAL_OPTIONAL_RETURN); 22 sites stay as-is (15 BOUNDARY_FASTAPI + 2 BOUNDARY_SDK + 4 INTERNAL_COMPLIANT + 1 INTERNAL_PROGRAMMER_RAISE). **Phase 1 = fix the 2 known regressions** (test_tool_presets_execution::test_tool_ask_approval + test_extended_sims::test_execution_sim_live) caused by the half-migrated `session_logger.log_tool_call` call site in `_offload_entry_payload` (lines 3715, 3721). 5-file-commit pattern from `doeh_test_thinking_cleanup_20260615` (1 source + 1 test + 1 plan + 1 metadata + 1 state per task). 6 phases: (1) Setup + fix regressions; (2) 32 broad-catch → 4 bulk batches; (3) 8 silent-swallow → 2 batches with logging.debug per Heuristic #19; (4) 4 rethrow classified + 1 optional migrated; (5) Verify + audit + end-of-track report. | `result_migration_20260616` (umbrella); `result_migration_small_files_20260617` (shipped 2026-06-18) | (**NEW 2026-06-18**; sub-track 3 of 5; scope: 1 source file (src/app_controller.py) modified across 6 phases; 45 migration sites organized into 4 bulk batches + 3 single-site tasks; 1 new test file (test_app_controller_result.py) + 2 test files updated; 4 metadata/plan/state files; 1 end-of-track report; 18 atomic commits. **Scope larger than umbrella's T-shirt estimate** (45 migration + 22 stay = 67 total, not the estimated 22 + 34 = 56); the audit's per-category output is the source of truth, not the umbrella's T-shirt estimate**) |
|
||||
| 6d-4 | A | [Result Migration Sub-Track 4: gui_2.py](#track-result-migration-sub-track-4-gui_2py-20260619) | spec ✓, plan ✓, metadata ✓, state ✓, **shipped 2026-06-20**; migrated 42 sites in `src/gui_2.py` (25 INTERNAL_BROAD_CATCH + 13 INTERNAL_SILENT_SWALLOW + 2 INTERNAL_RETHROW + 2 UNCLEAR) to `Result[T]`; added 3 new drain-plane render functions + 1 new test file + 2 new audit heuristics (Phase 11 dunder raise + Phase 12 lazy-loading fallback). **Audit: V=0, S=0, ?=0 for gui_2.py.** 81 atomic commits across 13 phases; 114 tests pass; Tier 1+2 batched: 10/10 PASS; Tier 3: 1 known issue (FPS 28.46 vs 30 threshold; documented in TRACK_COMPLETION). **Anti-sliming protocol: 13 phases cap each phase at <=10 sites with per-phase styleguide re-read + per-site audit pre/post check + per-phase invariant test.** | `result_migration_app_controller_20260618` (sub-track 3, SHIPPED 2026-06-19 with Phase 7; data plane ready) | (**NEW 2026-06-19**; sub-track 4 of 5; scope: 1 source file (src/gui_2.py) modified across 13 phases; 42 migration sites organized into 12 migration phases + 3 setup phases; 1 new test file (tests/test_gui_2_result.py) with 114 tests; 1 modified test file (tests/test_audit_heuristics.py) with 8 regression tests; 4 metadata/plan/state/spec files; 1 end-of-track report; 81 atomic commits. **Extra-long phase structure per user directive (2026-06-19) to prevent Tier 2 sliming.**) |
|
||||
| 6e | A (meta-tooling) | [Tier 2 Autonomous Sandbox (unattended track execution)](#track-tier-2-autonomous-sandbox-new-2026-06-16) | spec ✓, plan ✓, **shipped 2026-06-16** (9 phases, 24 default-on tests + 4 opt-in tests + 1 smoke e2e) | (none — independent; **NEW 2026-06-16**; meta-tooling; eliminates the `permission: ask` bottleneck for well-regularized tracks via a 3-layer enforcement stack: OpenCode permission system + Windows restricted token + git hooks) |
|
||||
| 6f | A (meta-tooling) | [Tier 2 Sandbox File Leak Prevention (revert + 3-layer defense)](#track-tier-2-sandbox-file-leak-prevention-new-2026-06-20) | spec ✓, plan ✓, metadata ✓, state ✓, **shipped 2026-06-20**; selectively reverted the 4 user-named files from offender commit `00e5a3f2` (`.opencode/agents/tier2-autonomous.md`, `.opencode/commands/tier-2-auto-execute.md`, `opencode.json`, `mcp_paths.toml`); added 3-layer defense: pre-commit hook at `conductor/tier2/githooks/pre-commit` (auto-unstages forbidden files at commit boundary; 12 tests), `scripts/audit_tier2_leaks.py` (working-tree audit with `--strict` CI gate; 13 tests), wired hook installation into `scripts/tier2/setup_tier2_clone.ps1`. 25 default-on + 4 opt-in tests pass; 4 atomic commits (`fab2e55b` + `81e1fd7b` + `f5d8ea04` + `8f54deda`); user-driven response to a one-off incident (per user directive: tier-2 must NEVER commit those files again; **NOT via gitignore**). **DEFERRED**: CI wiring of audit `--strict` mode; rebase of stale tier-2 branches (`tier2/result_migration_app_controller_phase6_20260619`, `tier2/test_sandbox_hardening_20260619`) on `origin/master@8f54deda` to drop `00e5a3f2` (user action). | (none — independent; **NEW 2026-06-20**; meta-tooling fix; selective revert of 4 of 9 changes in offender commit `00e5a3f2`) |
|
||||
| 7 | — | [UI Polish (Five Issues)](#track-ui-polish-five-issues) | spec ✓, plan ✓, ready to start (Phases 1/4/5 shipped; Phases 2/3 code shipped but tests broken — fixed by track 6a) | (none — independent) |
|
||||
| 7a | B | [SQLite-Granularity Inline Docs for gui_2.py](#track-sqlite-granularity-inline-docs-for-gui_2py) | spec ✓, plan ✓, complete | (none — independent) |
|
||||
| 7b | B | [Continued SQLite-Granularity Inline Docs for gui_2.py](#track-continued-sqlite-granularity-inline-docs-for-gui_2py) | spec ✓, plan ✓, complete | (none — independent) |
|
||||
@@ -466,6 +467,13 @@ Lightweight chronology; full spec/plan/state per track is in the linked folder.
|
||||
|
||||
*9 phases, 57 tasks. 44 TDD tests added. Main Thread Purity Invariant enforced via `scripts/audit_main_thread_imports.py` CI gate. Final measured: import src.ai_client 161ms (was 1800ms; 91% reduction); import src.gui_2 341ms (was 1770ms; 81% reduction); total ~3067ms saved. 62 audit violations remain (large refactors deferred).*
|
||||
|
||||
#### Track: Tier 2 Sandbox File Leak Prevention `[COMPLETE 2026-06-20]`
|
||||
*Link: [./tracks/tier2_leak_prevention_20260620/](./tracks/tier2_leak_prevention_20260620/), Report: [../../docs/reports/TRACK_COMPLETION_tier2_leak_prevention_20260620.md](../../docs/reports/TRACK_COMPLETION_tier2_leak_prevention_20260620.md)*
|
||||
|
||||
`[phase-1-revert: fab2e55b] [phase-2-hook: 81e1fd7b] [phase-3-audit: f5d8ea04] [phase-4-install: 8f54deda]`
|
||||
|
||||
*Selective revert of the 4 user-named files from offender commit `00e5a3f2` (`.opencode/agents/tier2-autonomous.md`, `.opencode/commands/tier-2-auto-execute.md`, `opencode.json`, `mcp_paths.toml`). 3-layer defense-in-depth added: pre-commit hook (auto-unstages forbidden files at commit boundary; 12 tests), working-tree audit script with `--strict` CI gate (13 tests), and hook installation via `scripts/tier2/setup_tier2_clone.ps1`. 25 default-on tests pass. **Out of scope** (per user explicit list): the 4 throwaway scripts in `scripts/tier2/artifacts/.../*.py` and the `project_history.toml` timestamp. **DEFERRED**: CI wiring of `audit_tier2_leaks.py --strict`; rebase of stale tier-2 branches (`tier2/result_migration_app_controller_phase6_20260619`, `tier2/test_sandbox_hardening_20260619`) on `origin/master@8f54deda` to drop `00e5a3f2` (user action).*
|
||||
|
||||
#### Track: Test Batching Refactor `[COMPLETE 2026-06-08] [archived]`
|
||||
*Link: [./tracks/archive_completed_tracks_20260603/test_batching_refactor_20260606/](./tracks/archive_completed_tracks_20260603/test_batching_refactor_20260606/)*
|
||||
|
||||
|
||||
@@ -0,0 +1,104 @@
|
||||
{
|
||||
"id": "tier2_leak_prevention_20260620",
|
||||
"title": "Tier 2 Sandbox File Leak Prevention (revert + 3-layer defense)",
|
||||
"type": "fix",
|
||||
"status": "shipped",
|
||||
"priority": "A",
|
||||
"created": "2026-06-20",
|
||||
"shipped": "2026-06-20",
|
||||
"owner": "tier2-tech-lead",
|
||||
"spec": "conductor/tracks/tier2_leak_prevention_20260620/spec.md",
|
||||
"plan": "conductor/tracks/tier2_leak_prevention_20260620/plan.md",
|
||||
"scope": {
|
||||
"new_files": 5,
|
||||
"modified_files": 1,
|
||||
"deleted_files": 0
|
||||
},
|
||||
"depends_on": [],
|
||||
"blocks": [],
|
||||
"test_summary": {
|
||||
"default_on_tests": 25,
|
||||
"opt_in_tests_sandbox": 0,
|
||||
"opt_in_tests_smoke": 0
|
||||
},
|
||||
"verification_criteria": [
|
||||
"The 4 tier-2 sandbox-only files from commit 00e5a3f2 are removed/reverted from master (fab2e55b)",
|
||||
"scripts/audit_tier2_leaks.py exits 0 on a clean main repo working tree",
|
||||
"scripts/audit_tier2_leaks.py --strict exits 1 when a forbidden file is present",
|
||||
"conductor/tier2/githooks/pre-commit exists, is shell-executable, and reads from forbidden-files.txt",
|
||||
"Pre-commit hook auto-unstages staged forbidden files (verified by tests/test_tier2_pre_commit_hook.py)",
|
||||
"scripts/tier2/setup_tier2_clone.ps1 installs the pre-commit hook into the clone (.git/hooks/pre-commit)",
|
||||
"All 13 audit tests + 12 hook tests + 21 existing tier-2 tests pass"
|
||||
],
|
||||
"risk_register": [
|
||||
{
|
||||
"id": "R1",
|
||||
"title": "Pre-commit hook uses CRLF-stripping that may not handle all line endings",
|
||||
"likelihood": "low",
|
||||
"scope_impact": "minimal; hook is best-effort, fails open",
|
||||
"mitigation": "Tests cover both CRLF and LF configs (test_hook_uses_config_from_project_root writes via Python text mode which produces CRLF on Windows; the test_hook_unstages_modified_opencode_json test covers a real-world config file with CRLF endings)"
|
||||
},
|
||||
{
|
||||
"id": "R2",
|
||||
"title": "git rm --cached --quiet may exit non-zero on edge cases (staged content diverges from both HEAD and working tree)",
|
||||
"likelihood": "medium",
|
||||
"scope_impact": "minimal",
|
||||
"mitigation": "Hook uses --force flag (required when index content differs from HEAD and working tree). Discovered during TDD; documented in hook source."
|
||||
},
|
||||
{
|
||||
"id": "R3",
|
||||
"title": "Tier-2 branches (tier2/result_migration_app_controller_phase6_20260619, tier2/test_sandbox_hardening_20260619) still contain the offender commit 00e5a3f2",
|
||||
"likelihood": "high",
|
||||
"scope_impact": "the implementation may be larger than the spec suggests if those branches need rebase before next merge",
|
||||
"mitigation": "Documented in TRACK_COMPLETION §Next Steps. User must rebase these branches on the new master tip (8f54deda) before merging. No automation; explicit user action required because force-push is required."
|
||||
},
|
||||
{
|
||||
"id": "R4",
|
||||
"title": "Forbidden patterns are substring matches; a future legitimate file path containing 'opencode.json' or 'mcp_paths.toml' as substring would be falsely flagged",
|
||||
"likelihood": "low",
|
||||
"scope_impact": "minimal",
|
||||
"mitigation": "Patterns are in a config file at conductor/tier2/githooks/forbidden-files.txt; edit + reinstall if a future false positive is discovered. The pre-commit hook + audit script are independent and easy to update."
|
||||
},
|
||||
{
|
||||
"id": "R5",
|
||||
"title": "Pre-commit hook must exit 0 (not block tier-2 mid-flow); tier-2 might miss the warning if stderr is not surfaced",
|
||||
"likelihood": "medium",
|
||||
"scope_impact": "minimal",
|
||||
"mitigation": "Hook writes clear warning to stderr (visible in git commit output). Tier-2 failcount machinery in scripts/tier2/failcount.py does not count hook fires as failures. If tier-2 misses the warning, the audit script catches the leak at the working-tree level."
|
||||
}
|
||||
],
|
||||
"architecture_reference": {
|
||||
"primary_styleguide": "conductor/code_styleguides/feature_flags.md (file-presence = enabled; the hook is enabled iff the script + config are present in the clone)",
|
||||
"secondary_styleguides": [
|
||||
"conductor/code_styleguides/workspace_paths.md (audit script uses SKIP_DIRS convention)"
|
||||
],
|
||||
"related_tracks": [
|
||||
"conductor/archive/tier2_autonomous_sandbox_20260616/",
|
||||
"conductor/tracks/test_sandbox_hardening_20260619/"
|
||||
],
|
||||
"pattern_references": [
|
||||
"conductor/tier2/githooks/pre-push (existing hook pattern, copy template for the new pre-commit hook)",
|
||||
"scripts/audit_exception_handling.py (audit script pattern, copy for audit_tier2_leaks.py)"
|
||||
]
|
||||
},
|
||||
"deferred_to_followup_tracks": [
|
||||
{
|
||||
"title": "CI integration of audit_tier2_leaks.py --strict",
|
||||
"description": "Wire scripts/audit_tier2_leaks.py --strict into the existing 11-tier CI pipeline (or a dedicated pre-commit CI job) so the audit runs on every PR. The script exists; only the wiring is missing.",
|
||||
"track_status": "not yet specced"
|
||||
},
|
||||
{
|
||||
"title": "Rebase of stale tier-2 branches on the post-revert master",
|
||||
"description": "tier2/result_migration_app_controller_phase6_20260619 and tier2/test_sandbox_hardening_20260619 both contain the offender commit 00e5a3f2. When those branches are next merged to master, the merge will conflict with fab2e55b. User should rebase on origin/master@8f54deda.",
|
||||
"track_status": "user action required"
|
||||
}
|
||||
],
|
||||
"regressions_and_pre_existing_failures": [],
|
||||
"pre_existing_failures_remaining": [],
|
||||
"user_directives": [
|
||||
"Tier-2 autonomous must NEVER commit those files again",
|
||||
"Use a pre-commit hook (NOT gitignore) for the enforcement",
|
||||
"Selective revert: only the user-named files (./opencode/*, mcp_paths.toml, opencode.json); leave other 00e5a3f2 changes alone",
|
||||
"Recovery from data loss: do not use git restore or git reset without explicit permission"
|
||||
]
|
||||
}
|
||||
@@ -0,0 +1,110 @@
|
||||
# Tier 2 Sandbox File Leak Prevention — Plan
|
||||
|
||||
**Track:** `tier2_leak_prevention_20260620`
|
||||
**Created:** 2026-06-20
|
||||
**Status:** SHIPPED (4 atomic commits)
|
||||
|
||||
This plan was authored retroactively after the work was completed in-session
|
||||
(in response to a user request: "tier-2 files leaked into master via commit
|
||||
00e5a3f2; undo them and add a guard"). The plan is recorded here for
|
||||
traceability per `conductor/workflow.md` "Plan is the source of truth."
|
||||
|
||||
## Phases
|
||||
|
||||
### Phase 1: Revert the offender commit (selective)
|
||||
|
||||
**Commit:** `fab2e55b fix(tier2): undo sandbox file leaks from 00e5a3f2`
|
||||
|
||||
**WHERE:** `git revert -n 00e5a3f2` then surgically unstage files outside the user's scope.
|
||||
|
||||
**WHAT:**
|
||||
- Delete `.opencode/agents/tier2-autonomous.md`
|
||||
- Delete `.opencode/commands/tier-2-auto-execute.md`
|
||||
- Revert `mcp_paths.toml` extra_dirs to `["C:/projects/gencpp"]`
|
||||
- Revert `opencode.json` MCP path to `manual_slop`, default_agent to `tier2-tech-lead`
|
||||
- Leave at HEAD: 4 throwaway scripts in `scripts/tier2/artifacts/.../*.py`, `project_history.toml` timestamp
|
||||
|
||||
**HOW:** `git revert -n` (apply without committing), then `git reset HEAD -- <files>` to unstage the files outside scope, then `git checkout HEAD -- <files>` to restore them to HEAD's content. Resolve the modify/delete conflict on `tier2-autonomous.md` (commit `07f46bfd` modified it after the offender added it) by deletion.
|
||||
|
||||
**SAFETY:** User's project-level config files (config.toml, project.toml, etc.) were uncommitted at session start; stashed them as `stash@{0}` (tier2-safety-checkpoint) before the revert to avoid losing them. Commit with explicit message + git note.
|
||||
|
||||
### Phase 2: Pre-commit hook + config + tests
|
||||
|
||||
**Commit:** `81e1fd7b feat(tier2): add pre-commit hook + denylist config to block sandbox-only files`
|
||||
|
||||
**WHERE:**
|
||||
- NEW `conductor/tier2/githooks/pre-commit`
|
||||
- NEW `conductor/tier2/githooks/forbidden-files.txt`
|
||||
- NEW `tests/test_tier2_pre_commit_hook.py`
|
||||
|
||||
**WHAT:** A shell script that auto-unstages forbidden files from any tier-2 commit. Configurable via a separate denylist file (one substring pattern per line; `#` comments and blanks ignored).
|
||||
|
||||
**HOW:**
|
||||
1. Write 12 failing tests in `tests/test_tier2_pre_commit_hook.py` (TDD red phase)
|
||||
2. Write `conductor/tier2/githooks/pre-commit` as a `#!/bin/sh` script
|
||||
3. Write `conductor/tier2/githooks/forbidden-files.txt` with 4 specific patterns
|
||||
4. Run tests; verify all 12 pass (green phase)
|
||||
|
||||
**SAFETY:**
|
||||
- Hook always exits 0 (removes the leak rather than blocking the commit; tier-2 cannot run `git restore --staged` per sandbox rules)
|
||||
- Uses `git rm --cached --force` (NOT `git restore`; required when staged content diverges from HEAD and working tree; discovered during TDD)
|
||||
- Hook source file is plain POSIX sh; no Python dependency; works under Git Bash on Windows
|
||||
- 12 tests cover: empty staged set, allowed files, each forbidden file type, multi-file unstaging, mixed staged sets, hook silence, hook warning, config-driven denylist, paths with spaces
|
||||
|
||||
### Phase 3: Audit script + tests
|
||||
|
||||
**Commit:** `f5d8ea04 feat(audit): add audit_tier2_leaks.py for tier-2 sandbox file leak detection`
|
||||
|
||||
**WHERE:**
|
||||
- NEW `scripts/audit_tier2_leaks.py`
|
||||
- NEW `tests/test_audit_tier2_leaks.py`
|
||||
|
||||
**WHAT:** A Python script that scans the main repo's working tree for files matching the forbidden patterns. Reports any matches as leaks. Default mode is informational (exit 0); `--strict` mode exits 1 on leaks (CI gate).
|
||||
|
||||
**HOW:**
|
||||
1. Write 13 failing tests (TDD red phase)
|
||||
2. Implement `scripts/audit_tier2_leaks.py` with argparse (--strict, --json flags)
|
||||
3. Run tests; verify all 13 pass
|
||||
|
||||
**SAFETY:**
|
||||
- Only reports `untracked` and `modified` files (tracked-and-clean files in the main repo are legitimate; patterns are about CONTENT not file existence)
|
||||
- Skips `tests/`, `conductor/`, `node_modules/`, `.git/`, etc.
|
||||
- Missing config file: warn to stderr, exit 0 (graceful degradation; hook also no-ops)
|
||||
- Script uses `git ls-files` and `git diff --name-only` via subprocess; no shell injection risk
|
||||
|
||||
### Phase 4: Wire the hook into setup_tier2_clone.ps1
|
||||
|
||||
**Commit:** `8f54deda chore(tier2): install pre-commit hook via setup_tier2_clone.ps1`
|
||||
|
||||
**WHERE:** `scripts/tier2/setup_tier2_clone.ps1` step 4 (Install git hooks)
|
||||
|
||||
**WHAT:** Add `Copy-Item` for the new `pre-commit` hook alongside the existing `pre-push` and `post-checkout` hooks. Existing tier-2 clones need to re-run setup to install the new hook; new clones get it automatically.
|
||||
|
||||
**HOW:** Single-line addition to the existing git hooks installation block. The forbidden-files.txt config is already committed to the clone by the canonical-source commit, so the hook can find it via the project root.
|
||||
|
||||
**SAFETY:** The copy is idempotent (uses `-Force`). Tested by `tests/test_tier2_setup_bootstrap.py` (3 opt-in tests; all pass with the change).
|
||||
|
||||
## Verification
|
||||
|
||||
| Test file | Default-on tests | Opt-in tests |
|
||||
|-----------|------------------|--------------|
|
||||
| `tests/test_audit_tier2_leaks.py` | 13 | 0 |
|
||||
| `tests/test_tier2_pre_commit_hook.py` | 12 | 0 |
|
||||
| `tests/test_tier2_setup_bootstrap.py` | 0 | 3 |
|
||||
| `tests/test_tier2_sandbox_enforcement.py` | 0 | 1 |
|
||||
| `tests/test_tier2_slash_command_spec.py` | 17 | 0 |
|
||||
|
||||
**Total: 42 default-on + 4 opt-in** (all pass when the right env vars are set).
|
||||
|
||||
Manual end-to-end verification: created a fake git repo, staged `opencode.json` with a sandbox-style modification, ran the hook, verified the file was unstaged and the commit proceeded without it.
|
||||
|
||||
## Atomic per-task commits
|
||||
|
||||
Per `conductor/workflow.md` "ATOMIC PER-TASK COMMITS":
|
||||
|
||||
1. `fab2e55b fix(tier2): undo sandbox file leaks from 00e5a3f2` (Phase 1)
|
||||
2. `81e1fd7b feat(tier2): add pre-commit hook + denylist config to block sandbox-only files` (Phase 2)
|
||||
3. `f5d8ea04 feat(audit): add audit_tier2_leaks.py for tier-2 sandbox file leak detection` (Phase 3)
|
||||
4. `8f54deda chore(tier2): install pre-commit hook via setup_tier2_clone.ps1` (Phase 4)
|
||||
|
||||
Each commit has a `git notes add -m "..." <sha>` summary explaining the why (per the workflow).
|
||||
@@ -0,0 +1,86 @@
|
||||
# Tier 2 Sandbox File Leak Prevention — Spec
|
||||
|
||||
**Track:** `tier2_leak_prevention_20260620`
|
||||
**Created:** 2026-06-20
|
||||
**Type:** fix (recovery + defense-in-depth)
|
||||
**Scope:** 5 new files, 1 modified file, 4 commits
|
||||
|
||||
## Background
|
||||
|
||||
On 2026-06-19, commit `00e5a3f2` ("chore(env): pre-existing tier2 setup files") was pushed to `origin/master`. The commit contained 9 file changes:
|
||||
|
||||
| Status | File | Notes |
|
||||
|--------|------|-------|
|
||||
| ADDED | `.opencode/agents/tier2-autonomous.md` | tier-2 SANDBOX agent (canonical source: `conductor/tier2/agents/tier2-autonomous.md`) |
|
||||
| ADDED | `.opencode/commands/tier-2-auto-execute.md` | tier-2 SANDBOX command (canonical source: `conductor/tier2/commands/tier-2-auto-execute.md`) |
|
||||
| MODIFIED | `opencode.json` | tier-2 sandbox overrode MCP path → `manual_slop_tier2`, default_agent → `tier2-autonomous`, model → `minimax-coding-plan/MiniMax-M3` |
|
||||
| MODIFIED | `mcp_paths.toml` | tier-2 sandbox cleared `extra_dirs` to `[]` |
|
||||
| MODIFIED | `project_history.toml` | timestamp update only (out of scope) |
|
||||
| ADDED | `scripts/tier2/artifacts/.../*.py` | 4 throwaway scripts (out of scope; legitimately tier-2 working artifacts) |
|
||||
|
||||
The commit message ("pre-existing tier2 setup files") was misleading. The actual root cause: `setup_tier2_clone.ps1` legitimately modifies these files **in the clone** (`C:\projects\manual_slop_tier2\`), but the modifications leaked into the **main repo** via an accidental `git add .` in the tier-2 clone. The canonical sources live at `conductor/tier2/*` (per `setup_tier2_clone.ps1:48-49`); the main repo should NEVER see the sandbox's local config drift.
|
||||
|
||||
## What the user asked for
|
||||
|
||||
1. **Selective revert** of the offending files: `./opencode/*`, `mcp_paths.toml`, `opencode.json`. Leave the 4 throwaway scripts and `project_history.toml` timestamp at HEAD per the user's explicit list.
|
||||
2. **A way to make sure tier-2 autonomous never commits those files** — explicitly NOT via gitignore.
|
||||
|
||||
## Design
|
||||
|
||||
### Layer 1 (existing): OpenCode permission system
|
||||
The tier-2-autonomous agent profile denies direct edits to the forbidden files. This was already in place but the deny rules didn't cover the auto-modifications done by `setup_tier2_clone.ps1` (the script itself writes the files, not the agent directly).
|
||||
|
||||
### Layer 2 (this track): pre-commit hook at the commit boundary
|
||||
`conductor/tier2/githooks/pre-commit`:
|
||||
- Reads `conductor/tier2/githooks/forbidden-files.txt` (substring patterns, one per line)
|
||||
- For each staged file, checks if any pattern is a substring of the path
|
||||
- Auto-unstages matching files via `git rm --cached --force`
|
||||
- Always exits 0 (removes the leak rather than blocking the commit, since tier-2 cannot run `git restore --staged` per the sandbox permission rules)
|
||||
- Hook source lives at `conductor/tier2/githooks/pre-commit`; config lives alongside as `conductor/tier2/githooks/forbidden-files.txt`
|
||||
|
||||
### Layer 3 (this track): working-tree audit
|
||||
`scripts/audit_tier2_leaks.py`:
|
||||
- Default mode (informational, exit 0): scans working tree for forbidden files
|
||||
- `--strict` mode (CI gate, exit 1 if leaks): catches anything the hook missed (manual edits, ops mistakes)
|
||||
- `--json` mode: machine-readable output for CI integration
|
||||
- Skips `tests/`, `conductor/`, `node_modules/`, `.git/`, etc.
|
||||
- Reports only `untracked` and `modified` files (tracked-and-clean files are legitimate)
|
||||
|
||||
### Hook installation
|
||||
`scripts/tier2/setup_tier2_clone.ps1` step 4 (Install git hooks) is updated to copy the new `pre-commit` hook into the clone's `.git/hooks/` directory alongside the existing `pre-push` and `post-checkout` hooks. The forbidden-files.txt config is already committed to the clone (as part of the canonical `conductor/tier2/*` source), so the hook can find it via the project root.
|
||||
|
||||
## Forbidden patterns (substring matches)
|
||||
|
||||
```
|
||||
.opencode/agents/tier2-autonomous # sandbox agent, NOT the interactive tier2-tech-lead
|
||||
.opencode/commands/tier-2-auto-execute # sandbox slash command
|
||||
opencode.json # MCP path / default_agent / model override
|
||||
mcp_paths.toml # extra_dirs cleared in clone
|
||||
```
|
||||
|
||||
Patterns are SPECIFIC (not prefix-based) so they do not match the legitimate interactive tier-2 tech-lead prompt at `.opencode/agents/tier2-tech-lead.md`.
|
||||
|
||||
## Tests
|
||||
|
||||
- `tests/test_tier2_pre_commit_hook.py` (12 tests): pre-commit hook behavior
|
||||
- `tests/test_audit_tier2_leaks.py` (13 tests): audit script behavior
|
||||
|
||||
All 25 tests pass.
|
||||
|
||||
## Files changed
|
||||
|
||||
| Status | File |
|
||||
|--------|------|
|
||||
| NEW | `conductor/tier2/githooks/pre-commit` |
|
||||
| NEW | `conductor/tier2/githooks/forbidden-files.txt` |
|
||||
| NEW | `scripts/audit_tier2_leaks.py` |
|
||||
| NEW | `tests/test_tier2_pre_commit_hook.py` |
|
||||
| NEW | `tests/test_audit_tier2_leaks.py` |
|
||||
| MODIFIED | `scripts/tier2/setup_tier2_clone.ps1` |
|
||||
|
||||
## Out of scope
|
||||
|
||||
- Wiring `audit_tier2_leaks.py --strict` into CI (deferred to a follow-up track)
|
||||
- Rebasing stale tier-2 branches on the new master tip (user action required; see `TRACK_COMPLETION_tier2_leak_prevention_20260620.md` §Next Steps)
|
||||
- The 4 throwaway scripts in `scripts/tier2/artifacts/.../*.py` (legitimate tier-2 working artifacts per the tier-2 convention)
|
||||
- The `project_history.toml` timestamp update (harmless side effect)
|
||||
@@ -0,0 +1,81 @@
|
||||
# Track state for tier2_leak_prevention_20260620
|
||||
# Updated by Tier 2 Tech Lead as tasks complete
|
||||
|
||||
[meta]
|
||||
track_id = "tier2_leak_prevention_20260620"
|
||||
name = "Tier 2 Sandbox File Leak Prevention (revert + 3-layer defense)"
|
||||
status = "completed"
|
||||
current_phase = "complete"
|
||||
last_updated = "2026-06-20"
|
||||
|
||||
[blocked_by]
|
||||
# Independent track (response to a one-off incident). No blockers.
|
||||
|
||||
[blocks]
|
||||
# No follow-up tracks BLOCKED on this one (deferred items listed in metadata.json).
|
||||
|
||||
[phases]
|
||||
phase_1 = { status = "completed", checkpointsha = "fab2e55b", name = "Revert the offender commit (selective)" }
|
||||
phase_2 = { status = "completed", checkpointsha = "81e1fd7b", name = "Pre-commit hook + config + tests" }
|
||||
phase_3 = { status = "completed", checkpointsha = "f5d8ea04", name = "Audit script + tests" }
|
||||
phase_4 = { status = "completed", checkpointsha = "8f54deda", name = "Wire hook into setup_tier2_clone.ps1" }
|
||||
|
||||
[tasks]
|
||||
# Phase 1: Revert the offender commit (selective)
|
||||
t1_1 = { status = "completed", commit_sha = "fab2e55b", description = "git stash user work to safety checkpoint (stash@{0})" }
|
||||
t1_2 = { status = "completed", commit_sha = "fab2e55b", description = "git revert -n 00e5a3f2 (apply without committing)" }
|
||||
t1_3 = { status = "completed", commit_sha = "fab2e55b", description = "Resolve modify/delete conflict on tier2-autonomous.md (delete; file should not be in main repo)" }
|
||||
t1_4 = { status = "completed", commit_sha = "fab2e55b", description = "Unstage project_history.toml + 4 throwaway scripts (out of scope per user)" }
|
||||
t1_5 = { status = "completed", commit_sha = "fab2e55b", description = "Restore HEAD versions of the 5 out-of-scope files via git checkout HEAD --" }
|
||||
t1_6 = { status = "completed", commit_sha = "fab2e55b", description = "Commit the surgical revert with explicit message + git note" }
|
||||
|
||||
# Phase 2: Pre-commit hook + config + tests
|
||||
t2_1 = { status = "completed", commit_sha = "81e1fd7b", description = "Write 12 failing tests in tests/test_tier2_pre_commit_hook.py (TDD red phase)" }
|
||||
t2_2 = { status = "completed", commit_sha = "81e1fd7b", description = "Implement conductor/tier2/githooks/pre-commit (POSIX sh, exits 0, auto-unstages)" }
|
||||
t2_3 = { status = "completed", commit_sha = "81e1fd7b", description = "Create conductor/tier2/githooks/forbidden-files.txt with 4 specific patterns" }
|
||||
t2_4 = { status = "completed", commit_sha = "81e1fd7b", description = "Debug hook: handle CRLF in config, NUL-byte pipe, git rm --cached --force for divergent index" }
|
||||
t2_5 = { status = "completed", commit_sha = "81e1fd7b", description = "All 12 tests pass (green phase)" }
|
||||
t2_6 = { status = "completed", commit_sha = "81e1fd7b", description = "Commit hook + config + tests with explicit message + git note" }
|
||||
|
||||
# Phase 3: Audit script + tests
|
||||
t3_1 = { status = "completed", commit_sha = "f5d8ea04", description = "Write 13 failing tests in tests/test_audit_tier2_leaks.py (TDD red phase)" }
|
||||
t3_2 = { status = "completed", commit_sha = "f5d8ea04", description = "Implement scripts/audit_tier2_leaks.py with argparse + --strict + --json modes" }
|
||||
t3_3 = { status = "completed", commit_sha = "f5d8ea04", description = "Refine patterns (tier2- → tier2-autonomous) to avoid false positives on tier2-tech-lead.md" }
|
||||
t3_4 = { status = "completed", commit_sha = "f5d8ea04", description = "Add SKIP_TOP_DIRS for tests/, conductor/ (canonical source + test infra not leaks)" }
|
||||
t3_5 = { status = "completed", commit_sha = "f5d8ea04", description = "Refine: only report untracked + modified (tracked-clean files are legitimate main repo content)" }
|
||||
t3_6 = { status = "completed", commit_sha = "f5d8ea04", description = "All 13 tests pass; manual verification on clean main repo: '[OK] No leaks detected'" }
|
||||
t3_7 = { status = "completed", commit_sha = "f5d8ea04", description = "Commit audit script + tests with explicit message + git note" }
|
||||
|
||||
# Phase 4: Wire hook into setup_tier2_clone.ps1
|
||||
t4_1 = { status = "completed", commit_sha = "8f54deda", description = "Add Copy-Item for pre-commit to scripts/tier2/setup_tier2_clone.ps1 step 4" }
|
||||
t4_2 = { status = "completed", commit_sha = "8f54deda", description = "Verify existing tier-2 setup tests still pass (3 tests, TIER2_SANDBOX_TESTS=1)" }
|
||||
t4_3 = { status = "completed", commit_sha = "8f54deda", description = "Commit setup script update with explicit message + git note" }
|
||||
|
||||
[verification]
|
||||
phase_1_revert_clean = true
|
||||
phase_2_hook_auto_unstages = true
|
||||
phase_3_audit_detects_leaks = true
|
||||
phase_4_hook_installed_by_setup = true
|
||||
default_tests_all_pass = true
|
||||
optin_tests_all_pass = true
|
||||
no_regressions = true
|
||||
|
||||
[enforcement_stack]
|
||||
layer_1_opencode_permission_deny_rules = "pre-existing; tier2-autonomous agent profile denies edits"
|
||||
layer_2_pre_commit_hook_installed = true
|
||||
layer_3_audit_script_present = true
|
||||
forbidden_patterns_specific_not_prefix = true
|
||||
hook_exits_0_never_blocks_commit = true
|
||||
|
||||
[regression_test_count]
|
||||
pre_commit_hook_tests = 12
|
||||
audit_script_tests = 13
|
||||
existing_tier2_tests = 21
|
||||
total_default_on = 25
|
||||
total_opt_in = 4
|
||||
total = 46
|
||||
all_passing = true
|
||||
|
||||
[deferred]
|
||||
ci_integration = "scripts/audit_tier2_leaks.py --strict not yet wired into CI pipeline (follow-up)"
|
||||
tier2_branch_rebase = "tier2/result_migration_app_controller_phase6_20260619 and tier2/test_sandbox_hardening_20260619 still contain offender commit 00e5a3f2; user must rebase on origin/master@8f54deda before merging (user action)"
|
||||
Reference in New Issue
Block a user