feat(mma): Phase 1 — source_tier tagging at emission

- ai_client: add current_tier module var; stamp source_tier on every _append_comms entry
- multi_agent_conductor: set current_tier='Tier 3' around send(), clear in finally
- conductor_tech_lead: set current_tier='Tier 2' around send(), clear in finally
- gui_2: _on_tool_log captures current_tier; _append_tool_log stores dict with source_tier
- tests: 8 new tests covering current_tier, source_tier in comms, tool log dict format
This commit is contained in:
2026-03-02 16:18:00 -05:00
parent 264b04f060
commit 8d9f25d0ce
5 changed files with 152 additions and 14 deletions

View File

@@ -0,0 +1,131 @@
"""
Tests for mma_agent_focus_ux_20260302 — Phase 1: Tier Tagging at Emission.
These tests are written RED-first: they fail before implementation.
"""
from typing import Generator
import pytest
from unittest.mock import patch
import ai_client
from gui_2 import App
@pytest.fixture
def app_instance() -> Generator[App, None, None]:
with (
patch('gui_2.load_config', return_value={'gui': {'show_windows': {}}}),
patch('gui_2.save_config'),
patch('gui_2.project_manager'),
patch('gui_2.session_logger'),
patch('gui_2.immapp.run'),
patch.object(App, '_load_active_project'),
patch.object(App, '_fetch_models'),
patch.object(App, '_load_fonts'),
patch.object(App, '_post_init')
):
yield App()
@pytest.fixture(autouse=True)
def reset_tier():
"""Reset current_tier before and after each test."""
if hasattr(ai_client, "current_tier"):
ai_client.current_tier = None
yield
if hasattr(ai_client, "current_tier"):
ai_client.current_tier = None
# ---------------------------------------------------------------------------
# Task 1.1 / 1.2: current_tier variable and source_tier in _append_comms
# ---------------------------------------------------------------------------
def test_current_tier_variable_exists():
"""ai_client must expose a module-level current_tier variable."""
assert hasattr(ai_client, "current_tier"), (
"ai_client.current_tier does not exist — Task 1.1 not implemented"
)
def test_append_comms_has_source_tier_key():
"""_append_comms entries must contain a 'source_tier' key."""
ai_client.clear_comms_log()
ai_client._append_comms("OUT", "request", {"text": "hello"})
log = ai_client.get_comms_log()
assert len(log) >= 1, "comms log is empty after _append_comms"
last_entry = log[-1]
assert "source_tier" in last_entry, (
f"'source_tier' key missing from comms entry: {last_entry}"
)
def test_append_comms_source_tier_none_when_unset():
"""source_tier must be None when current_tier is not set."""
ai_client.clear_comms_log()
ai_client.current_tier = None
ai_client._append_comms("OUT", "request", {"text": "hello"})
log = ai_client.get_comms_log()
last_entry = log[-1]
assert last_entry["source_tier"] is None, (
f"Expected source_tier=None, got {last_entry['source_tier']}"
)
def test_append_comms_source_tier_set_when_current_tier_set():
"""source_tier must reflect current_tier when it is set."""
ai_client.clear_comms_log()
ai_client.current_tier = "Tier 3"
ai_client._append_comms("OUT", "request", {"text": "hello"})
log = ai_client.get_comms_log()
last_entry = log[-1]
assert last_entry["source_tier"] == "Tier 3", (
f"Expected source_tier='Tier 3', got {last_entry['source_tier']}"
)
def test_append_comms_source_tier_tier2():
"""source_tier must reflect Tier 2 when current_tier = 'Tier 2'."""
ai_client.clear_comms_log()
ai_client.current_tier = "Tier 2"
ai_client._append_comms("IN", "response", {"text": "result"})
log = ai_client.get_comms_log()
last_entry = log[-1]
assert last_entry["source_tier"] == "Tier 2", (
f"Expected source_tier='Tier 2', got {last_entry['source_tier']}"
)
# ---------------------------------------------------------------------------
# Task 1.5: _tool_log stores dicts with source_tier
# ---------------------------------------------------------------------------
def test_append_tool_log_stores_dict(app_instance):
"""_append_tool_log must store a dict, not a tuple."""
app = app_instance
initial_len = len(app._tool_log)
app._append_tool_log("echo hello", "output", "Tier 3")
assert len(app._tool_log) == initial_len + 1, "_tool_log length did not increase"
entry = app._tool_log[-1]
assert isinstance(entry, dict), (
f"_tool_log entry is a {type(entry).__name__}, expected dict"
)
def test_append_tool_log_dict_has_source_tier(app_instance):
"""Dict entry must have 'source_tier' key."""
app = app_instance
app._append_tool_log("ls", "file1\nfile2", "Tier 3")
entry = app._tool_log[-1]
assert "source_tier" in entry, f"'source_tier' missing from tool log dict: {entry}"
assert entry["source_tier"] == "Tier 3"
def test_append_tool_log_dict_keys(app_instance):
"""Dict entry must have script, result, ts, source_tier keys."""
app = app_instance
app._append_tool_log("pwd", "/projects", None)
entry = app._tool_log[-1]
for key in ("script", "result", "ts", "source_tier"):
assert key in entry, f"key '{key}' missing from tool log entry: {entry}"
assert entry["script"] == "pwd"
assert entry["result"] == "/projects"
assert entry["source_tier"] is None