refactor(sdm): Global pass with refined 'External Only' SDM tags. Pruned redundant internal references and fixed indentation logic in injector. Verified full project compilation.

tests/test_conductor_engine_v2.py

@@ -9,8 +9,9 @@ from src import ai_client
 
 def test_conductor_engine_initialization() -> None:
  """
-    Test that ConductorEngine can be initialized with a Track.
-    """
+ 
+     Test that ConductorEngine can be initialized with a Track.
+ """
  track = Track(id="test_track", description="Test Track")
  from src.multi_agent_conductor import ConductorEngine
  engine = ConductorEngine(track=track, auto_queue=True)
@@ -18,8 +19,9 @@ def test_conductor_engine_initialization() -> None:
 
 def test_conductor_engine_run_executes_tickets_in_order(monkeypatch: pytest.MonkeyPatch, vlogger) -> None:
  """
-    Test that run iterates through executable tickets and calls the worker lifecycle.
-    """
+ 
+     Test that run iterates through executable tickets and calls the worker lifecycle.
+ """
  ticket1 = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker1")
  ticket2 = Ticket(id="T2", description="Task 2", status="todo", assigned_to="worker2", depends_on=["T1"])
  track = Track(id="track1", description="Track 1", tickets=[ticket1, ticket2])
@@ -64,8 +66,9 @@ def test_conductor_engine_run_executes_tickets_in_order(monkeypatch: pytest.Monk
 
 def test_run_worker_lifecycle_calls_ai_client_send(monkeypatch: pytest.MonkeyPatch) -> None:
  """
-    Test that run_worker_lifecycle triggers the AI client and updates ticket status on success.
-    """
+ 
+     Test that run_worker_lifecycle triggers the AI client and updates ticket status on success.
+ """
  ticket = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker1")
  context = WorkerContext(ticket_id="T1", model_name="test-model", messages=[])
  from src.multi_agent_conductor import run_worker_lifecycle
@@ -84,8 +87,9 @@ def test_run_worker_lifecycle_calls_ai_client_send(monkeypatch: pytest.MonkeyPat
 
 def test_run_worker_lifecycle_context_injection(monkeypatch: pytest.MonkeyPatch) -> None:
  """
-    Test that run_worker_lifecycle can take a context_files list and injects AST views into the prompt.
-    """
+ 
+     Test that run_worker_lifecycle can take a context_files list and injects AST views into the prompt.
+ """
  ticket = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker1")
  context = WorkerContext(ticket_id="T1", model_name="test-model", messages=[])
  context_files = ["primary.py", "secondary.py"]
@@ -129,8 +133,9 @@ def test_run_worker_lifecycle_context_injection(monkeypatch: pytest.MonkeyPatch)
 
 def test_run_worker_lifecycle_handles_blocked_response(monkeypatch: pytest.MonkeyPatch) -> None:
  """
-    Test that run_worker_lifecycle marks the ticket as blocked if the AI indicates it cannot proceed.
-    """
+ 
+     Test that run_worker_lifecycle marks the ticket as blocked if the AI indicates it cannot proceed.
+ """
  ticket = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker1")
  context = WorkerContext(ticket_id="T1", model_name="test-model", messages=[])
  from src.multi_agent_conductor import run_worker_lifecycle
@@ -145,10 +150,11 @@ def test_run_worker_lifecycle_handles_blocked_response(monkeypatch: pytest.Monke
 
 def test_run_worker_lifecycle_step_mode_confirmation(monkeypatch: pytest.MonkeyPatch) -> None:
  """
-    Test that run_worker_lifecycle passes confirm_execution to ai_client.send when step_mode is True.
-    Verify that if confirm_execution is called (simulated by mocking ai_client.send to call its callback),
-    the flow works as expected.
-    """
+ 
+     Test that run_worker_lifecycle passes confirm_execution to ai_client.send when step_mode is True.
+     Verify that if confirm_execution is called (simulated by mocking ai_client.send to call its callback),
+     the flow works as expected.
+ """
  ticket = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker1", step_mode=True)
  context = WorkerContext(ticket_id="T1", model_name="test-model", messages=[])
  from src.multi_agent_conductor import run_worker_lifecycle
@@ -181,9 +187,10 @@ def test_run_worker_lifecycle_step_mode_confirmation(monkeypatch: pytest.MonkeyP
 
 def test_run_worker_lifecycle_step_mode_rejection(monkeypatch: pytest.MonkeyPatch) -> None:
  """
-    Verify that if confirm_execution returns False, the logic (in ai_client, which we simulate here)
-    would prevent execution. In run_worker_lifecycle, we just check if it's passed.
-    """
+ 
+     Verify that if confirm_execution returns False, the logic (in ai_client, which we simulate here)
+     would prevent execution. In run_worker_lifecycle, we just check if it's passed.
+ """
  ticket = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker1", step_mode=True)
  context = WorkerContext(ticket_id="T1", model_name="test-model", messages=[])
  from src.multi_agent_conductor import run_worker_lifecycle
@@ -205,8 +212,9 @@ def test_run_worker_lifecycle_step_mode_rejection(monkeypatch: pytest.MonkeyPatc
 
 def test_conductor_engine_dynamic_parsing_and_execution(monkeypatch: pytest.MonkeyPatch, vlogger) -> None:
  """
-    Test that parse_json_tickets correctly populates the track and run executes them in dependency order.
-    """
+ 
+     Test that parse_json_tickets correctly populates the track and run executes them in dependency order.
+ """
  import json
  from src.multi_agent_conductor import ConductorEngine
  track = Track(id="dynamic_track", description="Dynamic Track")
@@ -272,9 +280,10 @@ def test_conductor_engine_dynamic_parsing_and_execution(monkeypatch: pytest.Monk
 
 def test_run_worker_lifecycle_pushes_response_via_queue(monkeypatch: pytest.MonkeyPatch) -> None:
  """
-    Test that run_worker_lifecycle pushes a 'response' event with the correct stream_id
-    via _queue_put when event_queue is provided.
-    """
+ 
+     Test that run_worker_lifecycle pushes a 'response' event with the correct stream_id
+     via _queue_put when event_queue is provided.
+ """
  ticket = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker1")
  context = WorkerContext(ticket_id="T1", model_name="test-model", messages=[])
  mock_event_queue = MagicMock()
@@ -297,9 +306,10 @@ def test_run_worker_lifecycle_pushes_response_via_queue(monkeypatch: pytest.Monk
 
 def test_run_worker_lifecycle_token_usage_from_comms_log(monkeypatch: pytest.MonkeyPatch) -> None:
  """
-    Test that run_worker_lifecycle reads token usage from the comms log and
-    updates engine.tier_usage['Tier 3'] with real input/output token counts.
-    """
+ 
+     Test that run_worker_lifecycle reads token usage from the comms log and
+     updates engine.tier_usage['Tier 3'] with real input/output token counts.
+ """
  ticket = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker1")
  context = WorkerContext(ticket_id="T1", model_name="test-model", messages=[])
  fake_comms = [
@@ -320,4 +330,4 @@ def test_run_worker_lifecycle_token_usage_from_comms_log(monkeypatch: pytest.Mon
   mock_spawn.return_value = (True, "prompt", "ctx")
   run_worker_lifecycle(ticket, context, event_queue=MagicMock(), engine=engine)
  assert engine.tier_usage["Tier 3"]["input"] == 120
- assert engine.tier_usage["Tier 3"]["output"] == 45
+ assert engine.tier_usage["Tier 3"]["output"] == 45