Merge branch 'tier2/type_alias_unfuck_20260626' of C:\projects\manual_slop_tier2 into tier2/type_alias_unfuck_20260626

conductor/tracks/type_alias_unfuck_20260626/state.toml

@@ -0,0 +1,91 @@
+# Track state for type_alias_unfuck_20260626
+# Updated by Tier 2 Tech Lead as tasks complete
+
+[meta]
+track_id = "type_alias_unfuck_20260626"
+name = "Type Alias Unfuck (Phase 1 Consumer Migrations)"
+status = "active"
+current_phase = "phase_11 (verification FAILED acceptance criteria)"
+last_updated = "2026-06-26"
+
+# Track FAILED acceptance criteria VC1, VC2, VC4, VC6.
+# Status is "active" because the spec's Definition of Done is NOT met.
+# Phase 7 is BLOCKED (no MCPToolResult dataclass in codebase).
+# Remaining 26 .get() sites are documented in collapsed_codepath_audit_20260626.md
+# but the spec required < 15 (VC1).
+# See docs/reports/TRACK_COMPLETION_type_alias_unfuck_20260626.md for full accounting.
+
+[blocked_by]
+metadata_promotion_20260624 = "merged"  # the previous track's branch was the foundation
+
+[blocks]
+# This track does not block any followup tracks (remaining 26 .get() sites
+# would each warrant their own refactor track but are deferred)
+
+[phases]
+phase_0 = { status = "completed", commit_sha = "076e7f23", name = "Pre-flight (baseline + 7 audit gates)" }
+phase_1 = { status = "completed", commit_sha = "n/a", name = "Ticket consumers (SKIP, Tier 2 had done it)" }
+phase_2 = { status = "completed", commit_sha = "96f0aa54", name = "FileItem (3 sites migrated)" }
+phase_3 = { status = "completed", commit_sha = "8cf8cfeb", name = "CommsLogEntry (7 sites migrated)" }
+phase_5 = { status = "completed", commit_sha = "8df841fd,6a2f2cfa,fc5f80ae", name = "ChatMessage (15 sites + 2 regression fixes)" }
+phase_6 = { status = "completed", commit_sha = "b3d0bc60", name = "UsageStats (4 sites migrated)" }
+phase_7 = { status = "blocked", commit_sha = "n/a", name = "ToolCall/MCPToolResult (BLOCKED: required dataclasses don't exist)" }
+phase_8 = { status = "completed", commit_sha = "f1740d92", name = "ToolDefinition (2 sites migrated)" }
+phase_9 = { status = "completed", commit_sha = "83f122eb", name = "RAGChunk (verified; Tier 2 had migrated)" }
+phase_10 = { status = "completed", commit_sha = "28799766,84ca734a,3cf01ae1,e508758f,75fa97ca", name = "Small-batch aggregates (23 sites migrated across 4 batches)" }
+phase_11 = { status = "failed", commit_sha = "n/a", name = "Re-measure + 7 audit gates + batched tests (FAILED: VC1/VC2/VC4/VC6 not met)" }
+phase_12 = { status = "completed", commit_sha = "3553b624", name = "Collapsed-codepath audit (docs/reports/collapsed_codepath_audit_20260626.md)" }
+
+[tasks]
+t0_1 = { status = "completed", commit_sha = "076e7f23", description = "Pre-flight: capture baseline + verify 7 audit gates" }
+t2_1 = { status = "completed", commit_sha = "96f0aa54", description = "Phase 2: FileItem migration in ai_client.py (3 sites)" }
+t3_1 = { status = "completed", commit_sha = "8cf8cfeb", description = "Phase 3: CommsLogEntry migration in gui_2.py (7 sites)" }
+t5_1 = { status = "completed", commit_sha = "8df841fd", description = "Phase 5 part 1: _send_deepseek history loop (6 sites)" }
+t5_2 = { status = "completed", commit_sha = "1b62659c,6a2f2cfa", description = "Phase 5 part 2: API response + _repair_minimax + ChatMessage/ToolCall/UsageStats from_dict (6 sites + infra)" }
+t5_3 = { status = "completed", commit_sha = "fc5f80ae", description = "Phase 5 regression fix: FileItem TypeAlias shadowing" }
+t6_1 = { status = "completed", commit_sha = "b3d0bc60", description = "Phase 6: UsageStats construction in app_controller.py (4 sites)" }
+t7_1 = { status = "blocked", commit_sha = "n/a", description = "Phase 7: ToolCall/MCPToolResult - BLOCKED, needs MCPToolResult dataclass first" }
+t8_1 = { status = "completed", commit_sha = "f1740d92", description = "Phase 8: ToolDefinition in mcp_client.py + gui_2.py (2 sites)" }
+t9_1 = { status = "completed", commit_sha = "83f122eb", description = "Phase 9: RAGChunk verification (no remaining sites)" }
+t10_1 = { status = "completed", commit_sha = "28799766", description = "Phase 10 batch 1: MMAUsageStats (8 sites)" }
+t10_2 = { status = "completed", commit_sha = "84ca734a", description = "Phase 10 batch 2: DiscussionSettings (1 site)" }
+t10_3 = { status = "completed", commit_sha = "3cf01ae1", description = "Phase 10 batch 3: CustomSlice reads (8 sites)" }
+t10_4 = { status = "completed", commit_sha = "e508758f", description = "Phase 10 infra: from_dict added to 7 dataclasses" }
+t10_5 = { status = "completed", commit_sha = "75fa97ca", description = "Phase 10 batch 4: UIPanelConfig + ProviderPayload + PathInfo (7 sites)" }
+t10_6 = { status = "completed", commit_sha = "f6d58ddb", description = "Phase 10 regression fix: missing MMAUsageStats import" }
+t11_1 = { status = "completed", commit_sha = "n/a", description = "Phase 11: 7 audit gates verified pass" }
+t12_1 = { status = "completed", commit_sha = "3553b624", description = "Phase 12: collapsed-codepath audit doc" }
+tend_1 = { status = "completed", commit_sha = "1a76636e", description = "End-of-track report written" }
+
+[verification]
+# Acceptance criteria from spec.md
+vc1_get_sites_under_15 = false  # actual: 26
+vc2_subscript_under_20 = false  # actual: 79
+vc3_per_phase_guard = true
+vc4_codepaths_drop = "not_measured"  # required metric computation deferred
+vc5_audit_gates_pass = true  # 7/7
+vc6_batched_tests_pass = "partial"  # 7/11 PASS; 4 had failures (1 my regression fixed; 3 pre-existing or fragile)
+vc7_collapsed_codepath_audit = true  # docs/reports/collapsed_codepath_audit_20260626.md
+vc8_no_noop_classifications = true
+vc9_no_parallel_dataclasses = true
+vc10_per_site_type_checks = true
+
+[regressions]
+# 2 regressions introduced by my changes; both fixed
+fixed = [
+    { sha = "f6d58ddb", issue = "NameError: MMAUsageStats in gui_2.py:6621", tests = "test_mma_approval_indicators" },
+    { sha = "fc5f80ae", issue = "TypeError: isinstance arg 2 (FileItem TypeAlias shadow)", tests = "test_qwen_provider" },
+]
+
+[blocked]
+phase_7 = {
+    description = "MCPToolResult + ContentBlock dataclasses don't exist",
+    sites = ["src/mcp_client.py:1707", "src/mcp_client.py:1708", "src/mcp_client.py:1714"],
+    resolution = "Separate track to introduce MCPToolResult + ContentBlock in src/mcp_client.py",
+}
+
+[artifacts]
+audit_doc = "docs/reports/collapsed_codepath_audit_20260626.md"
+completion_report = "docs/reports/TRACK_COMPLETION_type_alias_unfuck_20260626.md"
+batched_results = "tests/artifacts/tier2_state/type_alias_unfuck_20260626/batched_results.txt"
+failcount_state = "tests/artifacts/tier2_state/type_alias_unfuck_20260626/state.json"