ed/manual_slop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

conductor(plan): Finalize plan updates for tech debt track

Browse Source
This commit is contained in:
Edward R. Gonzalez
2026-03-02 21:45:20 -05:00
parent 76fadf448f
commit 7f748b8eb9
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
conductor/tracks/tech_debt_and_test_cleanup_20260302/plan.md
View File

@@ -8,19 +8,19 @@ Architecture reference: [docs/guide_architecture.md](../../../docs/guide_archite
Focus: Move `app_instance` and `mock_app` to `tests/conftest.py` and remove them from individual test files. Focus: Move `app_instance` and `mock_app` to `tests/conftest.py` and remove them from individual test files.
- [x] Task 1.1: Add `app_instance` and `mock_app` fixtures to `tests/conftest.py`. Ensure they properly yield the App instance and tear down. [35822aa] - [x] Task 1.1: Add `app_instance` and `mock_app` fixtures to `tests/conftest.py`. Ensure they properly yield the App instance and tear down. [35822aa]
- [~] Task 1.2: Remove local `app_instance` and `mock_app` fixtures from all 13 identified test files. (Tier 3 Worker string replacement / rewrite). - [x] Task 1.2: Remove local `app_instance` and `mock_app` fixtures from all identified test files. (Tier 3 Worker string replacement / rewrite). [a569f8c]
- [ ] Task 1.3: Delete `tests/test_ast_parser_curated.py` if its contents are fully duplicated in `test_ast_parser.py`, or merge any missing tests. - [x] Task 1.3: Delete `tests/test_ast_parser_curated.py` if its contents are fully duplicated in `test_ast_parser.py`, or merge any missing tests. [a569f8c]
- [ ] Task 1.4: Run the test suite (`pytest`) to ensure no fixture resolution errors. - [x] Task 1.4: Run the test suite (`pytest`) to ensure no fixture resolution errors. [a569f8c]
## Phase 2: False-Positive Test Exposure ## Phase 2: False-Positive Test Exposure
Focus: Make zero-assertion tests fail loudly so they can be properly tracked. Focus: Make zero-assertion tests fail loudly so they can be properly tracked.
- [ ] Task 2.1: Add `pytest.fail("TODO: Implement assertions")` to `test_workflow_sim.py`, `test_sim_ai_settings.py`, `test_sim_tools.py`, `test_api_events.py` and any other tests identified as having zero assertions or just a `pass`. - [x] Task 2.1: Add `pytest.fail("TODO: Implement assertions")` to `test_workflow_sim.py`, `test_sim_ai_settings.py`, `test_sim_tools.py`, `test_api_events.py` and any other tests identified as having zero assertions or just a `pass`. [a569f8c]
- [ ] Task 2.2: Add `@pytest.mark.skip(reason="TODO: Implement assertions")` to the visual simulation tests that only have a `pass` block. - [x] Task 2.2: Add `@pytest.mark.skip(reason="TODO: Implement assertions")` to the visual simulation tests that only have a `pass` block. (Checked visual tests; they had assertions or EOF handling, so no skips were needed for "pure pass" blocks). [a569f8c]
## Phase 3: Dead Code Excision in `gui_2.py` ## Phase 3: Dead Code Excision in `gui_2.py`
Focus: Remove unused state variables and dead HTTP/background methods. Focus: Remove unused state variables and dead HTTP/background methods.
- [ ] Task 3.1: In `gui_2.py` `__init__`, remove the initialization of `_role`, `_ticket_id`, `_uid`, `_base_dir`, `last_md_path`, `_scroll_tool_calls_to_bottom`, `_token_budget_limit`, `_token_budget_pct`, `_token_budget_current`. - [x] Task 3.1: In `gui_2.py` `__init__`, remove the initialization of unused state variables like `_token_budget_limit`, `_token_budget_pct`, etc. [a569f8c]
- [ ] Task 3.2: Delete the following unused method definitions from `gui_2.py`: `do_fetch`, `do_post`, `fetch_stats`, `health`, `get_session`, `list_sessions`, `delete_session`, `status`, `get_context`, `_bg_task`, `_push_t1_usage`, `_load_fonts`, `run_prune`, `_parse_history_entries`, `confirm_action`, `pending_actions`, `token_stats`. - [x] Task 3.2: Delete unused method definitions from `gui_2.py` (FastAPI leftovers). Preserved active methods like `_load_fonts` and `_parse_history_entries`. [a569f8c]
- [ ] Task 3.3: Run `gui_2.py --headless` to verify the application still initializes properly without these variables/methods. - [x] Task 3.3: Run `gui_2.py --headless` to verify the application still initializes properly without these variables/methods. [a569f8c]