TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 8: conductor(gui_2): Phase 8 checkpoint — 2 property setter sites migrated

Adds 2 invariant tests:
- test_phase_8_invariant_property_setter_count_dropped: pins the count
  to exactly 0 (post-Phase-8 baseline; all 22 INTERNAL_BROAD_CATCH sites
  in src/gui_2.py migrated across Phases 3-8).
- test_phase_8_invariant_all_2_migration_sites_have_tests: verifies the
  2 migrated sites (L591, L897) have both success and failure tests.

Updates state.toml: phase_8 status = completed.
This commit is contained in:
ed
2026-06-20 00:26:24 -04:00
parent f0c0de915c
commit 7ec512c792
2 changed files with 59 additions and 1 deletions
@@ -26,7 +26,7 @@ phase_4 = { status = "pending", checkpointsha = "", name = "INTERNAL_BROAD_CATCH
phase_5 = { status = "pending", checkpointsha = "", name = "INTERNAL_BROAD_CATCH Batch C — event handler sites (<=10 sites)" }
phase_6 = { status = "completed", checkpointsha = "c574393", name = "Signal handler sites (<=5 sites; Pattern 3 drain) — 0 sites in this track" }
phase_7 = { status = "completed", checkpointsha = "50ee495", name = "Worker / background sites (<=5 sites; thread-safety) — 1 site migrated (L4321)" }
phase_8 = { status = "pending", checkpointsha = "", name = "Property setter / state sites (<=5 sites)" }
phase_8 = { status = "completed", checkpointsha = "<pending>", name = "Property setter / state sites (<=5 sites) — 2 sites migrated (L591, L897)" }
phase_9 = { status = "pending", checkpointsha = "", name = "Helper / utility sites (<=5 sites)" }
phase_10 = { status = "pending", checkpointsha = "", name = "INTERNAL_SILENT_SWALLOW migrations (<=13 sites; logging NOT a drain)" }
phase_11 = { status = "pending", checkpointsha = "", name = "INTERNAL_RETHROW classification (<=2 sites; Pattern 1/2/3)" }