ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

conductor(test-fix): fix_test_failures_20260624 - make the 14 post-polish failures green

Browse Source 
3 surgical fixes:
1. src/openai_schemas.py: add custom __init__ to NormalizedResponse
   that accepts BOTH the new nested usage: UsageStats AND the legacy
   flat usage_input_tokens=... kwargs. Fixes 12 of the 14 failing tests
   in one place (no test changes needed).
2. tests/test_auto_whitelist.py: use dataclasses.replace() instead of
   mutating a frozen Session via dict assignment.
3. tests/test_command_palette_sim.py: use a deterministic close callback
   (or push toggle twice as fallback) instead of the non-deterministic
   _toggle_command_palette callback.

4 phases, 4 tasks, 6 atomic commits expected. Verification: full
scripts/run_tests_batched.py is green; 4 audit gates remain clean;
no new failures introduced.
This commit is contained in:
ed
2026-06-24 10:48:04 -04:00
parent ca21916304
commit 7a9261c425
4 changed files with 335 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
conductor/tracks/fix_test_failures_20260624/state.toml
+39
View File
@@ -0,0 +1,39 @@
# Track state for fix_test_failures_20260624
# 3 surgical fixes for 14 post-polish-merge test failures.
# 4 phases, 4 tasks. Tier 2 to execute per conductor/workflow.md.
[meta]
track_id = "fix_test_failures_20260624"
name = "Fix 14 Test Failures (post-polish merge)"
status = "active"
current_phase = 0
last_updated = "2026-06-24"
[parent]
# Follow-up to code_path_audit_polish_20260622 (merged)
[blocked_by]
code_path_audit_polish_20260622 = "merged"
[blocks]
# This track blocks nothing. It is a test-fix task.
[phases]
phase_1 = { status = "pending", checkpointsha = "", name = "NormalizedResponse dual-signature __init__" }
phase_2 = { status = "pending", checkpointsha = "", name = "Session frozen fix in test_auto_whitelist" }
phase_3 = { status = "pending", checkpointsha = "", name = "Toggle race fix in test_palette_starts_hidden" }
phase_4 = { status = "pending", checkpointsha = "", name = "Verification + End-of-Track Report" }
[tasks]
t1_1 = { status = "pending", commit_sha = "", description = "Add custom __init__ to NormalizedResponse accepting both nested usage: UsageStats and legacy flat usage_input_tokens=... kwargs" }
t2_1 = { status = "pending", commit_sha = "", description = "Update test_auto_whitelist_keywords to use dataclasses.replace for frozen Session mutation" }
t3_1 = { status = "pending", commit_sha = "", description = "Update test_palette_starts_hidden to use deterministic close callback instead of non-deterministic toggle" }
t4_1 = { status = "pending", commit_sha = "", description = "Run all 6 VCs; write TRACK_COMPLETION report; update this state.toml + conductor/tracks.md" }
[verification]
vc1_normalized_response_tests_pass = false
vc2_auto_whitelist_test_passes = false
vc3_palette_starts_hidden_test_passes = false
vc4_full_batched_suite_green = false
vc5_audit_gates_clean = false
vc6_no_new_test_failures = false