ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

fix(sim+api): proper wait loops, project switch endpoint, drop stale check

Browse Source 
Three real fixes for the sim test + the live_gui coordination layer:

1. /api/project_switch_status endpoint in src/app_controller.py.
   The wait helper had been calling this endpoint but it did not exist;
   the helper always received a 404, fell back to {in_progress: False},
   and returned immediately even when a switch was in flight. Added the
   endpoint that reads _project_switch_in_progress, active_project_path,
   and _project_switch_error from the controller.

2. simulation/sim_base.py: replace time.sleep(2.0)/time.sleep(1.5) in
   the setup() with wait_io_pool_idle and wait_for_project_switch so
   the test does not click btn_md_only while a project switch is in
   flight. Also added the wait calls to sim_context.py for the same
   reason.

3. src/app_controller.py _handle_md_only: removed the is_project_stale()
   early-return. The stale state is a transient window during which the
   previous code dropped the click on the floor with a misleading
   'stale ui' status. The MD generation worker is safe to run from any
   project state; the action handler now always proceeds.

4. tests/test_extended_sims.py: set current_model to 'gemini-cli' so
   _do_generate does not raise KeyError('model') when the test
   overrides provider to gemini_cli.

KNOWN ISSUE: test_context_sim_live still fails with status
'switching to: temp_livecontextsim' after a 60s wait. The click
appears to be re-triggering a project switch via the GUI's render
loop. Root cause investigation deferred; the sim is async and the
test path is fragile.
This commit is contained in:
Edward R. Gonzalez
2026-06-10 00:31:22 -04:00
parent 33d02bb11f
commit 72f8f466fe
5 changed files with 90 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
simulation/sim_base.py
+10 -2
View File
@@ -78,17 +78,25 @@ class BaseSimulation:
time.sleep(0.1)
print("[BaseSim] Resetting session...")
self.client.click("btn_reset")
time.sleep(2.0)
# Wait for the reset to fully complete (session reset is async via io_pool).
self.client.wait_io_pool_idle(timeout=10.0)
git_dir = os.path.abspath(".")
self.project_path = os.path.abspath(f"tests/artifacts/temp_{project_name.lower()}.toml")
if os.path.exists(self.project_path):
os.remove(self.project_path)
print(f"[BaseSim] Scaffolding Project: {project_name}")
self.sim.setup_new_project(project_name, git_dir, self.project_path)
# CRITICAL: wait for the project switch to fully complete. The switch
# is async via the ProjectSwitchState machine, NOT the io_pool, so
# wait_io_pool_idle does not suffice. Without this wait, subsequent
# clicks like btn_md_only hit the "is_project_stale" early-return and
# the test fails with a misleading "stale ui" status.
self.client.wait_for_project_switch(expected_path=self.project_path, timeout=30.0)
# Standard test settings
self.client.set_value("current_provider", "gemini")
self.client.set_value("current_model", "gemini-2.5-flash-lite")
time.sleep(1.5)
self.client.wait_io_pool_idle(timeout=10.0)
self.client.wait_io_pool_idle(timeout=10.0)
def teardown(self) -> None:
"""