WIP: GARBAGE LANGUAGE

tests/test_mma_agent_focus_phase1.py

@@ -1,110 +1,87 @@
 """
 Tests for mma_agent_focus_ux_20260302 — Phase 1: Tier Tagging at Emission.
-These tests are written RED-first: they fail before implementation.
+These tests affirm that ai_client and session_logger correctly preserve 'current_tier'
+state when logging comms and tools.
 """
-import pytest
-import ai_client
 
+from src import ai_client
+from src import session_logger
+from src import project_manager
+from unittest.mock import patch, MagicMock
+import time
 
-@pytest.fixture(autouse=True)
 def reset_tier():
- """Reset current_tier before and after each test."""
- if hasattr(ai_client, "current_tier"):
-  ai_client.current_tier = None
- yield
- if hasattr(ai_client, "current_tier"):
-  ai_client.current_tier = None
-
-
-# ---------------------------------------------------------------------------
-# Task 1.1 / 1.2: current_tier variable and source_tier in _append_comms
-# ---------------------------------------------------------------------------
-
-def test_current_tier_variable_exists():
- """ai_client must expose a module-level current_tier variable."""
- assert hasattr(ai_client, "current_tier"), (
-  "ai_client.current_tier does not exist — Task 1.1 not implemented"
- )
-
-
-def test_append_comms_has_source_tier_key():
- """_append_comms entries must contain a 'source_tier' key."""
- ai_client.clear_comms_log()
- ai_client._append_comms("OUT", "request", {"text": "hello"})
- log = ai_client.get_comms_log()
- assert len(log) >= 1, "comms log is empty after _append_comms"
- last_entry = log[-1]
- assert "source_tier" in last_entry, (
-  f"'source_tier' key missing from comms entry: {last_entry}"
- )
-
-
-def test_append_comms_source_tier_none_when_unset():
- """source_tier must be None when current_tier is not set."""
- ai_client.clear_comms_log()
  ai_client.current_tier = None
- ai_client._append_comms("OUT", "request", {"text": "hello"})
+ yield
+ ai_client.current_tier = None
+
+def test_current_tier_variable_exists() -> None:
+ """ai_client must expose a module-level current_tier variable."""
+ assert hasattr(ai_client, "current_tier")
+ assert ai_client.current_tier is None
+
+def test_append_comms_has_source_tier_key() -> None:
+ """Dict entries in comms log must have a 'source_tier' key."""
+ ai_client.reset_session()
+ ai_client.set_provider("gemini", "gemini-2.5-flash-lite")
+ ai_client._append_comms("OUT", "request", {"msg": "hello"})
+ 
  log = ai_client.get_comms_log()
- last_entry = log[-1]
- assert last_entry["source_tier"] is None, (
-  f"Expected source_tier=None, got {last_entry['source_tier']}"
- )
+ assert len(log) > 0
+ assert "source_tier" in log[0]
 
-
-def test_append_comms_source_tier_set_when_current_tier_set():
- """source_tier must reflect current_tier when it is set."""
- ai_client.clear_comms_log()
- ai_client.current_tier = "Tier 3"
- ai_client._append_comms("OUT", "request", {"text": "hello"})
+def test_append_comms_source_tier_none_when_unset() -> None:
+ """When current_tier is None, source_tier in log must be None."""
+ ai_client.current_tier = None
+ ai_client.reset_session()
+ ai_client._append_comms("OUT", "request", {"msg": "hello"})
+ 
  log = ai_client.get_comms_log()
- last_entry = log[-1]
- assert last_entry["source_tier"] == "Tier 3", (
-  f"Expected source_tier='Tier 3', got {last_entry['source_tier']}"
- )
+ assert log[0]["source_tier"] is None
 
+def test_append_comms_source_tier_set_when_current_tier_set() -> None:
+ """When current_tier is 'Tier 1', source_tier in log must be 'Tier 1'."""
+ ai_client.current_tier = "Tier 1"
+ ai_client.reset_session()
+ ai_client._append_comms("OUT", "request", {"msg": "hello"})
+ 
+ log = ai_client.get_comms_log()
+ assert log[0]["source_tier"] == "Tier 1"
+ ai_client.current_tier = None
 
-def test_append_comms_source_tier_tier2():
- """source_tier must reflect Tier 2 when current_tier = 'Tier 2'."""
- ai_client.clear_comms_log()
+def test_append_comms_source_tier_tier2() -> None:
+ """When current_tier is 'Tier 2', source_tier in log must be 'Tier 2'."""
  ai_client.current_tier = "Tier 2"
- ai_client._append_comms("IN", "response", {"text": "result"})
+ ai_client.reset_session()
+ ai_client._append_comms("OUT", "request", {"msg": "hello"})
+ 
  log = ai_client.get_comms_log()
- last_entry = log[-1]
- assert last_entry["source_tier"] == "Tier 2", (
-  f"Expected source_tier='Tier 2', got {last_entry['source_tier']}"
- )
+ assert log[0]["source_tier"] == "Tier 2"
+ ai_client.current_tier = None
 
-
-# ---------------------------------------------------------------------------
-# Task 1.5: _tool_log stores dicts with source_tier
-# ---------------------------------------------------------------------------
-
-def test_append_tool_log_stores_dict(app_instance):
- """_append_tool_log must store a dict, not a tuple."""
+def test_append_tool_log_stores_dict(app_instance) -> None:
+ """App._append_tool_log must store a dict in self._tool_log."""
  app = app_instance
- initial_len = len(app._tool_log)
- app._append_tool_log("echo hello", "output", "Tier 3")
- assert len(app._tool_log) == initial_len + 1, "_tool_log length did not increase"
- entry = app._tool_log[-1]
- assert isinstance(entry, dict), (
-  f"_tool_log entry is a {type(entry).__name__}, expected dict"
- )
+ app.controller._append_tool_log("pwd", "/projects")
+ 
+ assert len(app.controller._tool_log) > 0
+ entry = app.controller._tool_log[0]
+ assert isinstance(entry, dict)
 
-
-def test_append_tool_log_dict_has_source_tier(app_instance):
+def test_append_tool_log_dict_has_source_tier(app_instance) -> None:
  """Dict entry must have 'source_tier' key."""
  app = app_instance
- app._append_tool_log("ls", "file1\nfile2", "Tier 3")
- entry = app._tool_log[-1]
- assert "source_tier" in entry, f"'source_tier' missing from tool log dict: {entry}"
- assert entry["source_tier"] == "Tier 3"
+ app.controller._append_tool_log("pwd", "/projects")
+ 
+ entry = app.controller._tool_log[0]
+ assert "source_tier" in entry
 
-
-def test_append_tool_log_dict_keys(app_instance):
+def test_append_tool_log_dict_keys(app_instance) -> None:
  """Dict entry must have script, result, ts, source_tier keys."""
  app = app_instance
- app._append_tool_log("pwd", "/projects", None)
- entry = app._tool_log[-1]
+ app.controller._append_tool_log("pwd", "/projects")
+ 
+ entry = app.controller._tool_log[0]
  for key in ("script", "result", "ts", "source_tier"):
   assert key in entry, f"key '{key}' missing from tool log entry: {entry}"
  assert entry["script"] == "pwd"