chore(conductor): Update test stabilization track based on deep audit
This commit is contained in:
@@ -15,16 +15,22 @@
|
|||||||
- [ ] Task: Resolve `Event loop is closed` in Core Test Suite
|
- [ ] Task: Resolve `Event loop is closed` in Core Test Suite
|
||||||
- [ ] Update identified files to pass active loops and use `ThreadPoolExecutor`.
|
- [ ] Update identified files to pass active loops and use `ThreadPoolExecutor`.
|
||||||
- [ ] Task: Implement Centralized Sectioned Logging Utility
|
- [ ] Task: Implement Centralized Sectioned Logging Utility
|
||||||
|
- [ ] Route `VerificationLogger` output to `./tests/logs/`.
|
||||||
- [ ] Task: Conductor - User Manual Verification 'Phase 2: Asyncio & Logging' (Protocol in workflow.md)
|
- [ ] Task: Conductor - User Manual Verification 'Phase 2: Asyncio & Logging' (Protocol in workflow.md)
|
||||||
|
|
||||||
## Phase 3: Assertion Implementation & Simulation Fixes
|
## Phase 3: Assertion Implementation & Legacy Cleanup
|
||||||
- [ ] Task: Replace `pytest.fail` with Functional Assertions
|
- [ ] Task: Replace `pytest.fail` with Functional Assertions
|
||||||
- [ ] Focus on `api_events`, `execution_engine`, `token_usage`, and `agent_capabilities`.
|
- [ ] Focus on `api_events`, `execution_engine`, `token_usage`, and `agent_capabilities`.
|
||||||
- [ ] Task: Resolve Simulation Entry Count Regressions
|
- [ ] Task: Resolve Simulation Entry Count Regressions
|
||||||
- [ ] Fix entry count assertions in `test_context_sim_live` and align mocks.
|
- [ ] Fix entry count assertions in `test_context_sim_live` and align mocks.
|
||||||
- [ ] Task: Conductor - User Manual Verification 'Phase 3: Assertions & Sims' (Protocol in workflow.md)
|
- [ ] Task: Remove Legacy `gui_legacy` Test Imports
|
||||||
|
- [ ] Refactor `tests/test_gui_events.py`, `test_gui_updates.py`, and `test_gui_diagnostics.py` to use `gui_2.py`.
|
||||||
|
- [ ] Task: Conductor - User Manual Verification 'Phase 3: Assertions & Legacy Cleanup' (Protocol in workflow.md)
|
||||||
|
|
||||||
## Phase 4: Final Verification & Artifact Audit
|
## Phase 4: Documentation & Final Verification
|
||||||
|
- [ ] Task: Update Core Documentation
|
||||||
|
- [ ] Update `Readme.md` regarding the test framework and artifact/log locations.
|
||||||
|
- [ ] Update `docs/guide_simulations.md` to detail the `live_gui` fixture requirement and removal of manual simulation scripts.
|
||||||
- [ ] Task: Full Suite Validation & Warning Cleanup
|
- [ ] Task: Full Suite Validation & Warning Cleanup
|
||||||
- [ ] Task: Final Artifact Isolation Verification
|
- [ ] Task: Final Artifact Isolation Verification
|
||||||
- [ ] Task: Conductor - User Manual Verification 'Phase 4: Final Verification' (Protocol in workflow.md)
|
- [ ] Task: Conductor - User Manual Verification 'Phase 4: Documentation & Final Verification' (Protocol in workflow.md)
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
# Specification: Test Suite Stabilization & Consolidation (test_stabilization_20260302)
|
# Specification: Test Suite Stabilization & Consolidation (test_stabilization_20260302)
|
||||||
|
|
||||||
## Overview
|
## Overview
|
||||||
The goal of this track is to stabilize and unify the project's test suite. This involves resolving pervasive `asyncio` lifecycle errors, consolidating redundant testing paradigms (specifically manual GUI subprocesses), ensuring artifact isolation in `./tests/artifacts/`, and implementing functional assertions for currently mocked-out tests.
|
The goal of this track is to stabilize and unify the project's test suite. This involves resolving pervasive `asyncio` lifecycle errors, consolidating redundant testing paradigms (specifically manual GUI subprocesses), ensuring artifact isolation in `./tests/artifacts/`, implementing functional assertions for currently mocked-out tests, and updating documentation to reflect the finalized verification framework.
|
||||||
|
|
||||||
## Functional Requirements
|
## Functional Requirements
|
||||||
- **Asyncio Lifecycle Stabilization:**
|
- **Asyncio Lifecycle Stabilization:**
|
||||||
@@ -11,19 +11,25 @@ The goal of this track is to stabilize and unify the project's test suite. This
|
|||||||
- **Paradigm Consolidation (from testing_consolidation_20260302):**
|
- **Paradigm Consolidation (from testing_consolidation_20260302):**
|
||||||
- Refactor integration/visual tests to exclusively use the `live_gui` pytest fixture.
|
- Refactor integration/visual tests to exclusively use the `live_gui` pytest fixture.
|
||||||
- Eliminate all manual `subprocess.Popen` calls to `gui_2.py` in the `tests/` and `simulation/` directories.
|
- Eliminate all manual `subprocess.Popen` calls to `gui_2.py` in the `tests/` and `simulation/` directories.
|
||||||
|
- Update legacy tests (e.g., `test_gui_events.py`, `test_gui_diagnostics.py`) that still import the deprecated `gui_legacy.py` to use `gui_2.py`.
|
||||||
- **Artifact Isolation & Discipline:**
|
- **Artifact Isolation & Discipline:**
|
||||||
- All test-generated files (temporary projects, mocks, sessions) MUST be isolated in `./tests/artifacts/`.
|
- All test-generated files (temporary projects, mocks, sessions) MUST be isolated in `./tests/artifacts/`.
|
||||||
- Prevent leakage into `conductor/tracks/` or project root.
|
- Prevent leakage into `conductor/tracks/` or project root.
|
||||||
- **Enhanced Test Reporting:**
|
- **Enhanced Test Reporting:**
|
||||||
- Implement structured, sectioned logging in `./tests/logs/` with timestamps.
|
- Implement structured, sectioned logging in `./tests/logs/` with timestamps (consolidating `VerificationLogger` outputs).
|
||||||
- **Assertion Implementation:**
|
- **Assertion Implementation:**
|
||||||
- Replace `pytest.fail` placeholders with full functional implementation.
|
- Replace `pytest.fail` placeholders with full functional implementation.
|
||||||
- **Simulation Regression Fixes:**
|
- **Simulation Regression Fixes:**
|
||||||
- Debug and resolve `test_context_sim_live` entry count issues.
|
- Debug and resolve `test_context_sim_live` entry count issues.
|
||||||
|
- **Documentation Updates:**
|
||||||
|
- Update `Readme.md` (Testing section) to explain the new log/artifact locations and the `--enable-test-hooks` requirement.
|
||||||
|
- Update `docs/guide_simulations.md` to document the centralized `pytest` usage instead of standalone simulator scripts.
|
||||||
|
|
||||||
## Acceptance Criteria
|
## Acceptance Criteria
|
||||||
- [ ] Full suite run completes without `RuntimeError: Event loop is closed` warnings.
|
- [ ] Full suite run completes without `RuntimeError: Event loop is closed` warnings.
|
||||||
- [ ] No `subprocess.Popen` calls to `gui_2.py` exist in the test codebase.
|
- [ ] No `subprocess.Popen` calls to `gui_2.py` exist in the test codebase.
|
||||||
|
- [ ] No test files import `gui_legacy.py`.
|
||||||
- [ ] All test artifacts are isolated in `./tests/artifacts/`.
|
- [ ] All test artifacts are isolated in `./tests/artifacts/`.
|
||||||
- [ ] All tests previously marked with `pytest.fail` now have passing functional assertions.
|
- [ ] All tests previously marked with `pytest.fail` now have passing functional assertions.
|
||||||
- [ ] Simulation tests pass with correct entry counts.
|
- [ ] Simulation tests pass with correct entry counts.
|
||||||
|
- [ ] `Readme.md` and `docs/guide_simulations.md` accurately reflect the new testing infrastructure.
|
||||||
|
|||||||
Reference in New Issue
Block a user