refactor(gui): redesign persona editor UI and replace popup modals with standard windows

tests/test_persona_manager.py

@@ -59,7 +59,7 @@ def test_load_all_merged(temp_paths):
 
 def test_save_persona(temp_paths):
  manager = PersonaManager(project_root=temp_paths["project_root"])
- persona = Persona(name="New", provider="gemini", system_prompt="Test")
+ persona = Persona(name="New", preferred_models=[{"provider": "gemini"}], system_prompt="Test")
  
  manager.save_persona(persona, scope="project")
  loaded = manager.load_all()

tests/test_persona_models.py

@@ -4,30 +4,38 @@ from src.models import Persona
 def test_persona_serialization():
  persona = Persona(
   name="SecuritySpecialist",
-  provider="anthropic",
-  model="claude-3-7-sonnet-20250219",
-  preferred_models=["claude-3-7-sonnet-20250219", "claude-3-5-sonnet-20241022"],
+  preferred_models=[
+   {"provider": "anthropic", "model": "claude-3-7-sonnet-20250219", "temperature": 0.2, "top_p": 0.9, "max_output_tokens": 4000},
+   "claude-3-5-sonnet-20241022"
+  ],
   system_prompt="You are a security expert.",
-  temperature=0.2,
-  top_p=0.9,
-  max_output_tokens=4000,
   tool_preset="SecurityTools",
   bias_profile="Execution-Focused"
  )
  
+ assert persona.provider == "anthropic"
+ assert persona.model == "claude-3-7-sonnet-20250219"
+ assert persona.temperature == 0.2
+ assert persona.top_p == 0.9
+ assert persona.max_output_tokens == 4000
+
  data = persona.to_dict()
  
- assert data["provider"] == "anthropic"
- assert data["model"] == "claude-3-7-sonnet-20250219"
- assert "claude-3-5-sonnet-20241022" in data["preferred_models"]
+ # data should NOT have top-level provider/model anymore, it's in preferred_models
+ assert "provider" not in data
+ assert "model" not in data
+ assert data["preferred_models"][0]["provider"] == "anthropic"
+ assert data["preferred_models"][0]["model"] == "claude-3-7-sonnet-20250219"
+ assert data["preferred_models"][1] == {"model": "claude-3-5-sonnet-20241022"}
  assert data["system_prompt"] == "You are a security expert."
- assert data["temperature"] == 0.2
- assert data["top_p"] == 0.9
- assert data["max_output_tokens"] == 4000
+ assert data["preferred_models"][0]["temperature"] == 0.2
+ assert data["preferred_models"][0]["top_p"] == 0.9
+ assert data["preferred_models"][0]["max_output_tokens"] == 4000
  assert data["tool_preset"] == "SecurityTools"
  assert data["bias_profile"] == "Execution-Focused"
 
 def test_persona_deserialization():
+ # Old config format (legacy)
  data = {
   "provider": "gemini",
   "model": "gemini-2.5-flash",
@@ -45,7 +53,9 @@ def test_persona_deserialization():
  assert persona.name == "Assistant"
  assert persona.provider == "gemini"
  assert persona.model == "gemini-2.5-flash"
- assert persona.preferred_models == ["gemini-2.5-flash"]
+ # Migration logic should have put legacy fields into preferred_models since it only had a string
+ assert persona.preferred_models[0]["provider"] == "gemini"
+ assert persona.preferred_models[0]["model"] == "gemini-2.5-flash"
  assert persona.system_prompt == "You are a helpful assistant."
  assert persona.temperature == 0.5
  assert persona.top_p == 1.0