TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 9: conductor(gui_2): Phase 9 checkpoint — 0 helper/utility sites in this track

Adds 2 invariant tests:
- test_phase_9_invariant_helper_utility_count_dropped: pins the count
  to exactly 0 (post-Phase-9 baseline; no Phase 9 sites, count should
  remain 0 after Phases 7-8 dropped it).
- test_phase_9_invariant_zero_sites_in_phase_9: documents that no
  Phase 9 site tests exist (machine-checkable: future agent adding a
  Phase 9 site will see this test fail at the count assertion).

Per PHASE1_SITE_INVENTORY.md, the one Phase 9 site (L1398 _close_vscode_diff)
is INTERNAL_SILENT_SWALLOW (the bare-except classification) and will be
handled in Phase 10 (logging NOT a drain per the convention).

Updates state.toml: phase_9 status = completed.
This commit is contained in:
ed
2026-06-20 00:27:30 -04:00
parent 26b8503f3d
commit 6b02f49253
2 changed files with 71 additions and 1 deletions
@@ -27,7 +27,7 @@ phase_5 = { status = "pending", checkpointsha = "", name = "INTERNAL_BROAD_CATCH
phase_6 = { status = "completed", checkpointsha = "c574393", name = "Signal handler sites (<=5 sites; Pattern 3 drain) — 0 sites in this track" }
phase_7 = { status = "completed", checkpointsha = "50ee495", name = "Worker / background sites (<=5 sites; thread-safety) — 1 site migrated (L4321)" }
phase_8 = { status = "completed", checkpointsha = "7ec512c", name = "Property setter / state sites (<=5 sites) — 2 sites migrated (L591, L897)" }
phase_9 = { status = "pending", checkpointsha = "", name = "Helper / utility sites (<=5 sites)" }
phase_9 = { status = "completed", checkpointsha = "<pending>", name = "Helper / utility sites (<=5 sites) — 0 sites in this track (L1398 is SILENT_SWALLOW, Phase 10)" }
phase_10 = { status = "pending", checkpointsha = "", name = "INTERNAL_SILENT_SWALLOW migrations (<=13 sites; logging NOT a drain)" }
phase_11 = { status = "pending", checkpointsha = "", name = "INTERNAL_RETHROW classification (<=2 sites; Pattern 1/2/3)" }
phase_12 = { status = "pending", checkpointsha = "", name = "UNCLEAR classification (<=2 sites)" }