Private
Public Access
0
0

chore: TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 0

Acknowledged the styleguide re-read per the AI Agent Checklist Rule #0.
Key points internalized for sub-track 4 (gui_2.py migration):

1. The 5 drain point patterns (error_handling.md:356-516):
   - Pattern 1: HTTP error response (FastAPI)
   - Pattern 2: GUI error display (imgui.open_popup) - PRIME for gui_2.py
   - Pattern 3: Intentional app termination (sys.exit)
   - Pattern 4: Telemetry emission
   - Pattern 5: Bounded retry

2. INTERNAL_SILENT_SWALLOW (lines 462-540): logging is NOT a drain.
   Per the user's principle (2026-06-17), narrow+log bodies in the
   13 SILENT_SWALLOW sites in gui_2.py MUST be migrated to full
   Result[T] propagation, NOT narrowed.

3. INTERNAL_BROAD_CATCH (lines 520-583): non-*_result code with
   except Exception must be converted to a _result helper that
   returns Result[T] with errors=[ErrorInfo(...)].

4. INTERNAL_RETHROW (lines 625-693): 3 legitimate patterns:
   - Pattern 1: catch + convert + raise as different type
   - Pattern 2: catch + log + re-raise
   - Pattern 3: catch + cleanup + re-raise

5. AI Agent Checklist 5 MUST-DO + 7 MUST-NOT-DO rules
   internalized; --strict gate (audit_exception_handling.py
   --strict) is the CI enforcement.
This commit is contained in:
2026-06-19 20:57:18 -04:00
parent bf94fb2b07
commit 62188d6b0c

Diff Content Not Available