ed/manual_slop
Private
Public Access
0
0
Fork 0
Code Activity

TIER-2 READ conductor/code_styleguides/error_handling.md end-to-end before Phase 5: refactor(gui_2): migrate L5380 render_operations_hub ext_editor_panel to Result[T] (Phase 5)

Browse Source 
Extract _render_operations_hub_external_editor_panel_result helper from the
render_external_editor_panel call try/except in render_operations_hub
External Tools tab. Legacy wrapper drains errors to app._last_request_errors
per FR-BC-4 event-handler pattern.

[pre-audit] L5380 INTERNAL_BROAD_CATCH
[post-audit] V count: 7 -> 6 (L5380 removed)
This commit is contained in:
ed
2026-06-19 23:59:08 -04:00
parent f1cdc926cf
commit 6119143400
2 changed files with 65 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gui_2.py
+30 -2
View File
@@ -5333,8 +5333,11 @@ def render_operations_hub(app: App) -> None:
if exp:
render_external_tools_panel(app)
imgui.separator(); imgui.text("")
try: render_external_editor_panel(app)
except Exception as e: imgui.text_colored(theme.get_color("status_error"), f"Error: {str(e)}")
ext_panel_result = _render_operations_hub_external_editor_panel_result(app)
if not ext_panel_result.ok:
if not hasattr(app, '_last_request_errors'): app._last_request_errors = []
app._last_request_errors.append(("_render_operations_hub_external_editor_panel", ext_panel_result.errors[0]))
imgui.text_colored(theme.get_color("status_error"), f"Error: {ext_panel_result.errors[0].message}")
with imscope.tab_item("Workspace Layouts") as (exp, _):
if exp:
imgui.text("Experimental: Auto-switch layout by Tier")
@@ -7960,6 +7963,31 @@ def _render_context_batch_actions_preview_result(app: "App") -> Result[str]:
original=e,
)])
def _render_operations_hub_external_editor_panel_result(app: "App") -> Result[bool]:
"""Drain-aware variant of L5380 render_operations_hub External Tools tab.
Extracts the render_external_editor_panel call try/except from
render_operations_hub External Tools tab into a Result-returning helper.
On success, returns Result(data=True). On exception, converts the
exception to ErrorInfo and returns Result(data=False, errors=[ErrorInfo]).
The legacy wrapper drains errors to app._last_request_errors (per FR-BC-4
event-handler drain pattern; data plane attribute).
[C: src/gui_2.py:render_operations_hub (L5380 legacy wrapper)]
"""
try:
render_external_editor_panel(app)
return Result(data=True)
except Exception as e:
return Result(data=False, errors=[ErrorInfo(
kind=ErrorKind.INTERNAL,
message=f"Render external editor panel from operations hub failed: {e}",
source="gui_2._render_operations_hub_external_editor_panel_result",
original=e,
)])
#endregion: Phase 5 Event Handler Result Helpers
#endregion: MMA