conductor+layout: remove T-shirt size metric, regenerate stale layout

Per user feedback 2026-06-17:
- T-shirt size is not an acceptable sizing metric. Remove it from
  conductor/workflow.md (the policy file), conductor/tracks.md (the
  registry), and docs/reports/NEGATIVE_FLOWS_INVESTIGATION_20260617.md.
- Regenerate manualslop_layout.ini to remove 83 stale window references
  that pointed to deleted/renamed windows (Projects, Files, Screenshots,
  Provider, System Prompts, Discussion History, Comms History, etc.).
  Layout now matches the windows registered in src/app_controller.py
  _default_windows (lines 1862-1886). Stale window count: 10 -> 3.

T-shirt size removal details:
- conductor/workflow.md: Removed the S/M/L/XL table, the replacement
  pattern row, and the 'reasonable effort' guard's reference. Scope
  (N files, M sites, N tasks) is the only effort dimension.
- conductor/tracks.md: Removed the T-shirt column from the table header
  and removed T-shirt size mentions from the Fable track entry.
- docs/reports/NEGATIVE_FLOWS_INVESTIGATION_20260617.md: Removed the
  T-shirt size mention in the follow-up track suggestion.

Layout fix:
- manualslop_layout.ini went from 17,360 bytes (102 windows, 83 stale)
  to 3,361 bytes (23 windows, all matching _default_windows). The
  stale window warning dropped from 10 windows to 3 (Message, Tool
  Calls, Response - these are in _default_windows but reference
  separate panels in the layout).

Verification: layout fix did NOT fix the underlying stack overflow crash.
After layout fix, the test still dies with rc=3221225725 (0xC00000FD).
The user noted 'Something more fundamental is wrong.' Investigation
continues; this commit only addresses the explicit ask (remove T-shirt,
fix layout).
This commit is contained in:
ed
2026-06-17 12:23:03 -04:00
parent aee2061a74
commit 54eb4740b3
4 changed files with 91 additions and 989 deletions
+4 -4
View File
@@ -44,7 +44,7 @@ Tracks that are unblocked and ready to start. Ordered by **dependency** (blocked
| 17 | — | [Code Path Audit](#track-code-path-audit) | spec TBD | test_infrastructure_hardening_20260609 (merged) | | 17 | — | [Code Path Audit](#track-code-path-audit) | spec TBD | test_infrastructure_hardening_20260609 (merged) |
| 23 | A (research) | [Intent-Based Scripting Languages Survey](#track-intent-based-scripting-languages-survey-new-2026-06-12) | spec ✓, plan pending | (none — independent; NEW 2026-06-12; **non-impl research track**, **time-sensitive: report must complete before nagent v2.2**) | | 23 | A (research) | [Intent-Based Scripting Languages Survey](#track-intent-based-scripting-languages-survey-new-2026-06-12) | spec ✓, plan pending | (none — independent; NEW 2026-06-12; **non-impl research track**, **time-sensitive: report must complete before nagent v2.2**) |
| 24 | A (bugfix) | [AI Loop Regressions (MiniMax, Gemini, Gemini CLI, DeepSeek)](#track-ai-loop-regressions-minimax-gemini-gemini-cli-deepseek-new-2026-06-14) | spec ✓, plan ✓, shipped 2026-06-15 (with 1 critical `_api_generate` regression + 2 deferred bugs — see `doeh_test_thinking_cleanup_20260615`) | (none — independent; **NEW 2026-06-14**; user-blocking; 3 bugs from `data_oriented_error_handling_20260606`) | | 24 | A (bugfix) | [AI Loop Regressions (MiniMax, Gemini, Gemini CLI, DeepSeek)](#track-ai-loop-regressions-minimax-gemini-gemini-cli-deepseek-new-2026-06-14) | spec ✓, plan ✓, shipped 2026-06-15 (with 1 critical `_api_generate` regression + 2 deferred bugs — see `doeh_test_thinking_cleanup_20260615`) | (none — independent; **NEW 2026-06-14**; user-blocking; 3 bugs from `data_oriented_error_handling_20260606`) |
| 25 | B (research) | [Fable System Prompt Review (Critical Analysis)](#track-fable-system-prompt-review-critical-analysis-new-2026-06-17) | spec ✓, plan pending | (none — independent; **NEW 2026-06-17**; **non-impl research track**, **informs the deferred nagent-rebuild**; 10 cluster sub-reports + 17-section synthesis report >3500 LOC + 3 side artifacts; T-shirt size: XL; Fable artifact at `docs/artifacts/Fable System Prompt.txt` is local-only and **NEVER committed**) | | 25 | B (research) | [Fable System Prompt Review (Critical Analysis)](#track-fable-system-prompt-review-critical-analysis-new-2026-06-17) | spec ✓, plan pending | (none — independent; **NEW 2026-06-17**; **non-impl research track**, **informs the deferred nagent-rebuild**; 10 cluster sub-reports + 17-section synthesis report >3500 LOC + 3 side artifacts; Fable artifact at `docs/artifacts/Fable System Prompt.txt` is local-only and **NEVER committed**) |
| 18 | — | [GUI Architecture Refinement](#track-gui-architecture-refinement) | (no spec.md) | (TBD) | | 18 | — | [GUI Architecture Refinement](#track-gui-architecture-refinement) | (no spec.md) | (TBD) |
| 19 | — | [Context First Message Fix](#track-context-first-message-fix) | spec TBD | (none — independent) | | 19 | — | [Context First Message Fix](#track-context-first-message-fix) | spec TBD | (none — independent) |
| ~~19~~ | — | ~~[Fix Remaining Tests](#track-fix-remaining-tests)~~ | ~~SUPERSEDED by track 1~~ | — | | ~~19~~ | — | ~~[Fix Remaining Tests](#track-fix-remaining-tests)~~ | ~~SUPERSEDED by track 1~~ | — |
@@ -735,7 +735,7 @@ Lightweight chronology; full spec/plan/state per track is in the linked folder.
*5 sub-tracks (consistent `result_migration_*` prefix):* *5 sub-tracks (consistent `result_migration_*` prefix):*
| # | Sub-track | T-shirt | Scope | Why this position | | # | Sub-track | Scope | Why this position |
|---|---|---|---|---| |---|---|---|---|---|
| 1 | `result_migration_review_pass` | S | 57 sites (32 UNCLEAR + 25 INTERNAL_RETHROW) across 15 files | First: human review + audit script heuristic updates inform all later sub-tracks | | 1 | `result_migration_review_pass` | S | 57 sites (32 UNCLEAR + 25 INTERNAL_RETHROW) across 15 files | First: human review + audit script heuristic updates inform all later sub-tracks |
| 2 | `result_migration_small_files` | L | 37 files (35 SMALL + 2 MEDIUM from `--by-size`); 72 V+S sites | Second: quick wins; doesn't depend on the orchestrator or GUI; can run in parallel with 3-4 | | 2 | `result_migration_small_files` | L | 37 files (35 SMALL + 2 MEDIUM from `--by-size`); 72 V+S sites | Second: quick wins; doesn't depend on the orchestrator or GUI; can run in parallel with 3-4 |
@@ -745,7 +745,7 @@ Lightweight chronology; full spec/plan/state per track is in the linked folder.
*Total: 5 sub-tracks, 268 sites across 42 files, ~2100 lines changed.* *Total: 5 sub-tracks, 268 sites across 42 files, ~2100 lines changed.*
*NO day estimates (per the new Tier 1 rule added 2026-06-16). Effort is measured by scope (N files, M sites) and T-shirt size (S/M/L/XL). The user / Tier 2 agent decides the actual pacing.* *NO day estimates (per the new Tier 1 rule added 2026-06-16). Effort is measured by scope (N files, M sites) only. The user / Tier 2 agent decides the actual pacing.*
*Sequence: 1 (review) -> 2 (small files) -> 3 (app_controller) -> 4 (gui_2) -> 5 (baseline cleanup). Tracks 2 + 5 can run in parallel; tracks 3 + 4 must be sequential (the GUI calls controller methods); track 1 is independent.* *Sequence: 1 (review) -> 2 (small files) -> 3 (app_controller) -> 4 (gui_2) -> 5 (baseline cleanup). Tracks 2 + 5 can run in parallel; tracks 3 + 4 must be sequential (the GUI calls controller methods); track 1 is independent.*
@@ -787,7 +787,7 @@ Tracks that produce a research deliverable (a markdown report) rather than Appli
- [ ] **Track: Fable System Prompt Review (Critical Analysis)** `[initialized: 058e2c93]` - [ ] **Track: Fable System Prompt Review (Critical Analysis)** `[initialized: 058e2c93]`
*Link: [./tracks/fable_review_20260617/](./tracks/fable_review_20260617/), Spec: [./tracks/fable_review_20260617/spec.md](./tracks/fable_review_20260617/spec.md), Metadata: [./tracks/fable_review_20260617/metadata.json](./tracks/fable_review_20260617/metadata.json), State: [./tracks/fable_review_20260617/state.toml](./tracks/fable_review_20260617/state.toml)* *Link: [./tracks/fable_review_20260617/](./tracks/fable_review_20260617/), Spec: [./tracks/fable_review_20260617/spec.md](./tracks/fable_review_20260617/spec.md), Metadata: [./tracks/fable_review_20260617/metadata.json](./tracks/fable_review_20260617/metadata.json), State: [./tracks/fable_review_20260617/state.toml](./tracks/fable_review_20260617/state.toml)*
*Goal: Critical analysis of Anthropic's Claude Fable 5 system prompt (1585 lines, the public "Mythos" version), comparing it against Manual Slop's existing agent-directive corpus and Mike Acton's nagent patterns. 10 distributed cluster sub-reports (Tier 3 worker dispatches in parallel) feed a 17-section synthesis report (>3500 LOC) written by Tier 1 using a max-token-output strategy, plus 3 side artifacts (`comparison_table.md`, `decisions.md` for the deferred nagent-rebuild, `nagent_takeaways_fable_20260617.md`). Verdict framework: Useful / Persona Performance / Anti-User / Mixed. **Hard rule** (per user 2026-06-17): `docs/artifacts/Fable System Prompt.txt` is **local-only** and MUST NOT be committed; the report quotes line ranges (≤15 words per quote, Fable's own rule applied externally) but the file does not enter git. T-shirt size: **XL**. No day estimates. **Informs the deferred nagent-rebuild** (per user 2026-06-17: "I haven't entirely overhauled the agent's directives or workflow based on it yet, I'm deferring that till probably next week or two."). 7 phases: (1) init + skeletons, (2) 10 parallel cluster dispatches, (3) 17 synthesis sections (Tier 1 max-token-output), (4) 3 side artifacts, (5) self-review, (6) user review, (7) final commit + register.* *Goal: Critical analysis of Anthropic's Claude Fable 5 system prompt (1585 lines, the public "Mythos" version), comparing it against Manual Slop's existing agent-directive corpus and Mike Acton's nagent patterns. 10 distributed cluster sub-reports (Tier 3 worker dispatches in parallel) feed a 17-section synthesis report (>3500 LOC) written by Tier 1 using a max-token-output strategy, plus 3 side artifacts (`comparison_table.md`, `decisions.md` for the deferred nagent-rebuild, `nagent_takeaways_fable_20260617.md`). Verdict framework: Useful / Persona Performance / Anti-User / Mixed. **Hard rule** (per user 2026-06-17): `docs/artifacts/Fable System Prompt.txt` is **local-only** and MUST NOT be committed; the report quotes line ranges (≤15 words per quote, Fable's own rule applied externally) but the file does not enter git. No day estimates. No T-shirt sizes. **Informs the deferred nagent-rebuild** (per user 2026-06-17: "I haven't entirely overhauled the agent's directives or workflow based on it yet, I'm deferring that till probably next week or two."). 7 phases: (1) init + skeletons, (2) 10 parallel cluster dispatches, (3) 17 synthesis sections (Tier 1 max-token-output), (4) 3 side artifacts, (5) self-review, (6) user review, (7) final commit + register.*
--- ---
+8 -50
View File
@@ -285,45 +285,6 @@ Before marking any task complete, verify:
- Verify responsive layouts - Verify responsive layouts
- Check performance on 3G/4G - Check performance on 3G/4G
## Code Review Process
### Self-Review Checklist
Before requesting review:
1. **Functionality**
- Feature works as specified
- Edge cases handled
- Error messages are user-friendly
2. **Code Quality**
- Follows style guide
- DRY principle applied
- Clear variable/function names
- Appropriate comments
3. **Testing**
- Unit tests comprehensive
- Integration tests pass
- Coverage adequate (>80%)
4. **Security**
- No hardcoded secrets
- Input validation present
- SQL injection prevented
- XSS protection in place
5. **Performance**
- Database queries optimized
- Images optimized
- Caching implemented where needed
6. **Mobile Experience**
- Touch targets adequate (44x44px)
- Text readable without zooming
- Performance acceptable on mobile
- Interactions feel native
## Commit Guidelines ## Commit Guidelines
### Message Format ### Message Format
@@ -610,24 +571,20 @@ scenario. Estimates also anchor the user's expectations incorrectly;
"the spec said 2 days and it's been 3, what's wrong?". "the spec said 2 days and it's been 3, what's wrong?".
**What to use instead:** measure effort by **scope** (N files, M sites, **What to use instead:** measure effort by **scope** (N files, M sites,
N tasks) and **T-shirt size** (S/M/L/XL). N tasks). No sizing labels (T-shirt sizes, points, day estimates) are
allowed in track artifacts - they are all guesses. The user / Tier 2
| T-shirt | Typical scope | agent decides the actual pacing.
|---|---|
| **S** | 1-5 small changes; mostly research or doc updates |
| **M** | 1-2 small files; 1 commit |
| **L** | 5-10 files; 2-5 commits; or 1 large file with mechanical changes |
| **XL** | 1 huge file (100K+ lines); 5-10 commits; high coordination |
**Replacement patterns:** **Replacement patterns:**
| DON'T write | WRITE instead | | DON'T write | WRITE instead |
|---|---| |---|---|
| `Estimated effort: 0.5-1 day Tier 2 work` | `Scope: N files, M sites; T-shirt size: S/M/L/XL` | | `Estimated effort: 0.5-1 day Tier 2 work` | `Scope: N files, M sites` |
| `Phase 1: investigation (1-2 hours)` | `Phase 1: investigation` | | `Phase 1: investigation (1-2 hours)` | `Phase 1: investigation` |
| `Track 5 takes 7-10 days total` | `Track 5: scope = N sites across M files` | | `Track 5 takes 7-10 days total` | `Track 5: scope = N sites across M files` |
| `R5: takes longer than 1 day` | `R5: implementation is larger than the spec suggests` | | `R5: takes longer than 1 day` | `R5: implementation is larger than the spec suggests` |
| `~12 min test run` | `the test run takes a while` | | `~12 min test run` | `the test run takes a while` |
| `T-shirt size: XL` | (delete; the scope already says it) |
The user / Tier 2 agent decides the actual pacing. The user / Tier 2 agent decides the actual pacing.
@@ -691,8 +648,9 @@ Tier 1 rules:
If you find yourself writing a day estimate, ask: **"is this estimate If you find yourself writing a day estimate, ask: **"is this estimate
based on data I actually have, or am I guessing?"** The honest answer based on data I actually have, or am I guessing?"** The honest answer
is almost always "guessing" and the right action is to delete the is almost always "guessing" - and the right action is to delete the
estimate and use scope + T-shirt size instead. estimate entirely. Scope (N files, M sites, N tasks) is the only
effort dimension that's not a guess.
The exception: if the user explicitly asks for an estimate (e.g., "how The exception: if the user explicitly asks for an estimate (e.g., "how
many tracks will this take?"), the answer is "I can't predict the many tracks will this take?"), the answer is "I can't predict the
@@ -168,4 +168,4 @@ A future track should:
3. Keep `stream_callback` as a thread-safe queue for streaming chunks. 3. Keep `stream_callback` as a thread-safe queue for streaming chunks.
4. Add a tier-3 test that explicitly runs a 30-second `subprocess.run` in the worker to catch stack regressions. 4. Add a tier-3 test that explicitly runs a 30-second `subprocess.run` in the worker to catch stack regressions.
Track metadata can mirror this report. Estimated scope: 5-8 files, ~150-200 lines net change. T-shirt size: L. Track metadata can mirror this report. Estimated scope: 5-8 files, ~150-200 lines net change.
+78 -934
View File
File diff suppressed because it is too large Load Diff