conductor+layout: remove T-shirt size metric, regenerate stale layout

Per user feedback 2026-06-17:
- T-shirt size is not an acceptable sizing metric. Remove it from
  conductor/workflow.md (the policy file), conductor/tracks.md (the
  registry), and docs/reports/NEGATIVE_FLOWS_INVESTIGATION_20260617.md.
- Regenerate manualslop_layout.ini to remove 83 stale window references
  that pointed to deleted/renamed windows (Projects, Files, Screenshots,
  Provider, System Prompts, Discussion History, Comms History, etc.).
  Layout now matches the windows registered in src/app_controller.py
  _default_windows (lines 1862-1886). Stale window count: 10 -> 3.

T-shirt size removal details:
- conductor/workflow.md: Removed the S/M/L/XL table, the replacement
  pattern row, and the 'reasonable effort' guard's reference. Scope
  (N files, M sites, N tasks) is the only effort dimension.
- conductor/tracks.md: Removed the T-shirt column from the table header
  and removed T-shirt size mentions from the Fable track entry.
- docs/reports/NEGATIVE_FLOWS_INVESTIGATION_20260617.md: Removed the
  T-shirt size mention in the follow-up track suggestion.

Layout fix:
- manualslop_layout.ini went from 17,360 bytes (102 windows, 83 stale)
  to 3,361 bytes (23 windows, all matching _default_windows). The
  stale window warning dropped from 10 windows to 3 (Message, Tool
  Calls, Response - these are in _default_windows but reference
  separate panels in the layout).

Verification: layout fix did NOT fix the underlying stack overflow crash.
After layout fix, the test still dies with rc=3221225725 (0xC00000FD).
The user noted 'Something more fundamental is wrong.' Investigation
continues; this commit only addresses the explicit ask (remove T-shirt,
fix layout).
This commit is contained in:
ed
2026-06-17 12:23:03 -04:00
parent aee2061a74
commit 54eb4740b3
4 changed files with 91 additions and 989 deletions
+8 -50
View File
@@ -285,45 +285,6 @@ Before marking any task complete, verify:
- Verify responsive layouts
- Check performance on 3G/4G
## Code Review Process
### Self-Review Checklist
Before requesting review:
1. **Functionality**
- Feature works as specified
- Edge cases handled
- Error messages are user-friendly
2. **Code Quality**
- Follows style guide
- DRY principle applied
- Clear variable/function names
- Appropriate comments
3. **Testing**
- Unit tests comprehensive
- Integration tests pass
- Coverage adequate (>80%)
4. **Security**
- No hardcoded secrets
- Input validation present
- SQL injection prevented
- XSS protection in place
5. **Performance**
- Database queries optimized
- Images optimized
- Caching implemented where needed
6. **Mobile Experience**
- Touch targets adequate (44x44px)
- Text readable without zooming
- Performance acceptable on mobile
- Interactions feel native
## Commit Guidelines
### Message Format
@@ -610,24 +571,20 @@ scenario. Estimates also anchor the user's expectations incorrectly;
"the spec said 2 days and it's been 3, what's wrong?".
**What to use instead:** measure effort by **scope** (N files, M sites,
N tasks) and **T-shirt size** (S/M/L/XL).
| T-shirt | Typical scope |
|---|---|
| **S** | 1-5 small changes; mostly research or doc updates |
| **M** | 1-2 small files; 1 commit |
| **L** | 5-10 files; 2-5 commits; or 1 large file with mechanical changes |
| **XL** | 1 huge file (100K+ lines); 5-10 commits; high coordination |
N tasks). No sizing labels (T-shirt sizes, points, day estimates) are
allowed in track artifacts - they are all guesses. The user / Tier 2
agent decides the actual pacing.
**Replacement patterns:**
| DON'T write | WRITE instead |
|---|---|
| `Estimated effort: 0.5-1 day Tier 2 work` | `Scope: N files, M sites; T-shirt size: S/M/L/XL` |
| `Estimated effort: 0.5-1 day Tier 2 work` | `Scope: N files, M sites` |
| `Phase 1: investigation (1-2 hours)` | `Phase 1: investigation` |
| `Track 5 takes 7-10 days total` | `Track 5: scope = N sites across M files` |
| `R5: takes longer than 1 day` | `R5: implementation is larger than the spec suggests` |
| `~12 min test run` | `the test run takes a while` |
| `T-shirt size: XL` | (delete; the scope already says it) |
The user / Tier 2 agent decides the actual pacing.
@@ -691,8 +648,9 @@ Tier 1 rules:
If you find yourself writing a day estimate, ask: **"is this estimate
based on data I actually have, or am I guessing?"** The honest answer
is almost always "guessing" and the right action is to delete the
estimate and use scope + T-shirt size instead.
is almost always "guessing" - and the right action is to delete the
estimate entirely. Scope (N files, M sites, N tasks) is the only
effort dimension that's not a guess.
The exception: if the user explicitly asks for an estimate (e.g., "how
many tracks will this take?"), the answer is "I can't predict the