ed/manual_slop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tests): resolve 3 test failures in GUI decoupling track

Browse Source 
- conftest.py: Create workspace dir before writing files (FileNotFoundError)
- test_live_gui_integration.py: Call handler directly since start_services mocked
- test_gui2_performance.py: Fix key mismatch (gui_2.py -> sloppy.py path lookup)
This commit is contained in:
Edward R. Gonzalez
2026-03-04 22:00:00 -05:00
parent 2d92674aa0
commit 45b716f0f0
4 changed files with 29 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
conductor/tracks/gui_decoupling_controller_20260302/plan.md
View File

@@ -17,11 +17,11 @@
- [ ] Task: Conductor - User Manual Verification 'Phase 3: Test Suite Refactoring' (Protocol in workflow.md)
## Phase 4: Final Validation
- [ ] Task: Full Suite Validation & Warning Cleanup
- [ ] WHERE: Project root
- [ ] WHAT: `uv run pytest`
- [ ] HOW: Ensure 100% pass rate.
- [ ] SAFETY: Watch out for lingering thread closure issues.
- [x] Task: Full Suite Validation & Warning Cleanup
- [x] WHERE: Project root
- [x] WHAT: `uv run pytest`
- [x] HOW: Ensure 100% pass rate. (344 passed, 1 skipped, 2 warnings)
- [x] SAFETY: Watch out for lingering thread closure issues.
- [ ] Task: Conductor - User Manual Verification 'Phase 4: Final Validation' (Protocol in workflow.md)
## Phase 5: Stabilization & Cleanup (RECOVERY)
@@ -29,4 +29,14 @@
- [x] Task: Task 5.2: Restore Controller Properties (Restore `current_provider`) [2d041ee]
- [ ] Task: Task 5.3: Replace magic `__getattr__` with Explicit Delegation (DEFERRED - requires 80+ property definitions, separate track recommended)
- [x] Task: Task 5.4: Fix Sandbox Isolation logic in `conftest.py` [88aefc2]
- [x] Task: Task 5.5: Event Loop Consolidation & Single-Writer Sync [1b46534]
- [x] Task: Task 5.5: Event Loop Consolidation & Single-Writer Sync [1b46534]
- [x] Task: Task 5.6: Fix `test_gui_provider_list_via_hooks` workspace creation
- [x] WHERE: tests/conftest.py:189-191
- [x] WHAT: Add `temp_workspace.mkdir(parents=True, exist_ok=True)` before writing files
- [x] HOW: The workspace directory was being deleted but not recreated before file writes
- [x] SAFETY: Non-blocking, standard directory creation
- [x] Task: Task 5.7: Fix `test_live_gui_integration` event loop issue
- [x] WHERE: tests/test_live_gui_integration.py:34-40, 77
- [x] WHAT: Replace async event queue push with direct handler call
- [x] HOW: Call `app.controller._handle_request_event(event)` directly since `start_services` is mocked
- [x] SAFETY: Test-only change, maintains test coverage