phase 2 checkpoint

tests/test_persona_manager.py

@@ -0,0 +1,81 @@
+import pytest
+import tomli_w
+from pathlib import Path
+from src.models import Persona
+from src.personas import PersonaManager
+from src import paths
+
+@pytest.fixture
+def temp_paths(tmp_path, monkeypatch):
+ global_dir = tmp_path / "global"
+ global_dir.mkdir()
+ project_dir = tmp_path / "project"
+ project_dir.mkdir()
+ 
+ global_path = global_dir / "personas.toml"
+ project_path = project_dir / "project_personas.toml"
+ 
+ monkeypatch.setattr(paths, "get_global_personas_path", lambda: global_path)
+ monkeypatch.setattr(paths, "get_project_personas_path", lambda _: project_path)
+ 
+ return {"global": global_path, "project": project_path, "project_root": project_dir}
+
+def test_load_all_merged(temp_paths):
+ global_data = {
+  "personas": {
+   "default": {
+    "provider": "anthropic",
+    "model": "claude-3",
+    "system_prompt": "Global prompt"
+   },
+   "global_only": {
+    "provider": "gemini",
+    "system_prompt": "Gemini prompt"
+   }
+  }
+ }
+ with open(temp_paths["global"], "wb") as f:
+  tomli_w.dump(global_data, f)
+ 
+ project_data = {
+  "personas": {
+   "default": {
+    "provider": "anthropic",
+    "model": "claude-3.5", # Overrides global
+    "system_prompt": "Project prompt"
+   }
+  }
+ }
+ with open(temp_paths["project"], "wb") as f:
+  tomli_w.dump(project_data, f)
+ 
+ manager = PersonaManager(project_root=temp_paths["project_root"])
+ all_personas = manager.load_all()
+ 
+ assert "global_only" in all_personas
+ assert "default" in all_personas
+ assert all_personas["default"].model == "claude-3.5"
+ assert all_personas["default"].system_prompt == "Project prompt"
+
+def test_save_persona(temp_paths):
+ manager = PersonaManager(project_root=temp_paths["project_root"])
+ persona = Persona(name="New", provider="gemini", system_prompt="Test")
+ 
+ manager.save_persona(persona, scope="project")
+ loaded = manager.load_all()
+ assert "New" in loaded
+ assert loaded["New"].provider == "gemini"
+
+def test_delete_persona(temp_paths):
+ project_data = {
+  "personas": {
+   "to_delete": {"provider": "gemini", "system_prompt": "Del"}
+  }
+ }
+ with open(temp_paths["project"], "wb") as f:
+  tomli_w.dump(project_data, f)
+ 
+ manager = PersonaManager(project_root=temp_paths["project_root"])
+ manager.delete_persona("to_delete", scope="project")
+ loaded = manager.load_all()
+ assert "to_delete" not in loaded

tests/test_persona_models.py

@@ -0,0 +1,70 @@
+import pytest
+from src.models import Persona
+
+def test_persona_serialization():
+ persona = Persona(
+  name="SecuritySpecialist",
+  provider="anthropic",
+  model="claude-3-7-sonnet-20250219",
+  preferred_models=["claude-3-7-sonnet-20250219", "claude-3-5-sonnet-20241022"],
+  system_prompt="You are a security expert.",
+  temperature=0.2,
+  top_p=0.9,
+  max_output_tokens=4000,
+  tool_preset="SecurityTools",
+  bias_profile="Execution-Focused"
+ )
+ 
+ data = persona.to_dict()
+ 
+ assert data["provider"] == "anthropic"
+ assert data["model"] == "claude-3-7-sonnet-20250219"
+ assert "claude-3-5-sonnet-20241022" in data["preferred_models"]
+ assert data["system_prompt"] == "You are a security expert."
+ assert data["temperature"] == 0.2
+ assert data["top_p"] == 0.9
+ assert data["max_output_tokens"] == 4000
+ assert data["tool_preset"] == "SecurityTools"
+ assert data["bias_profile"] == "Execution-Focused"
+
+def test_persona_deserialization():
+ data = {
+  "provider": "gemini",
+  "model": "gemini-2.5-flash",
+  "preferred_models": ["gemini-2.5-flash"],
+  "system_prompt": "You are a helpful assistant.",
+  "temperature": 0.5,
+  "top_p": 1.0,
+  "max_output_tokens": 8192,
+  "tool_preset": "Default",
+  "bias_profile": "Balanced"
+ }
+ 
+ persona = Persona.from_dict("Assistant", data)
+ 
+ assert persona.name == "Assistant"
+ assert persona.provider == "gemini"
+ assert persona.model == "gemini-2.5-flash"
+ assert persona.preferred_models == ["gemini-2.5-flash"]
+ assert persona.system_prompt == "You are a helpful assistant."
+ assert persona.temperature == 0.5
+ assert persona.top_p == 1.0
+ assert persona.max_output_tokens == 8192
+ assert persona.tool_preset == "Default"
+ assert persona.bias_profile == "Balanced"
+
+def test_persona_defaults():
+ persona = Persona(name="Minimal", system_prompt="Just the basics")
+ assert persona.provider is None
+ assert persona.model is None
+ assert persona.preferred_models == []
+ assert persona.temperature is None
+ assert persona.tool_preset is None
+ 
+ data = persona.to_dict()
+ assert "provider" not in data
+ assert "preferred_models" not in data
+ assert "temperature" not in data
+ 
+ loaded = Persona.from_dict("Minimal", data)
+ assert loaded.preferred_models == []