docs: Add session debrief about test fixes and MCP tool lesson
This commit is contained in:
30
conductor/archive/test_fixes_session_debrief.md
Normal file
30
conductor/archive/test_fixes_session_debrief.md
Normal file
@@ -0,0 +1,30 @@
|
||||
# Session Debrief: Test Fixes
|
||||
|
||||
## Summary
|
||||
Fixed 329/330 tests passing for asyncio_decoupling_refactor_20260306 track.
|
||||
|
||||
## What Worked
|
||||
- Fixed import paths in 20+ test files (aggregate → src.aggregate)
|
||||
- Fixed mock paths (gemini_cli_adapter.subprocess.Popen)
|
||||
- Fixed ApiHookClient methods (post_session, get_events, clear_events, post_project)
|
||||
- Fixed callback path in app_controller.py
|
||||
|
||||
## What Failed - test_visual_orchestration.py
|
||||
- Root cause: orchestrator_pm.generate_tracks() returns tracks but they're not reaching the popup
|
||||
- Debug showed: AI IS called (1262 tokens), no parsing errors, but proposed_tracks=[]
|
||||
- Issue in the _pending_gui_tasks queue - tracks aren't being processed
|
||||
|
||||
## CRITICAL MCP TOOL LESSON
|
||||
When using manual-slop_edit_file, parameters are CAMEL CASE:
|
||||
- oldString (NOT old_string)
|
||||
- newString (NOT new_string)
|
||||
- replaceAll (NOT replace_all)
|
||||
|
||||
The tool schema shows camelCase. Never assume snake_case. Always verify params from schema.
|
||||
|
||||
## Files Modified
|
||||
- src/api_hook_client.py
|
||||
- src/app_controller.py
|
||||
- src/orchestrator_pm.py
|
||||
- tests/test_*.py (20+ files)
|
||||
- tests/mock_gemini_cli.py
|
||||
Reference in New Issue
Block a user