WIP: fixing regressions in tests

This commit is contained in:
2026-05-12 21:04:50 -04:00
parent c0d106255b
commit 29de116233
15 changed files with 236 additions and 44 deletions
+40 -4
View File
@@ -101,7 +101,16 @@ class TestMMAApprovalIndicators:
_pending_ask_dialog=False,
)
imgui_mock = _make_imgui_mock()
with patch("src.gui_2.imgui", imgui_mock):
with patch("src.gui_2.imgui", imgui_mock), patch("src.gui_2.imscope") as mock_imscope:
# Setup imscope mocks
mock_imscope.window.return_value.__enter__.return_value = (True, True)
mock_imscope.child.return_value.__enter__.return_value = True
mock_imscope.table.return_value.__enter__.return_value = True
mock_imscope.tree_node_ex.return_value.__enter__.return_value = True
mock_imscope.tab_item.return_value.__enter__.return_value = (True, True)
mock_imscope.style_color.return_value.__enter__.return_value = None
mock_imscope.style_var.return_value.__enter__.return_value = None
App._render_mma_dashboard(app)
combined = _collect_text_colored_args(imgui_mock)
assert "APPROVAL PENDING" not in combined, (
@@ -112,7 +121,16 @@ class TestMMAApprovalIndicators:
"""'APPROVAL PENDING' badge must appear when _pending_mma_spawn is set."""
app = _make_app(_pending_mma_spawn={"ticket_id": "T-001"})
imgui_mock = _make_imgui_mock()
with patch("src.gui_2.imgui", imgui_mock), patch("src.gui_2.math") as mock_math:
with patch("src.gui_2.imgui", imgui_mock), patch("src.gui_2.imscope") as mock_imscope, patch("src.gui_2.math") as mock_math:
# Setup imscope mocks
mock_imscope.window.return_value.__enter__.return_value = (True, True)
mock_imscope.child.return_value.__enter__.return_value = True
mock_imscope.table.return_value.__enter__.return_value = True
mock_imscope.tree_node_ex.return_value.__enter__.return_value = True
mock_imscope.tab_item.return_value.__enter__.return_value = (True, True)
mock_imscope.style_color.return_value.__enter__.return_value = None
mock_imscope.style_var.return_value.__enter__.return_value = None
mock_math.sin.return_value = 0.8
App._render_mma_dashboard(app)
combined = _collect_text_colored_args(imgui_mock)
@@ -124,7 +142,16 @@ class TestMMAApprovalIndicators:
"""'APPROVAL PENDING' badge must appear when _pending_mma_approval is set."""
app = _make_app(_pending_mma_approval={"step": "test"})
imgui_mock = _make_imgui_mock()
with patch("src.gui_2.imgui", imgui_mock), patch("src.gui_2.math") as mock_math:
with patch("src.gui_2.imgui", imgui_mock), patch("src.gui_2.imscope") as mock_imscope, patch("src.gui_2.math") as mock_math:
# Setup imscope mocks
mock_imscope.window.return_value.__enter__.return_value = (True, True)
mock_imscope.child.return_value.__enter__.return_value = True
mock_imscope.table.return_value.__enter__.return_value = True
mock_imscope.tree_node_ex.return_value.__enter__.return_value = True
mock_imscope.tab_item.return_value.__enter__.return_value = (True, True)
mock_imscope.style_color.return_value.__enter__.return_value = None
mock_imscope.style_var.return_value.__enter__.return_value = None
mock_math.sin.return_value = 0.8
App._render_mma_dashboard(app)
combined = _collect_text_colored_args(imgui_mock)
@@ -136,7 +163,16 @@ class TestMMAApprovalIndicators:
"""'APPROVAL PENDING' badge must appear when _pending_ask_dialog is True."""
app = _make_app(_pending_ask_dialog=True)
imgui_mock = _make_imgui_mock()
with patch("src.gui_2.imgui", imgui_mock), patch("src.gui_2.math") as mock_math:
with patch("src.gui_2.imgui", imgui_mock), patch("src.gui_2.imscope") as mock_imscope, patch("src.gui_2.math") as mock_math:
# Setup imscope mocks
mock_imscope.window.return_value.__enter__.return_value = (True, True)
mock_imscope.child.return_value.__enter__.return_value = True
mock_imscope.table.return_value.__enter__.return_value = True
mock_imscope.tree_node_ex.return_value.__enter__.return_value = True
mock_imscope.tab_item.return_value.__enter__.return_value = (True, True)
mock_imscope.style_color.return_value.__enter__.return_value = None
mock_imscope.style_var.return_value.__enter__.return_value = None
mock_math.sin.return_value = 0.8
App._render_mma_dashboard(app)
combined = _collect_text_colored_args(imgui_mock)