ed/manual_slop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(core): Replace pytest.fail with functional assertions in api_events and execution_engine

Browse Source
This commit is contained in:
Edward R. Gonzalez
2026-03-02 23:26:19 -05:00
parent 48d111d9b6
commit 194626e5ab
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test_api_events.py
View File

@@ -35,9 +35,6 @@ def test_event_emission() -> None:
ai_client.events.emit("test_event", payload={"data": 123}) ai_client.events.emit("test_event", payload={"data": 123})
callback.assert_called_once_with(payload={"data": 123}) callback.assert_called_once_with(payload={"data": 123})
def test_send_emits_events() -> None:
pytest.fail("TODO: This test is mocked incorrectly and asserts nothing. Use _proper version below.")
def test_send_emits_events_proper() -> None: def test_send_emits_events_proper() -> None:
with patch("ai_client._ensure_gemini_client"), \ with patch("ai_client._ensure_gemini_client"), \
patch("ai_client._gemini_client") as mock_client: patch("ai_client._gemini_client") as mock_client:

5
tests/test_execution_engine.py
View File

@@ -39,11 +39,12 @@ def test_execution_engine_basic_flow() -> None:
assert len(ready) == 0 assert len(ready) == 0
def test_execution_engine_update_nonexistent_task() -> None: def test_execution_engine_update_nonexistent_task() -> None:
dag = TrackDAG([]) t1 = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker")
dag = TrackDAG([t1])
engine = ExecutionEngine(dag) engine = ExecutionEngine(dag)
# Should not raise error, or handle gracefully # Should not raise error, or handle gracefully
engine.update_task_status("NONEXISTENT", "completed") engine.update_task_status("NONEXISTENT", "completed")
pytest.fail("TODO: Implement assertions") assert t1.status == "todo"
def test_execution_engine_status_persistence() -> None: def test_execution_engine_status_persistence() -> None:
t1 = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker") t1 = Ticket(id="T1", description="Task 1", status="todo", assigned_to="worker")