ed/manual_slop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

conductor(plan): Mark task 'Apply review suggestions' as complete

Browse Source
This commit is contained in:
Edward R. Gonzalez
2026-03-02 19:37:01 -05:00
parent febcf3be85
commit 0bd75fbd52
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
conductor/tracks/mma_agent_focus_ux_20260302/plan.md
View File

@@ -7,7 +7,7 @@ Architecture reference: [docs/guide_mma.md](../../../docs/guide_mma.md)
--- ---
## Phase 1: Tier Tagging at Emission [checkpoint: bc1a570] ## Phase 1: Tier Tagging at Emission [checkpoint: bc1a570]
Focus: Add `current_tier` context variable to `ai_client` and stamp it on every comms/tool entry at the point of emission. No UI changes — purely data layer. Focus: Add `current_tier` context variable to `ai_client` and stamp it on every comms/tool entry at the point of emission. No UI changes — purely data layer.
- [x] Task 1.1: Add `current_tier` module variable to `ai_client.py`. 8d9f25d - [x] Task 1.1: Add `current_tier` module variable to `ai_client.py`. 8d9f25d
- [x] Task 1.2: Stamp `source_tier` in `_append_comms`. 8d9f25d - [x] Task 1.2: Stamp `source_tier` in `_append_comms`. 8d9f25d
@@ -16,14 +16,14 @@ Focus: Add `current_tier` context variable to `ai_client` and stamp it on every
- [x] Task 1.5: Migrate `_tool_log` from tuple to dict; update emission and storage. 8d9f25d - [x] Task 1.5: Migrate `_tool_log` from tuple to dict; update emission and storage. 8d9f25d
- [x] Task 1.6: Write tests for Phase 1. 8 tests, 12/12 passed. 8d9f25d - [x] Task 1.6: Write tests for Phase 1. 8 tests, 12/12 passed. 8d9f25d
- [x] Task 1.7: Conductor — User Manual Verification. App renders, comms history panel intact. 00a196c - [x] Task 1.7: Conductor — User Manual Verification. App renders, comms history panel intact. 00a196c
- Launch app. Open a send in normal mode — confirm comms entries in Operations Hub > Comms History still render. - Launch app. Open a send in normal mode — confirm comms entries in Operations Hub > Comms History still render.
- (MMA run not required at this phase — data layer only.) - (MMA run not required at this phase — data layer only.)
--- ---
## Phase 2: Tool Log Reader Migration [checkpoint: 865d8dd] ## Phase 2: Tool Log Reader Migration [checkpoint: 865d8dd]
Focus: Update `_render_tool_calls_panel` to read dicts. No UI change — just fixes the access pattern before Phase 3 adds filter logic. Focus: Update `_render_tool_calls_panel` to read dicts. No UI change — just fixes the access pattern before Phase 3 adds filter logic.
- [x] Task 2.1: Update `_render_tool_calls_panel` to use dict access. 865d8dd - [x] Task 2.1: Update `_render_tool_calls_panel` to use dict access. 865d8dd
- **Location**: `gui_2.py:2989-3039`. Confirm with `get_file_slice(2989, 3042)`. - **Location**: `gui_2.py:2989-3039`. Confirm with `get_file_slice(2989, 3042)`.
@@ -40,7 +40,7 @@ Focus: Update `_render_tool_calls_panel` to read dicts. No UI change — just fi
- [x] Task 2.2: Write/run tests. 12/12 passed. 865d8dd - [x] Task 2.2: Write/run tests. 12/12 passed. 865d8dd
- Run `uv run pytest tests/ -x -q`. Confirm tool log panel simulation tests (if any) pass. - Run `uv run pytest tests/ -x -q`. Confirm tool log panel simulation tests (if any) pass.
- [x] Task 2.3: Conductor — User Manual Verification. 865d8dd - [x] Task 2.3: Conductor — User Manual Verification. 865d8dd
- Launch app. Generate a script send (or use existing tool call in history). Confirm "Tool Calls" tab in Operations Hub renders correctly. - Launch app. Generate a script send (or use existing tool call in history). Confirm "Tool Calls" tab in Operations Hub renders correctly.
--- ---
@@ -72,7 +72,7 @@ Focus: Add the combo selector and filter the two log panels.
self.ui_focus_agent = None self.ui_focus_agent = None
imgui.separator() imgui.separator()
``` ```
- **Note**: Tier 1 omitted — Tier 1 (Claude Code) never calls `ai_client.send()`, so it produces no comms entries. - **Note**: Tier 1 omitted — Tier 1 (Claude Code) never calls `ai_client.send()`, so it produces no comms entries.
- **How**: Use `Edit`. - **How**: Use `Edit`.
- [x] Task 3.3: Add filter logic to `_render_comms_history_panel`. b30e563 - [x] Task 3.3: Add filter logic to `_render_comms_history_panel`. b30e563
@@ -108,7 +108,7 @@ Focus: Add the combo selector and filter the two log panels.
- Test that `ui_focus_agent = "Tier 3"` filters out entries with `source_tier = "Tier 2"`. - Test that `ui_focus_agent = "Tier 3"` filters out entries with `source_tier = "Tier 2"`.
- Run `uv run pytest tests/ -x -q`. - Run `uv run pytest tests/ -x -q`.
- [x] Task 3.6: Conductor — User Manual Verification. UI confirmed by user. b30e563 - [x] Task 3.6: Conductor — User Manual Verification. UI confirmed by user. b30e563
- Launch app. Open Operations Hub. - Launch app. Open Operations Hub.
- Confirm "Focus Agent:" combo appears above tabs with options: All, Tier 2, Tier 3, Tier 4. - Confirm "Focus Agent:" combo appears above tabs with options: All, Tier 2, Tier 3, Tier 4.
- With "All" selected: all entries show with `[main]` or `[Tier N]` labels in comms history. - With "All" selected: all entries show with `[main]` or `[Tier N]` labels in comms history.
@@ -117,9 +117,5 @@ Focus: Add the combo selector and filter the two log panels.
--- ---
## Phase Completion Checkpoint ## Phase: Review Fixes
After all phases pass manual verification: - [x] Task: Apply review suggestions febcf3b
- Run `uv run pytest tests/ -x -q` one final time.
- Commit: `feat(mma): per-tier agent focus — source_tier tagging + Focus Agent filter UI`
- Update TASKS.md: move `mma_agent_focus_ux` from Planned to Active/Completed.
- Update JOURNAL.md with What/Why/How/Issues/Result.