ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-06-13 01:21:38 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix #5004

Browse Source 
Fixes constant NaN to constant NaN comparisons.
This commit is contained in:
Jeroen van Rijn
2025-04-05 14:47:30 +02:00
parent f796b67a67
commit 843467bb8f
2 changed files with 37 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/exact_value.cpp
+4
View File
@@ -954,6 +954,10 @@ gb_internal bool compare_exact_values(TokenKind op, ExactValue x, ExactValue y)
case ExactValue_Float: {
f64 a = x.value_float;
f64 b = y.value_float;
if (isnan(a) || isnan(b)) {
return false; // Fixes #5004
}
switch (op) {
case Token_CmpEq: return cmp_f64(a, b) == 0;
case Token_NotEq: return cmp_f64(a, b) != 0;
tests/internal/test_5004_nan_constant_comparison.odin
+33
View File
@@ -0,0 +1,33 @@
package test_internal
import "core:testing"
@(test)
compare_constant_nans_f32 :: proc(t: ^testing.T) {
NaN :: f32(0h7fc0_0000)
NaN2 :: f32(0h7fc0_0001)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != NaN, false)
testing.expect_value(t, NaN != NaN2, false)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}
@(test)
compare_constant_nans_f64 :: proc(t: ^testing.T) {
NaN :: f64(0h7fff_0000_0000_0000)
NaN2 :: f64(0h7fff_0000_0000_0001)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != NaN, false)
testing.expect_value(t, NaN != NaN2, false)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}