From ffb79a67efe8d65c6568b584e1d8d560a928e67d Mon Sep 17 00:00:00 2001 From: Ryan Fleury Date: Tue, 9 Jun 2026 16:07:16 -0700 Subject: [PATCH] be robust to missing symbol server support --- src/dbg_engine/dbg_engine_ctrl.c | 3 ++- src/dbg_info/dbg_info.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/dbg_engine/dbg_engine_ctrl.c b/src/dbg_engine/dbg_engine_ctrl.c index 03d71d00..bfa17682 100644 --- a/src/dbg_engine/dbg_engine_ctrl.c +++ b/src/dbg_engine/dbg_engine_ctrl.c @@ -2675,6 +2675,7 @@ d_ctrl_thread__module_open(D_Handle process, D_Handle module, U64 base_vaddr, DM } // rjf: push local symbol server cache's path + if(local_symbol_server_cache_path.size != 0) { str8_list_push(scratch.arena, &candidates, local_symbol_server_cache_path); } @@ -2698,7 +2699,7 @@ d_ctrl_thread__module_open(D_Handle process, D_Handle module, U64 base_vaddr, DM // if it exists, we can just use it. if it doesn't, then we only want to pick it *if* // automatic downloads are enabled. // - if(initial_debug_info_path.size == 0 && d_ctrl_state->auto_download_debug_info) + if(initial_debug_info_path.size == 0 && d_ctrl_state->auto_download_debug_info && local_symbol_server_cache_path.size != 0) { initial_debug_info_path = str8_copy(arena, local_symbol_server_cache_path); } diff --git a/src/dbg_info/dbg_info.c b/src/dbg_info/dbg_info.c index 311424b4..b6a381f2 100644 --- a/src/dbg_info/dbg_info.c +++ b/src/dbg_info/dbg_info.c @@ -697,7 +697,7 @@ di_async_tick(void) if(!file_is_present) { String8 symbol_cache_path = smsv_cache_path(); - if(str8_match(symbol_cache_path, og_path, StringMatchFlag_RightSideSloppy|StringMatchFlag_SlashInsensitive)) + if(symbol_cache_path.size != 0 && str8_match(symbol_cache_path, og_path, StringMatchFlag_RightSideSloppy|StringMatchFlag_SlashInsensitive)) { if(di_shared->auto_downloads) {