ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-07 14:28:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

add comment about previously introduced path heuristic - will need to be careful on linux

Browse Source
This commit is contained in:
Ryan Fleury
2025-01-04 17:07:34 -08:00
parent 47373fbb58
commit fbc1f871cf
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ctrl/ctrl_core.c
+10
View File
@@ -3665,6 +3665,16 @@ ctrl_thread__module_open(CTRL_Handle process, CTRL_Handle module, Rng1U64 vaddr_
Temp scratch = scratch_begin(0, 0); Temp scratch = scratch_begin(0, 0);
String8 exe_folder = str8_chop_last_slash(path); String8 exe_folder = str8_chop_last_slash(path);
String8List dbg_path_candidates = {0}; String8List dbg_path_candidates = {0};
//
//~ TODO(rjf): @linux_port PLEASE READ RYAN vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
//
// TODO(rjf): trying "exe_folder/embedded_path" as the first option is only a valid
// heuristic on Windows, because we know that two absolute paths concatted together
// are necessarily invalid. however, on Linux, this is not the case - you could stitch
// two paths together and get a third path that is completely valid. so, in that case,
// we will need to infer if the path is relative, and then use either the embedded
// path as-is, or the exe-relative-path accordingly, depending on that.
//
if(rdi_dbg_path.size != 0) if(rdi_dbg_path.size != 0)
{ {
str8_list_pushf(scratch.arena, &dbg_path_candidates, "%S/%S", exe_folder, rdi_dbg_path); str8_list_pushf(scratch.arena, &dbg_path_candidates, "%S/%S", exe_folder, rdi_dbg_path);