From fa7143a3e46e0f650a045d36ae06f6aa207679ad Mon Sep 17 00:00:00 2001
From: Ryan Fleury <ryan.j.fleury@gmail.com>
Date: Tue, 11 Feb 2025 14:07:43 -0800
Subject: [PATCH] never build hover evals if we cannot evaluate the root
 expression successfully

---
 src/raddbg/raddbg_core.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/raddbg/raddbg_core.c b/src/raddbg/raddbg_core.c
index 1931d4d3..072b8ef9 100644
--- a/src/raddbg/raddbg_core.c
+++ b/src/raddbg/raddbg_core.c
@@ -6174,6 +6174,13 @@ rd_window_frame(void)
 #endif
       }
       
+      // rjf: evaluate hover-evaluation expression - if it doesn't evaluate, then don't build anything
+      E_Eval hover_eval = e_eval_from_string(scratch.arena, ws->hover_eval_string);
+      if(hover_eval.msgs.max_kind > E_MsgKind_Null)
+      {
+        build_hover_eval = 0;
+      }
+      
       // rjf: reset open animation
       if(ws->hover_eval_string.size == 0)
       {