ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-06 22:08:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove heuristic of array view rule implicitly disabling string visualization; prefer explicit no_string view rule

Browse Source
This commit is contained in:
Ryan Fleury
2024-12-17 09:45:54 -08:00
parent 3023269a9c
commit e9ac6ccf7e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/raddbg/raddbg_core.c
+4 -2
View File
@@ -9255,6 +9255,7 @@ rd_append_value_strings_from_eval(Arena *arena, EV_StringFlags flags, U32 defaul
U32 radix = default_radix; U32 radix = default_radix;
U32 min_digits = 0; U32 min_digits = 0;
B32 no_addr = 0; B32 no_addr = 0;
B32 no_string = 0;
B32 has_array = 0; B32 has_array = 0;
for(EV_ViewRuleNode *n = view_rules->first; n != 0; n = n->next) for(EV_ViewRuleNode *n = view_rules->first; n != 0; n = n->next)
{ {
@@ -9264,6 +9265,7 @@ rd_append_value_strings_from_eval(Arena *arena, EV_StringFlags flags, U32 defaul
else if(str8_match(n->v.root->string, str8_lit("bin"), 0)) {radix = 2; } else if(str8_match(n->v.root->string, str8_lit("bin"), 0)) {radix = 2; }
else if(str8_match(n->v.root->string, str8_lit("oct"), 0)) {radix = 8; } else if(str8_match(n->v.root->string, str8_lit("oct"), 0)) {radix = 8; }
else if(str8_match(n->v.root->string, str8_lit("no_addr"), 0)) {no_addr = 1;} else if(str8_match(n->v.root->string, str8_lit("no_addr"), 0)) {no_addr = 1;}
else if(str8_match(n->v.root->string, str8_lit("no_string"), 0)) {no_string = 1;}
else if(str8_match(n->v.root->string, str8_lit("array"), 0)) {has_array = 1;} else if(str8_match(n->v.root->string, str8_lit("array"), 0)) {has_array = 1;}
else if(str8_match(n->v.root->string, str8_lit("digits"), 0)) else if(str8_match(n->v.root->string, str8_lit("digits"), 0))
{ {
@@ -9345,7 +9347,7 @@ rd_append_value_strings_from_eval(Arena *arena, EV_StringFlags flags, U32 defaul
// rjf: special case: push strings for textual string content // rjf: special case: push strings for textual string content
B32 did_content = 0; B32 did_content = 0;
B32 did_string = 0; B32 did_string = 0;
if(!did_content && ptee_has_string && !has_array) if(!did_content && ptee_has_string && !no_string)
{ {
did_content = 1; did_content = 1;
did_string = 1; did_string = 1;
@@ -9469,7 +9471,7 @@ rd_append_value_strings_from_eval(Arena *arena, EV_StringFlags flags, U32 defaul
// rjf: special case: push strings for textual string content // rjf: special case: push strings for textual string content
B32 did_content = 0; B32 did_content = 0;
if(!did_content && array_is_string && !has_array && (member == 0 || member->kind != E_MemberKind_Padding)) if(!did_content && array_is_string && !no_string && (member == 0 || member->kind != E_MemberKind_Padding))
{ {
U64 element_size = e_type_byte_size_from_key(direct_type_key); U64 element_size = e_type_byte_size_from_key(direct_type_key);
did_content = 1; did_content = 1;