ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-14 09:18:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

use fully-qualified names in eval viz address resolved symbol strings, used in call stack / etc.

Browse Source
This commit is contained in:
Ryan Fleury
2026-06-02 12:16:16 -07:00
parent 5a819f8094
commit e958814b07
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/eval_visualization/eval_visualization_core.c
+5 -4
View File
@@ -2049,8 +2049,7 @@ ev_string_iter_next(Arena *arena, EV_StringIter *it, String8 *out_string)
RDI_Symbol *procedure = rdi_element_from_name_idx(rdi, Procedures, proc_idx); RDI_Symbol *procedure = rdi_element_from_name_idx(rdi, Procedures, proc_idx);
RDI_TypeNode *type_node = rdi_element_from_name_idx(rdi, TypeNodes, procedure->type_idx); RDI_TypeNode *type_node = rdi_element_from_name_idx(rdi, TypeNodes, procedure->type_idx);
E_TypeKey type = e_type_key_ext(e_type_kind_from_rdi(type_node->kind), procedure->type_idx, dbg_info_num); E_TypeKey type = e_type_key_ext(e_type_kind_from_rdi(type_node->kind), procedure->type_idx, dbg_info_num);
String8 name = {0}; String8 name = fully_qualified_str8_from_rdi_symbol(scratch.arena, rdi, procedure);
name.str = rdi_string_from_idx(rdi, procedure->name_string_idx, &name.size);
if(procedure->type_idx != 0) if(procedure->type_idx != 0)
{ {
String8List list = {0}; String8List list = {0};
@@ -2080,19 +2079,21 @@ ev_string_iter_next(Arena *arena, EV_StringIter *it, String8 *out_string)
// NOTE(rjf): non-read-only -> only generate thing which can be parsed, so just procedure name // NOTE(rjf): non-read-only -> only generate thing which can be parsed, so just procedure name
else else
{ {
Temp scratch = scratch_begin(&arena, 1);
// rjf: voff -> scope // rjf: voff -> scope
U64 scope_idx = rdi_vmap_idx_from_section_kind_voff(rdi, RDI_SectionKind_ScopeVMap, voff); U64 scope_idx = rdi_vmap_idx_from_section_kind_voff(rdi, RDI_SectionKind_ScopeVMap, voff);
RDI_Scope *scope = rdi_scope_from_voff(rdi, voff); RDI_Scope *scope = rdi_scope_from_voff(rdi, voff);
// rjf: scope -> procedure / string // rjf: scope -> procedure / string
RDI_Symbol *procedure = rdi_procedure_from_scope(rdi, scope); RDI_Symbol *procedure = rdi_procedure_from_scope(rdi, scope);
String8 procedure_name = {0}; String8 procedure_name = fully_qualified_str8_from_rdi_symbol(scratch.arena, rdi, procedure);
procedure_name.str = rdi_name_from_procedure(rdi, procedure, &procedure_name.size);
if(procedure_name.size != 0) if(procedure_name.size != 0)
{ {
*out_string = str8f(arena, "%S%S", pre_prefix, procedure_name); *out_string = str8f(arena, "%S%S", pre_prefix, procedure_name);
} }
good_symbol_match = (procedure_name.size != 0); good_symbol_match = (procedure_name.size != 0);
scratch_end(scratch);
} }
ptr_data->did_prefix_content = good_symbol_match; ptr_data->did_prefix_content = good_symbol_match;