From cc8212753798812021fd3c7e5f64cddd3ed4a8fd Mon Sep 17 00:00:00 2001 From: Ryan Fleury Date: Wed, 23 Sep 2026 11:53:59 -0600 Subject: [PATCH] eh_frame_unwind: correctly commit cfa_out - it is still unclear if we need this channel, since all we do right now is commit cfa to the sp. so presumably callers could just look at the parent's sp? but my understanding of this is not strong enough to know if that is 100% reliable, since my understanding is that the cfa is an abstract thing specifically because it may *not* be the sp. but not sure, need to look more into it later. --- src/eh_frame/unwind/eh_frame_unwind.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/eh_frame/unwind/eh_frame_unwind.c b/src/eh_frame/unwind/eh_frame_unwind.c index 47a5dba6..979c77c8 100644 --- a/src/eh_frame/unwind/eh_frame_unwind.c +++ b/src/eh_frame/unwind/eh_frame_unwind.c @@ -687,6 +687,10 @@ eh_uwnd_step(Arch arch, MemoryMap *memory_map, UWND_ModuleInfo *module_info, U64 //- rjf: commit new register values, if we succeeded if(!done) { + if(cfa_out) + { + cfa_out[0] = cfa; + } result.status = UWND_StepStatus_Good; } }