ellipses for unfinished arrays/structs in eval single-line visualization

This commit is contained in:
Ryan Fleury
2024-08-20 16:33:08 -07:00
parent 4611ddb536
commit c77d61fb4c
5 changed files with 20 additions and 5 deletions
+1 -4
View File
@@ -5350,10 +5350,7 @@ ctrl_mem_stream_thread__entry_point(void *p)
{ {
range_n->hash = hash; range_n->hash = hash;
} }
if(!u128_match(u128_zero(), hash)) range_n->mem_gen = post_read_mem_gen;
{
range_n->mem_gen = post_read_mem_gen;
}
ins_atomic_u32_eval_assign(&range_n->is_taken, 0); ins_atomic_u32_eval_assign(&range_n->is_taken, 0);
goto commit__break_all; goto commit__break_all;
} }
+3 -1
View File
@@ -3003,6 +3003,7 @@ df_symbol_name_from_dbgi_key_voff(Arena *arena, DI_Key *dbgi_key, U64 voff, B32
internal String8 internal String8
df_symbol_name_from_process_vaddr(Arena *arena, DF_Entity *process, U64 vaddr, B32 decorated) df_symbol_name_from_process_vaddr(Arena *arena, DF_Entity *process, U64 vaddr, B32 decorated)
{ {
ProfBeginFunction();
String8 result = {0}; String8 result = {0};
{ {
DF_Entity *module = df_module_from_process_vaddr(process, vaddr); DF_Entity *module = df_module_from_process_vaddr(process, vaddr);
@@ -3010,6 +3011,7 @@ df_symbol_name_from_process_vaddr(Arena *arena, DF_Entity *process, U64 vaddr, B
U64 voff = df_voff_from_vaddr(module, vaddr); U64 voff = df_voff_from_vaddr(module, vaddr);
result = df_symbol_name_from_dbgi_key_voff(arena, &dbgi_key, voff, decorated); result = df_symbol_name_from_dbgi_key_voff(arena, &dbgi_key, voff, decorated);
} }
ProfEnd();
return result; return result;
} }
@@ -6233,7 +6235,7 @@ df_core_begin_frame(Arena *arena, DF_CmdList *cmds, F32 dt)
df_state->frame_index += 1; df_state->frame_index += 1;
arena_clear(df_frame_arena()); arena_clear(df_frame_arena());
df_state->frame_di_scope = di_scope_open(); df_state->frame_di_scope = di_scope_open();
df_state->frame_eval_memread_endt_us = os_now_microseconds() + 10000; df_state->frame_eval_memread_endt_us = os_now_microseconds() + 5000;
df_state->dt = dt; df_state->dt = dt;
df_state->time_in_seconds += dt; df_state->time_in_seconds += dt;
df_state->top_interact_regs = &df_state->base_interact_regs; df_state->top_interact_regs = &df_state->base_interact_regs;
+12
View File
@@ -8560,6 +8560,12 @@ df_append_value_strings_from_eval(Arena *arena, DF_EvalVizStringFlags flags, U32
space_taken += f_dim_from_tag_size_string(font, font_size, 0, 0, comma).x; space_taken += f_dim_from_tag_size_string(font, font_size, 0, 0, comma).x;
str8_list_push(arena, out, comma); str8_list_push(arena, out, comma);
} }
if(space_taken > max_size && idx+1 < array_count)
{
String8 ellipses = str8_lit("...");
space_taken += f_dim_from_tag_size_string(font, font_size, 0, 0, ellipses).x;
str8_list_push(arena, out, ellipses);
}
} }
} }
else else
@@ -8610,6 +8616,12 @@ df_append_value_strings_from_eval(Arena *arena, DF_EvalVizStringFlags flags, U32
space_taken += f_dim_from_tag_size_string(font, font_size, 0, 0, comma).x; space_taken += f_dim_from_tag_size_string(font, font_size, 0, 0, comma).x;
str8_list_push(arena, out, comma); str8_list_push(arena, out, comma);
} }
if(space_taken > max_size && member_idx+1 < filtered_data_members.count)
{
String8 ellipses = str8_lit("...");
space_taken += f_dim_from_tag_size_string(font, font_size, 0, 0, ellipses).x;
str8_list_push(arena, out, ellipses);
}
} }
} }
else else
+2
View File
@@ -141,6 +141,7 @@ e_dynamically_typed_eval_from_eval(E_Eval eval)
internal E_Eval internal E_Eval
e_value_eval_from_eval(E_Eval eval) e_value_eval_from_eval(E_Eval eval)
{ {
ProfBeginFunction();
if(eval.mode == E_Mode_Offset) if(eval.mode == E_Mode_Offset)
{ {
E_TypeKey type_key = e_type_unwrap(eval.type_key); E_TypeKey type_key = e_type_unwrap(eval.type_key);
@@ -190,6 +191,7 @@ e_value_eval_from_eval(E_Eval eval)
} }
} }
} }
ProfEnd();
return eval; return eval;
// TODO(rjf): @spaces check regs path // TODO(rjf): @spaces check regs path
+2
View File
@@ -22,6 +22,7 @@ e_select_interpret_ctx(E_InterpretCtx *ctx)
internal B32 internal B32
e_space_read(E_Space space, void *out, Rng1U64 range) e_space_read(E_Space space, void *out, Rng1U64 range)
{ {
ProfBeginFunction();
B32 result = 0; B32 result = 0;
switch(space) switch(space)
{ {
@@ -41,6 +42,7 @@ e_space_read(E_Space space, void *out, Rng1U64 range)
result = e_interpret_ctx->space_read(e_interpret_ctx->space_read_user_data, space, out, range); result = e_interpret_ctx->space_read(e_interpret_ctx->space_read_user_data, space, out, range);
}break; }break;
} }
ProfEnd();
return result; return result;
} }