ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-06 13:58:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

only retry call stacks on stale / gen tears, *not* on errored frames.

Browse Source
This commit is contained in:
Ryan Fleury
2025-10-23 17:41:49 -07:00
parent e6c3942ed3
commit c0d28e0ced
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ctrl/ctrl_core.c
+8 -5
View File
@@ -6502,6 +6502,7 @@ ctrl_call_stack_artifact_create(String8 key, B32 *cancel_signal, B32 *retry_out,
//- rjf: compute call stack //- rjf: compute call stack
CTRL_Entity *thread = ctrl_entity_from_handle(entity_ctx, thread_handle); CTRL_Entity *thread = ctrl_entity_from_handle(entity_ctx, thread_handle);
B32 good = 1; B32 good = 1;
B32 retry = 0;
Arena *arena = 0; Arena *arena = 0;
CTRL_CallStack *call_stack = 0; CTRL_CallStack *call_stack = 0;
if(thread != &ctrl_entity_nil) if(thread != &ctrl_entity_nil)
@@ -6524,12 +6525,17 @@ ctrl_call_stack_artifact_create(String8 key, B32 *cancel_signal, B32 *retry_out,
good = 1; good = 1;
call_stack[0] = ctrl_call_stack_from_unwind(arena, process, &unwind); call_stack[0] = ctrl_call_stack_from_unwind(arena, process, &unwind);
} }
if(unwind.flags & CTRL_UnwindFlag_Stale)
{
retry = 1;
}
post_reg_gen = ctrl_reg_gen(); post_reg_gen = ctrl_reg_gen();
post_mem_gen = ctrl_mem_gen(); post_mem_gen = ctrl_mem_gen();
} }
if(pre_reg_gen != post_reg_gen || pre_mem_gen != post_mem_gen) if(pre_reg_gen != post_reg_gen || pre_mem_gen != post_mem_gen)
{ {
good = 0; good = 0;
retry = 1;
} }
if(!good) if(!good)
{ {
@@ -6550,11 +6556,8 @@ ctrl_call_stack_artifact_create(String8 key, B32 *cancel_signal, B32 *retry_out,
artifact.u64[1] = (U64)call_stack; artifact.u64[1] = (U64)call_stack;
} }
//- rjf: retry on bad //- rjf: mark retry
if(!good) retry_out[0] = retry;
{
retry_out[0] = 1;
}
scratch_end(scratch); scratch_end(scratch);
} }