ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-14 17:28:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix incorrect GSI symbol compars that determ_test exposed

Browse Source
This commit is contained in:
Nikita Smith
2026-05-18 18:11:47 -07:00
parent ffb6cb8987
commit b8e85ab9ca
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/linker/pdb_ext/pdb_builder.c
+10 -2
View File
@@ -1783,7 +1783,7 @@ psi_addr_map_compar_is_before(void *raw_a, void *raw_b)
} else if (a->isect_off.off != b->isect_off.off) { } else if (a->isect_off.off != b->isect_off.off) {
is_before = a->isect_off.off < b->isect_off.off; is_before = a->isect_off.off < b->isect_off.off;
} else { } else {
is_before = str8_compar_case_sensitive(&a->name, &b->name); is_before = str8_compar_case_sensitive(&a->name, &b->name) < 0;
} }
return is_before; return is_before;
@@ -1832,6 +1832,12 @@ gsi_symbol_is_before(void *raw_a, void *raw_b)
int cmp = str8_compar_ignore_case(&a_name, &b_name); int cmp = str8_compar_ignore_case(&a_name, &b_name);
if (cmp == 0) { if (cmp == 0) {
cmp = u64_compar(&a->offset, &b->offset); cmp = u64_compar(&a->offset, &b->offset);
if (cmp == 0) {
cmp = a->kind < b->kind ? -1 : a->kind > b->kind ? +1 : 0;
if (cmp == 0) {
cmp = str8_compar(a->data, b->data, 0);
}
}
} }
is_before = cmp < 0; is_before = cmp < 0;
} }
@@ -1859,6 +1865,9 @@ gsi_pub_symbol_is_before(void *raw_a, void *raw_b)
cmp = u16_compar(&a_sym->sec, &b_sym->sec); cmp = u16_compar(&a_sym->sec, &b_sym->sec);
if (cmp == 0) { if (cmp == 0) {
cmp = u32_compar(&a_sym->off, &b_sym->off); cmp = u32_compar(&a_sym->off, &b_sym->off);
if (cmp == 0) {
cmp = str8_compar(a->data, b->data, 0);
}
} }
} }
@@ -3193,4 +3202,3 @@ pdb_string_from_src_error(PDB_SrcError error)
} }
return str8(0,0); return str8(0,0);
} }