ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-06 22:08:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

more aggressively commit changes to meta-entity edits in watch windows; undo if cancelling

Browse Source
This commit is contained in:
Ryan Fleury
2024-12-16 11:26:08 -08:00
parent ac54281062
commit 97241e73f9
2 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/raddbg/raddbg_main.c
+1 -3
View File
@@ -4,10 +4,8 @@
//////////////////////////////// ////////////////////////////////
//~ rjf: post-0.9.12 TODO notes //~ rjf: post-0.9.12 TODO notes
// //
// [ ] fullscreen with new custom borders are busted...
// [ ] breakpoints in optimized code? maybe early-terminating bp resolution loop? @bpmiss // [ ] breakpoints in optimized code? maybe early-terminating bp resolution loop? @bpmiss
// [ ] committing strings in target editor needs to be a bit more aggressive // - actually this seems to be potentially because of incomplete src-line-map info...
// if e.g. someone clicks away
// [ ] CLI argument over-mangling? // [ ] CLI argument over-mangling?
// [ ] OutputDebugString spam, keeping way too much around! // [ ] OutputDebugString spam, keeping way too much around!
// [ ] Mohit-reported breakpoint not hitting - may be similar thing to @bpmiss // [ ] Mohit-reported breakpoint not hitting - may be similar thing to @bpmiss
src/raddbg/raddbg_views.c
+18 -7
View File
@@ -1765,20 +1765,31 @@ rd_watch_view_build(RD_WatchViewState *ewv, RD_WatchViewFlags flags, String8 roo
}break; }break;
case RD_WatchViewColumnKind_Member: case RD_WatchViewColumnKind_Member:
case RD_WatchViewColumnKind_Value: case RD_WatchViewColumnKind_Value:
if(editing_complete && evt->slot != UI_EventActionSlot_Cancel)
{ {
EV_WindowedRowList rows = ev_windowed_row_list_from_block_range_list(scratch.arena, eval_view, filter, &block_ranges, r1u64(ui_scroll_list_row_from_item(&row_blocks, y), EV_WindowedRowList rows = ev_windowed_row_list_from_block_range_list(scratch.arena, eval_view, filter, &block_ranges, r1u64(ui_scroll_list_row_from_item(&row_blocks, y),
ui_scroll_list_row_from_item(&row_blocks, y)+1)); ui_scroll_list_row_from_item(&row_blocks, y)+1));
B32 success = 0;
if(rows.first != 0) if(rows.first != 0)
{ {
B32 should_commit_asap = editing_complete;
E_Expr *expr = rd_expr_from_watch_view_row_column(scratch.arena, eval_view, row, col); E_Expr *expr = rd_expr_from_watch_view_row_column(scratch.arena, eval_view, row, col);
E_Eval dst_eval = e_eval_from_expr(scratch.arena, expr); E_Eval dst_eval = e_eval_from_expr(scratch.arena, expr);
success = rd_commit_eval_value_string(dst_eval, new_string, !col->dequote_string); if(dst_eval.space.kind == RD_EvalSpaceKind_MetaEntity)
} {
if(!success) should_commit_asap = 1;
{ }
log_user_error(str8_lit("Could not commit value successfully.")); else if(evt->slot != UI_EventActionSlot_Cancel)
{
should_commit_asap = 0;
}
if(should_commit_asap)
{
B32 success = 0;
success = rd_commit_eval_value_string(dst_eval, new_string, !col->dequote_string);
if(!success)
{
log_user_error(str8_lit("Could not commit value successfully."));
}
}
} }
}break; }break;
case RD_WatchViewColumnKind_Type:{}break; case RD_WatchViewColumnKind_Type:{}break;