From 82fcc9ed4df33c5a6b0948a4fff2a540bdcbcb50 Mon Sep 17 00:00:00 2001
From: Ryan Fleury <ryan.j.fleury@gmail.com>
Date: Thu, 15 Aug 2024 14:57:16 -0700
Subject: [PATCH] evaluate breakpoints in per-breakpoint space, rather than a
 top-level space for all of the debugger entities

---
 src/df/core/df_core.c | 4 ++++
 src/df/gfx/df_views.c | 3 +--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/df/core/df_core.c b/src/df/core/df_core.c
index 5cf0caa9..986c9fd4 100644
--- a/src/df/core/df_core.c
+++ b/src/df/core/df_core.c
@@ -3696,6 +3696,10 @@ df_eval_space_read(void *u, E_Space space, void *out, Rng1U64 range)
   switch(entity->kind)
   {
     default:{}break;
+    case DF_EntityKind_Breakpoint:
+    {
+      // TODO(rjf)
+    }break;
     case DF_EntityKind_Process:
     {
       Temp scratch = scratch_begin(0, 0);
diff --git a/src/df/gfx/df_views.c b/src/df/gfx/df_views.c
index 28d9739c..972dde79 100644
--- a/src/df/gfx/df_views.c
+++ b/src/df/gfx/df_views.c
@@ -1422,9 +1422,8 @@ df_watch_view_build(DF_Window *ws, DF_Panel *panel, DF_View *view, DF_WatchViewS
                 E_TypeKey bp_type = e_type_key_cons(.kind = E_TypeKind_Struct, .name = str8_lit("Breakpoint"), .members = bp_members_array.v, .count = bp_members_array.count);
                 E_Eval eval =
                 {
-                  .value    = {.u64 = (U64)bp},
                   .mode     = E_Mode_Offset,
-                  .space    = (U64)df_entity_root(),
+                  .space    = (U64)bp,
                   .type_key = bp_type,
                 };
                 DF_CfgTable cfg_table = {0};