ed/raddebugger
1
0
Fork 0
mirror of https://github.com/Ed94/raddebugger.git synced 2026-08-08 06:48:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix clang warnings in dwarf -> rdi

Browse Source
This commit is contained in:
Ryan Fleury
2025-10-06 11:20:12 -07:00
parent da0028033d
commit 811f316ca2
1 changed files with 1568 additions and 1565 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/rdi_from_dwarf/rdi_from_dwarf.c
+16 -13
View File
@@ -214,8 +214,8 @@ d2r_range_list_from_tag(Arena *arena, DW_Input *input, DW_CompUnit *cu, U64 imag
} else {
// invalid low and hi PC are likely are caused by an optimization pass during linking
}
} else if (lo_pc_attrib->attrib_kind == DW_AttribKind_Null && hi_pc_attrib->attrib_kind != DW_AttribKind_Null ||
lo_pc_attrib->attrib_kind != DW_AttribKind_Null && hi_pc_attrib->attrib_kind == DW_AttribKind_Null) {
} else if ((lo_pc_attrib->attrib_kind == DW_AttribKind_Null && hi_pc_attrib->attrib_kind != DW_AttribKind_Null) ||
(lo_pc_attrib->attrib_kind != DW_AttribKind_Null && hi_pc_attrib->attrib_kind == DW_AttribKind_Null)) {
// TODO: error handling
}
}
@@ -729,29 +729,32 @@ d2r_float_type_from_bit_size(U64 bit_size)
internal RDI_EvalTypeGroup
d2r_value_type_to_rdi(D2R_ValueType v)
{
switch (v) {
RDI_EvalTypeGroup result = RDI_EvalTypeGroup_Other;
switch(v)
{
case D2R_ValueType_Generic:
return RDI_EvalTypeGroup_Other;
{result = RDI_EvalTypeGroup_Other;}break;
case D2R_ValueType_U8:
case D2R_ValueType_U16:
case D2R_ValueType_U32:
case D2R_ValueType_U64:
return RDI_EvalTypeGroup_U;
{result = RDI_EvalTypeGroup_U;}break;
case D2R_ValueType_S8:
case D2R_ValueType_S16:
case D2R_ValueType_S32:
case D2R_ValueType_S64:
return RDI_EvalTypeGroup_S;
{result = RDI_EvalTypeGroup_S;}break;
case D2R_ValueType_F32:
return RDI_EvalTypeGroup_F32;
{result = RDI_EvalTypeGroup_F32;}break;
case D2R_ValueType_F64:
return RDI_EvalTypeGroup_F64;
{result = RDI_EvalTypeGroup_F64;}break;
case D2R_ValueType_Address:
return RDI_EvalTypeGroup_U;
{result = RDI_EvalTypeGroup_U;}break;
default:
case D2R_ValueType_ImplicitValue:
AssertAlways(!"unable to convert value type to RDI equivalent");
{AssertAlways(!"unable to convert value type to RDI equivalent");}break;
}
return RDI_EvalTypeGroup_Other;
return result;
}
internal U64
@@ -794,8 +797,8 @@ d2r_pick_common_value_type(D2R_ValueType lhs, D2R_ValueType rhs)
return Max(lhs, rhs);
}
// (unsigned vs signed) || (signed vs unsigned)
else if (D2R_ValueType_IsUnsigned(lhs) && D2R_ValueType_IsSigned(rhs) ||
D2R_ValueType_IsSigned(lhs) && D2R_ValueType_IsUnsigned(rhs)) {
else if ((D2R_ValueType_IsUnsigned(lhs) && D2R_ValueType_IsSigned(rhs)) ||
(D2R_ValueType_IsSigned(lhs) && D2R_ValueType_IsUnsigned(rhs))) {
U64 lhs_size = d2r_size_from_value_type(0, lhs);
U64 rhs_size = d2r_size_from_value_type(0, rhs);
if (lhs_size < rhs_size) {